Skip to content

Commit 8eae0cf

Browse files
committed
U refactoring and warns about wrapjar property
1 parent 6975457 commit 8eae0cf

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/main/java/io/github/fvarrui/javapackager/packagers/CreateWindowsExeWinRun4j.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.apache.commons.lang3.StringUtils;
1111

1212
import io.github.fvarrui.javapackager.model.Platform;
13+
import io.github.fvarrui.javapackager.model.WindowsConfig;
1314
import io.github.fvarrui.javapackager.utils.CommandUtils;
1415
import io.github.fvarrui.javapackager.utils.FileUtils;
1516
import io.github.fvarrui.javapackager.utils.JarUtils;
@@ -55,6 +56,11 @@ protected File doApply(WindowsPackager packager) throws Exception {
5556
File jreDestinationFolder = packager.getJreDestinationFolder();
5657
boolean bundleJre = packager.getBundleJre();
5758
String vmLocation = packager.getWinConfig().getVmLocation();
59+
WindowsConfig winConfig = packager.getWinConfig();
60+
61+
if (winConfig.isWrapJar()) {
62+
Logger.warn("'wrapJar' property ignored when building EXE with " + getArtifactName());
63+
}
5864

5965
createAssets(packager);
6066

@@ -120,7 +126,7 @@ protected File doApply(WindowsPackager packager) throws Exception {
120126
// process EXE with rcedit-x64.exe
121127
CommandUtils.execute(rcedit, getGenericExe(), "--set-icon", getGenericIcon());
122128
CommandUtils.execute(rcedit, getGenericExe(), "--application-manifest", getGenericManifest());
123-
CommandUtils.execute(rcedit.getAbsolutePath(), getGenericExe(), "--set-version-string", "FileDescription", name);
129+
CommandUtils.execute(rcedit, getGenericExe(), "--set-version-string", "FileDescription", name);
124130

125131
// creates libs folder if it doesn't exist
126132
if (libsFolder == null) {

0 commit comments

Comments
 (0)