Skip to content

Commit 40f4de8

Browse files
committed
Merge branch 'issue-355' into devel
2 parents f68adae + 5159edf commit 40f4de8

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

src/main/java/io/github/fvarrui/javapackager/maven/CreateRunnableJar.java

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ protected File doApply(Packager packager) {
4545
File outputDirectory = packager.getOutputDirectory();
4646
ExecutionEnvironment env = Context.getMavenContext().getEnv();
4747
Manifest manifest = packager.getManifest();
48-
String artifactId = env.getMavenProject().getArtifactId();
49-
File jarFile = new File(outputDirectory, artifactId + "-" + classifier + ".jar");
5048

5149
List<Element> archive = new ArrayList<>();
5250
archive.add(
@@ -99,9 +97,22 @@ protected File doApply(Packager packager) {
9997

10098
}
10199

102-
File finalJarFile = new File(outputDirectory, name + "-" + version + "-" + classifier + ".jar");
103-
FileUtils.rename(jarFile, finalJarFile.getName());
104-
return finalJarFile;
100+
// gets build.finalName value
101+
String finalName = Context.getMavenContext().getEnv().getMavenProject().getBuild().getFinalName();
102+
103+
// creates file pointing to generated jar file
104+
File finalJarFile = new File(outputDirectory, finalName + "-" + classifier + ".jar");
105+
106+
// creates desired output jar file
107+
File jarFile = new File(outputDirectory, name + "-" + version + "-" + classifier + ".jar");
108+
109+
// renames generated jar to desired one if they are different
110+
if (!finalJarFile.equals(jarFile)) {
111+
FileUtils.rename(finalJarFile, jarFile.getName());
112+
}
113+
114+
return jarFile;
115+
105116
}
106117

107118
}

0 commit comments

Comments
 (0)