U fix issue #291

fvarrui · fvarrui · commit 28933b6cbc24 · 2023-02-07T22:16:46.000Z
diff --git a/src/main/java/io/github/fvarrui/javapackager/packagers/BundleJre.java b/src/main/java/io/github/fvarrui/javapackager/packagers/BundleJre.java
@@ -250,15 +250,15 @@ protected String getRequiredModules(File packagingJdk, File libsFolder, boolean
 
 		} else {
 			
-			modulesList = Arrays.asList("ALL-MODULE-PATH");
+			modulesList = new ArrayList<>();
 			
 		}
-				
-		modulesList.addAll(additionalModules);
 		
 		if (modulesList.isEmpty()) {
 			Logger.warn("It was not possible to determine the necessary modules. All modules will be included");
 			modulesList.add("ALL-MODULE-PATH");
+		} else {
+			modulesList.addAll(additionalModules);			
 		}
 		
 		Logger.infoUnindent("Required modules found: " + modulesList);

Original file line number	Diff line number	Diff line change
`@@ -250,15 +250,15 @@ protected String getRequiredModules(File packagingJdk, File libsFolder, boolean`
`250`	`250`
`251`	`251`	`} else {`
`252`	`252`
`253`		`- modulesList = Arrays.asList("ALL-MODULE-PATH");`
	`253`	`+ modulesList = new ArrayList<>();`
`254`	`254`
`255`	`255`	`}`
`256`		`-`
`257`		`- modulesList.addAll(additionalModules);`
`258`	`256`
`259`	`257`	`if (modulesList.isEmpty()) {`
`260`	`258`	`Logger.warn("It was not possible to determine the necessary modules. All modules will be included");`
`261`	`259`	`modulesList.add("ALL-MODULE-PATH");`
	`260`	`+ } else {`
	`261`	`+ modulesList.addAll(additionalModules);`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`Logger.infoUnindent("Required modules found: " + modulesList);`