Skip to content

Commit 23e1142

Browse files
authored
Merge pull request #279 from kerner1000/feature/custom-tarball-name
Support custom tarball name
2 parents ad81d81 + a7d8a19 commit 23e1142

File tree

6 files changed

+38
-6
lines changed

6 files changed

+38
-6
lines changed

src/main/java/io/github/fvarrui/javapackager/gradle/CreateTarball.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@ protected File doApply(Packager packager) throws Exception {
3636
File appFolder = packager.getAppFolder();
3737
File executable = packager.getExecutable();
3838
String jreDirectoryName = packager.getJreDirectoryName();
39-
40-
File tarFile = new File(outputDirectory, name + "-" + version + "-" + platform + ".tar.gz");
39+
40+
// tgz file name
41+
String finalName = packager.getTarballName() != null ? packager.getTarballName() : name + "-" + version + "-" + platform;
42+
String format = ".tar.gz";
43+
File tarFile = new File(outputDirectory, finalName + format);
4144

4245
Tar tarTask = createTarTask();
4346
tarTask.setProperty("archiveFileName", tarFile.getName());

src/main/java/io/github/fvarrui/javapackager/gradle/CreateZipball.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ protected File doApply(Packager packager) throws Exception {
3535
File appFolder = packager.getAppFolder();
3636
File executable = packager.getExecutable();
3737
String jreDirectoryName = packager.getJreDirectoryName();
38-
39-
File zipFile = new File(outputDirectory, name + "-" + version + "-" + platform + ".zip");
38+
39+
String zipFileName = packager.getZipballName() != null ? packager.getZipballName() : name + "-" + version + "-" + platform + ".zip";
40+
File zipFile = new File(outputDirectory, zipFileName);
4041

4142
Zip zipTask = createZipTask();
4243
zipTask.setProperty("archiveFileName", zipFile.getName());

src/main/java/io/github/fvarrui/javapackager/maven/CreateTarball.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ protected File doApply(Packager packager) {
4747
VelocityUtils.render(platform + "/assembly.xml.vtl", assemblyFile, packager);
4848

4949
// tgz file name
50-
String finalName = name + "-" + version + "-" + platform;
50+
String finalName = packager.getTarballName() != null ? packager.getTarballName() : name + "-" + version + "-" + platform;
5151
String format = "tar.gz";
5252

5353
// invokes plugin to assemble tarball

src/main/java/io/github/fvarrui/javapackager/maven/CreateZipball.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ protected File doApply(Packager packager) {
4747
VelocityUtils.render(platform + "/assembly.xml.vtl", assemblyFile, packager);
4848

4949
// zip file name and format
50-
String finalName = name + "-" + version + "-" + platform;
50+
String finalName = packager.getZipballName() != null ? packager.getZipballName() : name + "-" + version + "-" + platform;
5151
String format = "zip";
5252

5353
// invokes plugin to assemble zipball and/or tarball

src/main/java/io/github/fvarrui/javapackager/maven/PackageMojo.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,18 @@ public class PackageMojo extends AbstractMojo {
244244
@Parameter(defaultValue = "false", property = "createTarball", required = false)
245245
private Boolean createTarball;
246246

247+
@Parameter(property = "tarballName", required = false)
248+
private String tarballName;
249+
247250
/**
248251
* Bundles app in a zipball file
249252
*/
250253
@Parameter(defaultValue = "false", property = "createZipball", required = false)
251254
private Boolean createZipball;
252255

256+
@Parameter(property = "zipballName", required = false)
257+
private String zipballName;
258+
253259
/**
254260
* Extra properties for customized Velocity templates, accesible through '$this.extra' map.
255261
*/
@@ -340,7 +346,9 @@ public void execute() throws MojoExecutionException {
340346
.classpath(classpath)
341347
.copyDependencies(copyDependencies)
342348
.createTarball(createTarball)
349+
.tarballName(tarballName)
343350
.createZipball(createZipball)
351+
.zipballName(zipballName)
344352
.customizedJre(customizedJre)
345353
.description(description)
346354
.displayName(displayName)

src/main/java/io/github/fvarrui/javapackager/packagers/PackagerSettings.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ public class PackagerSettings {
4747
protected LinuxConfig linuxConfig;
4848
protected MacConfig macConfig;
4949
protected Boolean createTarball;
50+
protected String tarballName;
5051
protected Boolean createZipball;
52+
protected String zipballName;
5153
protected Map<String, String> extra;
5254
protected boolean useResourcesAsWorkingDir;
5355
protected File assetsDir;
@@ -736,6 +738,15 @@ public PackagerSettings createTarball(Boolean createTarball) {
736738
return this;
737739
}
738740

741+
public PackagerSettings tarballName(String tarballName) {
742+
this.tarballName = tarballName;
743+
return this;
744+
}
745+
746+
public String getTarballName() {
747+
return tarballName;
748+
}
749+
739750
/**
740751
* Set create zipball
741752
* @param createZipball Create zipball
@@ -746,6 +757,15 @@ public PackagerSettings createZipball(Boolean createZipball) {
746757
return this;
747758
}
748759

760+
public PackagerSettings zipballName(String zipballName) {
761+
this.zipballName = zipballName;
762+
return this;
763+
}
764+
765+
public String getZipballName() {
766+
return zipballName;
767+
}
768+
749769
/**
750770
* Set extra parameters map
751771
* @param extra Extra parameters map

0 commit comments

Comments
 (0)