Skip to content

Commit 16d185a

Browse files
committed
U decouple fileutils from packager
1 parent 2149662 commit 16d185a

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

src/main/java/io/github/fvarrui/javapackager/packagers/CreateWindowsExeWhy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ protected File doApply(WindowsPackager packager) throws Exception {
5353
FileUtils.copyFileToFile(iconFile, getGenericIcon());
5454

5555
// creates generic exe
56-
FileUtils.copyResourceToFile("/windows/JavaLauncher.exe", getGenericExe(), packager);
56+
FileUtils.copyResourceToFile("/windows/JavaLauncher.exe", getGenericExe(), packager.getAssetsDir());
5757

5858
// copies rcedit command line tool (needed to manipulate exe)
5959
File rcedit = new File(getOutputFolder(), "rcedit.exe");

src/main/java/io/github/fvarrui/javapackager/packagers/MacPackager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public File doCreateApp() throws Exception {
113113

114114
// copies universalJavaApplicationStub startup file to boot java app
115115
File appStubFile = new File(macOSFolder, "universalJavaApplicationStub");
116-
FileUtils.copyResourceToFile("/mac/universalJavaApplicationStub", appStubFile, true, this);
116+
FileUtils.copyResourceToFile("/mac/universalJavaApplicationStub", appStubFile, true, this.getAssetsDir());
117117
FileUtils.processFileContent(appStubFile, content -> {
118118
if (!macConfig.isRelocateJar()) {
119119
content = content.replaceAll("/Contents/Resources/Java", "/Contents/Resources");

src/main/java/io/github/fvarrui/javapackager/utils/FileUtils.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.regex.Pattern;
2626
import java.util.stream.Collectors;
2727

28-
import io.github.fvarrui.javapackager.packagers.Packager;
2928
import org.apache.commons.io.IOUtils;
3029
import org.apache.commons.lang3.StringUtils;
3130

@@ -198,8 +197,8 @@ public static void copyResourceToFile(String resource, File dest, boolean unixSt
198197
copyResourceToFile(resource, dest, unixStyleNewLines, null);
199198
}
200199

201-
public static void copyResourceToFile(String resource, File dest, boolean unixStyleNewLines, Packager packager) throws Exception {
202-
copyResourceToFile(resource, dest, packager);
200+
public static void copyResourceToFile(String resource, File dest, boolean unixStyleNewLines, File assetsDir) throws Exception {
201+
copyResourceToFile(resource, dest, assetsDir);
203202
if (unixStyleNewLines) {
204203
try {
205204
processFileContent(dest, c -> c.replaceAll("\\r\\n", "\n").replaceAll("\\r", "\n"));
@@ -219,17 +218,16 @@ public static void copyResourceToFile(String resource, File dest) throws Excepti
219218
copyResourceToFile(resource, dest, null);
220219
}
221220

222-
public static void copyResourceToFile(String resource, File dest, Packager packager) throws Exception {
223-
if (packager != null) {
221+
public static void copyResourceToFile(String resource, File dest, File assetsDir) throws Exception {
222+
if (assetsDir != null) {
224223
String rsc = resource.startsWith("/") ? resource.substring(1) : resource;
225-
Path asset = packager.getAssetsDir().toPath().resolve(rsc);
224+
Path asset = assetsDir.toPath().resolve(rsc);
226225
if (Files.exists(asset)) {
227226
Logger.info("Copying resource [" + asset + "] to file [" + dest + "]");
228227
copyFileToFile(asset.toFile(), dest);
229228
return;
230229
}
231230
}
232-
233231
Logger.info("Copying resource [" + resource + "] to file [" + dest + "]");
234232
copyStreamToFile(FileUtils.class.getResourceAsStream(resource), dest);
235233
}

0 commit comments

Comments
 (0)