Skip to content

Commit 09c0949

Browse files
committed
U refactoring
1 parent e395c51 commit 09c0949

File tree

8 files changed

+54
-42
lines changed

8 files changed

+54
-42
lines changed

src/main/java/io/github/fvarrui/javapackager/gradle/PackagePluginExtension.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.gradle.api.Project;
88

99
import groovy.lang.Closure;
10+
import io.github.fvarrui.javapackager.model.Arch;
1011
import io.github.fvarrui.javapackager.model.LinuxConfig;
1112
import io.github.fvarrui.javapackager.model.MacConfig;
1213
import io.github.fvarrui.javapackager.model.Manifest;
@@ -52,6 +53,7 @@ public PackagePluginExtension(Project project) {
5253
this.outputDirectory = project.getBuildDir();
5354
this.scripts = new Scripts();
5455
this.forceInstaller = false;
56+
this.arch = Arch.x64;
5557
}
5658

5759
public LinuxConfig linuxConfig(Closure<LinuxConfig> closure) {

src/main/java/io/github/fvarrui/javapackager/gradle/PackageTask.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import org.gradle.api.tasks.OutputDirectory;
1515

1616
import groovy.lang.Closure;
17+
import io.github.fvarrui.javapackager.model.Arch;
1718
import io.github.fvarrui.javapackager.model.FileAssociation;
1819
import io.github.fvarrui.javapackager.model.LinuxConfig;
1920
import io.github.fvarrui.javapackager.model.MacConfig;
@@ -559,6 +560,18 @@ public Scripts scripts(Closure<Scripts> closure) {
559560
getProject().configure(scripts, closure);
560561
return scripts;
561562
}
563+
564+
@Input
565+
@Optional
566+
private Arch arch;
567+
568+
public Arch getArch() {
569+
return arch;
570+
}
571+
572+
public void setArch(Arch arch) {
573+
this.arch = arch;
574+
}
562575

563576
// ===============
564577
// create packager
@@ -577,6 +590,7 @@ protected Packager createPackager() throws Exception {
577590
.additionalModulePaths(defaultIfNull(additionalModulePaths, extension.getAdditionalModulePaths()))
578591
.additionalResources(defaultIfNull(additionalResources, extension.getAdditionalResources()))
579592
.administratorRequired(defaultIfNull(administratorRequired, extension.getAdministratorRequired()))
593+
.arch(defaultIfNull(arch, extension.getArch()))
580594
.assetsDir(defaultIfNull(assetsDir, extension.getAssetsDir()))
581595
.bundleJre(defaultIfNull(bundleJre, extension.getBundleJre()))
582596
.classpath(defaultIfNull(classpath, extension.getClasspath()))

src/main/java/io/github/fvarrui/javapackager/maven/PackageMojo.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,11 @@ public class PackageMojo extends AbstractMojo {
309309
@Parameter(property = "scripts", required = false)
310310
private Scripts scripts;
311311

312+
/**
313+
* Architecture
314+
*/
312315
@Parameter(property = "arch", required = false, defaultValue="x64")
313-
private JavaArch arch;
316+
private Arch arch;
314317

315318
public void execute() throws MojoExecutionException {
316319

@@ -330,6 +333,7 @@ public void execute() throws MojoExecutionException {
330333
.additionalModulePaths(additionalModulePaths)
331334
.additionalResources(additionalResources)
332335
.administratorRequired(administratorRequired)
336+
.arch(arch)
333337
.assetsDir(assetsDir)
334338
.bundleJre(bundleJre)
335339
.classpath(classpath)
@@ -367,8 +371,7 @@ public void execute() throws MojoExecutionException {
367371
.url(url)
368372
.version(version)
369373
.vmArgs(vmArgs)
370-
.winConfig(winConfig)
371-
.arch(arch);
374+
.winConfig(winConfig);
372375

373376
// generate app, installers and bundles
374377
packager.createApp();
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
package io.github.fvarrui.javapackager.model;
2+
3+
public enum Arch {
4+
aarch64("arm64", "AARCH64"),
5+
x64("amd64", "X86_64"),
6+
x86("i386", "i386");
7+
8+
private String deb;
9+
private String rpm;
10+
11+
Arch(String deb, String rpm) {
12+
this.deb = deb;
13+
this.rpm = rpm;
14+
}
15+
16+
public String getDeb() {
17+
return deb;
18+
}
19+
20+
public String getRpm() {
21+
return rpm;
22+
}
23+
24+
}

src/main/java/io/github/fvarrui/javapackager/model/JavaArch.java

Lines changed: 0 additions & 22 deletions
This file was deleted.

src/main/java/io/github/fvarrui/javapackager/packagers/GenerateRpm.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ protected File doApply(LinuxPackager packager) throws Exception {
4242
File executable = packager.getExecutable();
4343
File assetsFolder = packager.getAssetsFolder();
4444
String jreDirectoryName = packager.getJreDirectoryName();
45+
Architecture arch = Architecture.valueOf(packager.getArch().getRpm());
4546

4647
// generates desktop file from velocity template
4748
File desktopFile = new File(assetsFolder, name + ".desktop");
@@ -53,8 +54,7 @@ protected File doApply(LinuxPackager packager) throws Exception {
5354

5455
Builder builder = new Builder();
5556
builder.setType(RpmType.BINARY);
56-
Architecture archForRpm = packager.getArchForRpm();
57-
builder.setPlatform(archForRpm, Os.LINUX);
57+
builder.setPlatform(arch, Os.LINUX);
5858
builder.setPackage(name, version, "1");
5959
builder.setPackager(organizationName);
6060
builder.setDescription(description);
@@ -77,8 +77,7 @@ protected File doApply(LinuxPackager packager) throws Exception {
7777

7878
builder.build(outputDirectory);
7979

80-
String arch = archForRpm.name().toLowerCase();
81-
String suffix = "-1."+arch+".rpm";
80+
String suffix = "-1." + arch.name().toLowerCase() + ".rpm";
8281
File originalRpm = new File(outputDirectory, name + "-" + version + suffix);
8382
File rpm = null;
8483
if (originalRpm.exists()) {

src/main/java/io/github/fvarrui/javapackager/packagers/PackagerSettings.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ public class PackagerSettings {
5858
protected List<FileAssociation> fileAssociations;
5959
protected File packagingJdk;
6060
protected Scripts scripts;
61-
62-
private JavaArch arch;
61+
protected Arch arch;
62+
6363
/**
6464
* Get packaging JDK
6565
* @return Packaging JDK
@@ -856,23 +856,15 @@ public String getMimeTypesListAsString(String separator) {
856856
separator);
857857
}
858858

859-
public JavaArch getArch() {
859+
public Arch getArch() {
860860
return arch;
861861
}
862862

863-
public PackagerSettings arch(JavaArch arch) {
863+
public PackagerSettings arch(Arch arch) {
864864
this.arch = arch;
865865
return this;
866866
}
867867

868-
public String getArchForDeb() {
869-
return arch.getDeb();
870-
}
871-
872-
public Architecture getArchForRpm() {
873-
return Architecture.valueOf(arch.getRpm());
874-
}
875-
876868
@Override
877869
public String toString() {
878870
return "PackagerSettings [outputDirectory=" + outputDirectory + ", licenseFile=" + licenseFile + ", iconFile="

src/main/resources/linux/control.vtl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Package: ${info.name}
22
Version: ${info.version}
33
Section: misc
44
Priority: optional
5-
Architecture: ${info.archForDeb}
5+
Architecture: ${info.arch.deb}
66
Maintainer: ${info.organizationName} <$!{info.organizationEmail}>
77
Description: ${info.description}
88
Distribution: development

0 commit comments

Comments
 (0)