Fixed idea warnings.

javadev · web-flow · commit 65b9f1289e79 · 2022-06-26T09:32:08.000+03:00
diff --git a/build.gradle b/build.gradle
@@ -50,6 +50,7 @@ spotless {
         encoding 'UTF-8'
         target fileTree(projectDir) {
             include '**/src/**/*.java'
+            exclude '**/build/**'
         }
         importOrder '\\#', '', '*'
         removeUnusedImports()
diff --git a/src/main/java/g0001_0100/s0004_median_of_two_sorted_arrays/Solution.java b/src/main/java/g0001_0100/s0004_median_of_two_sorted_arrays/Solution.java
@@ -9,8 +9,8 @@ public double findMedianSortedArrays(int[] nums1, int[] nums2) {
         if (nums2.length < nums1.length) {
             return findMedianSortedArrays(nums2, nums1);
         }
-        int cut1 = 0;
-        int cut2 = 0;
+        int cut1;
+        int cut2;
         int n1 = nums1.length;
         int n2 = nums2.length;
         int low = 0;
diff --git a/src/main/java/g0301_0400/s0367_valid_perfect_square/Solution.java b/src/main/java/g0301_0400/s0367_valid_perfect_square/Solution.java
@@ -12,7 +12,7 @@ public boolean isPerfectSquare(int num) {
         // long datatype can holds huge number.
         long start = 0;
         long end = num;
-        long mid = 0;
+        long mid;
         while (start <= end) {
             // until start is lesser or equal to end do this
             // Finding middle value
diff --git a/src/main/java/g0301_0400/s0388_longest_absolute_file_path/Solution.java b/src/main/java/g0301_0400/s0388_longest_absolute_file_path/Solution.java
@@ -11,7 +11,7 @@ public int lengthLongestPath(String input) {
         int longestLen = 0;
         int currDirLen = 0;
         int i = 0;
-        int currLevel = 0;
+        int currLevel;
         int nextLevel = 0;
         boolean isFile = false;
         Character period = '.';
diff --git a/src/main/java/g0301_0400/s0397_integer_replacement/Solution.java b/src/main/java/g0301_0400/s0397_integer_replacement/Solution.java
@@ -19,7 +19,7 @@ private int solve(int n, Map<Integer, Integer> dp) {
         if (dp.containsKey(n)) {
             return dp.get(n);
         }
-        int ans = 0;
+        int ans;
         if (n % 2 == 0) {
             ans = 1 + solve(n >>> 1, dp);
         } else {
diff --git a/src/main/java/g0501_0600/s0537_complex_number_multiplication/Solution.java b/src/main/java/g0501_0600/s0537_complex_number_multiplication/Solution.java
@@ -4,8 +4,8 @@
 
 public class Solution {
     public String complexNumberMultiply(String num1, String num2) {
-        int countReal = 0;
-        int countImagine = 0;
+        int countReal;
+        int countImagine;
         int[] arr1 = new int[2];
         int[] arr2 = new int[2];
 
diff --git a/src/main/java/g0501_0600/s0546_remove_boxes/Solution.java b/src/main/java/g0501_0600/s0546_remove_boxes/Solution.java
@@ -25,7 +25,7 @@ private int helper(int[] boxes, int left, int right, int count) {
             leftDash++;
             countDash++;
         }
-        int ans = 0;
+        int ans;
         ans = helper(boxes, leftDash + 1, right, 0) + (countDash + 1) * (countDash + 1);
         for (int i = leftDash + 1; i <= right; i++) {
             if (boxes[i] == boxes[leftDash]) {
diff --git a/src/main/java/g0501_0600/s0557_reverse_words_in_a_string_iii/Solution.java b/src/main/java/g0501_0600/s0557_reverse_words_in_a_string_iii/Solution.java
@@ -5,7 +5,7 @@
 
 public class Solution {
     public String reverseWords(String s) {
-        int l = 0;
+        int l;
         int r = 0;
         int len = s.length();
         char[] ch = s.toCharArray();
diff --git a/src/main/java/g0501_0600/s0565_array_nesting/Solution.java b/src/main/java/g0501_0600/s0565_array_nesting/Solution.java
@@ -4,10 +4,10 @@
 
 public class Solution {
     public int arrayNesting(int[] nums) {
-        int index = -1;
-        int value = 0;
+        int index;
+        int value;
         int maxLen = 0;
-        int len = 0;
+        int len;
         for (int i = 0; i < nums.length; i++) {
             if (nums[i] != -1) {
                 index = i;
diff --git a/src/main/java/g0701_0800/s0784_letter_case_permutation/Solution.java b/src/main/java/g0701_0800/s0784_letter_case_permutation/Solution.java
@@ -20,13 +20,13 @@ public void helper(String s, int curr, String temp) {
             return;
         }
         if (Character.isDigit(s.charAt(curr))) {
-            helper(s, curr + 1, temp + s.substring(curr, curr + 1));
+            helper(s, curr + 1, temp + s.charAt(curr));
         } else {
             if (Character.isLowerCase(s.charAt(curr))) {
-                helper(s, curr + 1, temp + s.substring(curr, curr + 1));
+                helper(s, curr + 1, temp + s.charAt(curr));
                 helper(s, curr + 1, temp + (s.substring(curr, curr + 1)).toUpperCase());
             } else {
-                helper(s, curr + 1, temp + s.substring(curr, curr + 1));
+                helper(s, curr + 1, temp + s.charAt(curr));
                 helper(s, curr + 1, temp + (s.substring(curr, curr + 1)).toLowerCase());
             }
         }
diff --git a/src/main/java/g0801_0900/s0849_maximize_distance_to_closest_person/Solution.java b/src/main/java/g0801_0900/s0849_maximize_distance_to_closest_person/Solution.java
@@ -35,7 +35,7 @@ private void extend(int[] seats, int position) {
                 break;
             }
         }
-        int maxReach = 0;
+        int maxReach;
         if (position == 0) {
             maxReach = rightMinDistance;
         } else if (position == seats.length - 1) {
diff --git a/src/main/java/g0801_0900/s0859_buddy_strings/Solution.java b/src/main/java/g0801_0900/s0859_buddy_strings/Solution.java
@@ -5,7 +5,7 @@
 public class Solution {
     public boolean buddyStrings(String s, String goal) {
         int first = -1;
-        int second = -1;
+        int second;
         int[] sCounts = new int[26];
         if (s.equals(goal)) {
             for (int i = 0; i < s.length(); i++) {
diff --git a/src/main/java/g0901_1000/s0920_number_of_music_playlists/Solution.java b/src/main/java/g0901_1000/s0920_number_of_music_playlists/Solution.java
@@ -21,7 +21,7 @@ private long helper(int songNumber, int l, int usedSong, int n, int k, long[][]
         if (dp[songNumber][usedSong] != -1) {
             return dp[songNumber][usedSong];
         }
-        long ans = 0;
+        long ans;
         if (songNumber < k) {
             ans = (n - usedSong) * helper(songNumber + 1, l, usedSong + 1, n, k, dp);
         } else if (usedSong == n) {
diff --git a/src/main/java/g0901_1000/s0957_prison_cells_after_n_days/Solution.java b/src/main/java/g0901_1000/s0957_prison_cells_after_n_days/Solution.java
@@ -12,7 +12,7 @@ public int[] prisonAfterNDays(int[] cells, int n) {
         }
         int[] first = null;
         int[] prev = cells;
-        int period = -1;
+        int period;
         int day = 0;
         while (n > 0) {
             day++;
diff --git a/src/main/java/g1001_1100/s1006_clumsy_factorial/Solution.java b/src/main/java/g1001_1100/s1006_clumsy_factorial/Solution.java
@@ -6,7 +6,7 @@ public class Solution {
     private int m = 1;
 
     public int clumsy(int n) {
-        int num = 0;
+        int num;
         if (n >= 4) {
             num = m * n * (n - 1) / (n - 2) + (n - 3);
         } else if (n == 3) {
diff --git a/src/main/java/g1001_1100/s1007_minimum_domino_rotations_for_equal_row/Solution.java b/src/main/java/g1001_1100/s1007_minimum_domino_rotations_for_equal_row/Solution.java
@@ -7,8 +7,8 @@ public int minDominoRotations(int[] tops, int[] bottoms) {
         int top = tops[0];
         int tCount = 0;
         int bCount = 0;
-        int tSwaps = 0;
-        int bSwaps = 0;
+        int tSwaps;
+        int bSwaps;
         int swaps = 0;
         boolean valid = true;
         for (int i = 0; i < tops.length; i++) {
@@ -32,8 +32,8 @@ public int minDominoRotations(int[] tops, int[] bottoms) {
         int bottom = bottoms[0];
         int tCount1 = 0;
         int bCount1 = 0;
-        int tSwaps1 = 0;
-        int bSwaps1 = 0;
+        int tSwaps1;
+        int bSwaps1;
         int swaps1 = 0;
         boolean valid1 = true;
         for (int i = 0; i < bottoms.length; i++) {
diff --git a/src/main/java/g1001_1100/s1012_numbers_with_repeated_digits/Solution.java b/src/main/java/g1001_1100/s1012_numbers_with_repeated_digits/Solution.java
@@ -10,7 +10,7 @@ public class Solution {
 
     public int numDupDigitsAtMostN(int n) {
         int nStrLength = String.valueOf(n).length();
-        int allNineLength = 0;
+        int allNineLength;
         if (n < 0 || nStrLength < 2) {
             return 0;
         } else if (Math.pow(10, nStrLength) - 1 == n) {
diff --git a/src/main/java/g1001_1100/s1021_remove_outermost_parentheses/Solution.java b/src/main/java/g1001_1100/s1021_remove_outermost_parentheses/Solution.java
@@ -25,7 +25,7 @@ public String removeOuterParentheses(String s) {
         }
         StringBuilder sb = new StringBuilder();
         for (String primitive : primitives) {
-            sb.append(primitive.substring(1, primitive.length() - 1));
+            sb.append(primitive, 1, primitive.length() - 1);
         }
         return sb.toString();
     }
diff --git a/src/main/java/g1001_1100/s1040_moving_stones_until_consecutive_ii/Solution.java b/src/main/java/g1001_1100/s1040_moving_stones_until_consecutive_ii/Solution.java
@@ -29,7 +29,7 @@ public int[] numMovesStonesII(int[] stones) {
             j++;
         }
         ans[0] = minMoves;
-        int maxMoves = 0;
+        int maxMoves;
         if (stones[1] == stones[0] + 1 || stones[n - 1] == stones[n - 2] + 1) {
             maxMoves = stones[n - 1] - stones[0] + 1 - n;
         } else {
diff --git a/src/main/java/g1101_1200/s1106_parsing_a_boolean_expression/Solution.java b/src/main/java/g1101_1200/s1106_parsing_a_boolean_expression/Solution.java
@@ -18,7 +18,7 @@ public boolean parseBoolExpr(String expression) {
     }
 
     private boolean expr() {
-        boolean res = false;
+        boolean res;
         if (match('!')) {
             res = not();
         } else if (match('&')) {
diff --git a/src/main/java/g1401_1500/s1423_maximum_points_you_can_obtain_from_cards/Solution.java b/src/main/java/g1401_1500/s1423_maximum_points_you_can_obtain_from_cards/Solution.java
@@ -5,7 +5,7 @@
 public class Solution {
     public int maxScore(int[] cardPoints, int k) {
         int currSum = 0;
-        int maxSum = 0;
+        int maxSum;
         for (int i = 0; i < k; i++) {
             currSum += cardPoints[i];
         }
diff --git a/src/main/java/g1401_1500/s1436_destination_city/Solution.java b/src/main/java/g1401_1500/s1436_destination_city/Solution.java
@@ -9,12 +9,12 @@
 public class Solution {
     public String destCity(List<List<String>> paths) {
         Set<String> set = new HashSet<>();
-        for (int i = 0; i < paths.size(); i++) {
-            set.add(paths.get(i).get(0));
+        for (List<String> strings : paths) {
+            set.add(strings.get(0));
         }
-        for (int i = 0; i < paths.size(); i++) {
-            if (!set.contains(paths.get(i).get(1))) {
-                return paths.get(i).get(1);
+        for (List<String> path : paths) {
+            if (!set.contains(path.get(1))) {
+                return path.get(1);
             }
         }
         return "";
diff --git a/src/main/java/g1601_1700/s1620_coordinate_with_maximum_network_quality/Solution.java b/src/main/java/g1601_1700/s1620_coordinate_with_maximum_network_quality/Solution.java
@@ -6,7 +6,7 @@ public class Solution {
     public int[] bestCoordinate(int[][] towers, int radius) {
         int[] res = new int[2];
         double maxQuality = 0;
-        double quality = 0;
+        double quality;
         int finalX = 0;
         int finalY = 0;
         for (int i = 0; i < 51; i++) {
diff --git a/src/main/java/g1601_1700/s1672_richest_customer_wealth/Solution.java b/src/main/java/g1601_1700/s1672_richest_customer_wealth/Solution.java
@@ -8,8 +8,8 @@ public int maximumWealth(int[][] accounts) {
         int max = Integer.MIN_VALUE;
         for (int[] account : accounts) {
             int sum = 0;
-            for (int j = 0; j < account.length; j++) {
-                sum += account[j];
+            for (int i : account) {
+                sum += i;
             }
             max = Math.max(max, sum);
         }
diff --git a/src/main/java/g1701_1800/s1742_maximum_number_of_balls_in_a_box/Solution.java b/src/main/java/g1701_1800/s1742_maximum_number_of_balls_in_a_box/Solution.java
@@ -4,7 +4,7 @@
 
 public class Solution {
     public int countBalls(int lowLimit, int highLimit) {
-        int maxValue = 0;
+        int maxValue;
         int[] countArray = new int[46];
         int currentSum = getDigitSum(lowLimit);
         countArray[currentSum]++;
diff --git a/src/main/java/g1701_1800/s1793_maximum_score_of_a_good_subarray/Solution.java b/src/main/java/g1701_1800/s1793_maximum_score_of_a_good_subarray/Solution.java
@@ -9,7 +9,7 @@ public int maximumScore(int[] nums, int k) {
         int j = k;
         int res = nums[k];
         int min = nums[k];
-        boolean goLeft = true;
+        boolean goLeft;
         while (i >= 1 || j < nums.length - 1) {
             // sub array [i...j] is already traversed. Either goLeft or goRight to increase the
             // sequence
diff --git a/src/main/java/g1901_2000/s1979_find_greatest_common_divisor_of_array/Solution.java b/src/main/java/g1901_2000/s1979_find_greatest_common_divisor_of_array/Solution.java
@@ -6,19 +6,19 @@ public class Solution {
     public int findGCD(int[] nums) {
         int max = Integer.MIN_VALUE;
         int min = Integer.MAX_VALUE;
-        for (int i = 0; i < nums.length; i++) {
-            if (max < nums[i]) {
-                max = nums[i];
+        for (int num : nums) {
+            if (max < num) {
+                max = num;
             }
-            if (min > nums[i]) {
-                min = nums[i];
+            if (min > num) {
+                min = num;
             }
         }
         return findGCD(max, min);
     }
 
     private int findGCD(int x, int y) {
-        int r = 0;
+        int r;
         int a;
         int b;
         a = (x > y) ? x : y;
diff --git a/src/main/java/g2001_2100/s2074_reverse_nodes_in_even_length_groups/Solution.java b/src/main/java/g2001_2100/s2074_reverse_nodes_in_even_length_groups/Solution.java
@@ -40,7 +40,7 @@ public ListNode reverseEvenLengthGroups(ListNode head) {
 
     private ListNode[] reverse(ListNode head, int size) {
         ListNode prev = null;
-        ListNode forward = null;
+        ListNode forward;
         ListNode cur = head;
         while (size-- > 0) {
             forward = cur.next;
diff --git a/src/main/java/g2001_2100/s2091_removing_minimum_and_maximum_from_array/Solution.java b/src/main/java/g2001_2100/s2091_removing_minimum_and_maximum_from_array/Solution.java
@@ -19,9 +19,9 @@ public int minimumDeletions(int[] nums) {
                 maxIndex = i;
             }
         }
-        int firstCase = 0;
-        int secondCase = 0;
-        int thirdCase = 0;
+        int firstCase;
+        int secondCase;
+        int thirdCase;
         if (minIndex > maxIndex) {
             firstCase = minIndex + 1;
             secondCase = n - maxIndex;
diff --git a/src/main/java/g2101_2200/s2165_smallest_value_of_the_rearranged_number/Solution.java b/src/main/java/g2101_2200/s2165_smallest_value_of_the_rearranged_number/Solution.java
@@ -5,7 +5,7 @@
 public class Solution {
     public long smallestNumber(long num) {
         int[] count = new int[10];
-        long tempNum = 0;
+        long tempNum;
         if (num > 0) {
             tempNum = num;
         } else {
diff --git a/src/main/java/g2201_2300/s2267_check_if_there_is_a_valid_parentheses_string_path/Solution.java b/src/main/java/g2201_2300/s2267_check_if_there_is_a_valid_parentheses_string_path/Solution.java
@@ -46,7 +46,7 @@ private boolean dfs(int u, int v, int open, int close, Boolean[][][] dp) {
         if (v == n - 1) {
             return dfs(u + 1, v, open, close, dp);
         }
-        boolean rslt = false;
+        boolean rslt;
         if (grid[u][v] == LFTPAR) {
             rslt = dfs(u + 1, v, open, close, dp) || dfs(u, v + 1, open, close, dp);
         } else {
diff --git a/src/main/java/g2201_2300/s2276_count_integers_in_intervals/CountIntervals.java b/src/main/java/g2201_2300/s2276_count_integers_in_intervals/CountIntervals.java
@@ -7,7 +7,7 @@
 
 public class CountIntervals {
     private final TreeMap<Integer, Integer> map;
-    private int count = 0;
+    private int count;
 
     public CountIntervals() {
         map = new TreeMap<>();
diff --git a/src/main/java/g2301_2400/s2309_greatest_english_letter_in_upper_and_lower_case/Solution.java b/src/main/java/g2301_2400/s2309_greatest_english_letter_in_upper_and_lower_case/Solution.java
@@ -8,7 +8,7 @@ public String greatestLetter(String s) {
         boolean[] sA = new boolean[26];
         boolean[] uA = new boolean[26];
         for (char ch : s.toCharArray()) {
-            int i = 0;
+            int i;
             if (ch <= 'Z' && ch >= 'A') {
                 i = ch - 'A';
                 uA[i] = true;
diff --git a/src/test/java/g0701_0800/s0784_letter_case_permutation/SolutionTest.java b/src/test/java/g0701_0800/s0784_letter_case_permutation/SolutionTest.java
@@ -19,4 +19,9 @@ void letterCasePermutation2() {
         assertThat(
                 new Solution().letterCasePermutation("3z4"), equalTo(Arrays.asList("3z4", "3Z4")));
     }
+
+    @Test
+    void letterCasePermutation3() {
+        assertThat(new Solution().letterCasePermutation("C"), equalTo(Arrays.asList("C", "c")));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ spotless {`
`50`	`50`	`encoding 'UTF-8'`
`51`	`51`	`target fileTree(projectDir) {`
`52`	`52`	`include '/src//*.java'`
	`53`	`+ exclude '/build/'`
`53`	`54`	`}`
`54`	`55`	`importOrder '\\#', '', '*'`
`55`	`56`	`removeUnusedImports()`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ private int solve(int n, Map<Integer, Integer> dp) {`
`19`	`19`	`if (dp.containsKey(n)) {`
`20`	`20`	`return dp.get(n);`
`21`	`21`	`}`
`22`		`- int ans = 0;`
	`22`	`+ int ans;`
`23`	`23`	`if (n % 2 == 0) {`
`24`	`24`	`ans = 1 + solve(n >>> 1, dp);`
`25`	`25`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ private int helper(int[] boxes, int left, int right, int count) {`
`25`	`25`	`leftDash++;`
`26`	`26`	`countDash++;`
`27`	`27`	`}`
`28`		`- int ans = 0;`
	`28`	`+ int ans;`
`29`	`29`	`ans = helper(boxes, leftDash + 1, right, 0) + (countDash + 1) * (countDash + 1);`
`30`	`30`	`for (int i = leftDash + 1; i <= right; i++) {`
`31`	`31`	`if (boxes[i] == boxes[leftDash]) {`
Original file line number	Diff line number	Diff line change
`@@ -20,13 +20,13 @@ public void helper(String s, int curr, String temp) {`
`20`	`20`	`return;`
`21`	`21`	`}`
`22`	`22`	`if (Character.isDigit(s.charAt(curr))) {`
`23`		`- helper(s, curr + 1, temp + s.substring(curr, curr + 1));`
	`23`	`+ helper(s, curr + 1, temp + s.charAt(curr));`
`24`	`24`	`} else {`
`25`	`25`	`if (Character.isLowerCase(s.charAt(curr))) {`
`26`		`- helper(s, curr + 1, temp + s.substring(curr, curr + 1));`
	`26`	`+ helper(s, curr + 1, temp + s.charAt(curr));`
`27`	`27`	`helper(s, curr + 1, temp + (s.substring(curr, curr + 1)).toUpperCase());`
`28`	`28`	`} else {`
`29`		`- helper(s, curr + 1, temp + s.substring(curr, curr + 1));`
	`29`	`+ helper(s, curr + 1, temp + s.charAt(curr));`
`30`	`30`	`helper(s, curr + 1, temp + (s.substring(curr, curr + 1)).toLowerCase());`
`31`	`31`	`}`
`32`	`32`	`}`