Skip to content

Conversation

@super7ramp
Copy link
Contributor

This closes #225.

@super7ramp
Copy link
Contributor Author

ClojureScript CI tests fail:

FAIL in (test-defonce) (clojure/core_test/defonce.cljc:10:11)
defining var only once
expected: (nil? (defonce one 2))
  actual: (not (nil? 2))

ERROR in (test-defonce) (clojure/core_test/defonce.cljc:11:11)
defining var only once
expected: (nil? (defonce one (assert false "should not be evaluated")))
  actual: #object[Error Error: Assert failed: should not be evaluated
false]

FAIL in (test-defonce) (clojure/core_test/defonce.cljc:12:11)
defining var only once
expected: (= 1 one)
  actual: (not (= 1 2))

Can't reproduce, bb test-cljs is ok locally 🤔

@super7ramp
Copy link
Contributor Author

super7ramp commented Nov 29, 2025

Tried to update shadow-cljs (which pulled cljs 1.12.116), got more errors:

Testing clojure.core-test.max

FAIL in (test-max) (clojure/core_test/max.cljc:36:13)
expected: (= 1 (max ##NaN 1))
  actual: (not (= 1 ##NaN))

FAIL in (test-max) (clojure/core_test/max.cljc:39:13)
expected: (= ##Inf (max ##-Inf ##NaN ##Inf))
  actual: (not (= ##Inf ##NaN))

FAIL in (test-max) (clojure/core_test/max.cljc:42:13)
expected: (= "y" (max "x" "y"))
  actual: (not (= "y" "x"))

Testing clojure.core-test.merge

Testing clojure.core-test.min

FAIL in (test-min) (clojure/core_test/min.cljc:36:13)
expected: (= 1 (min ##NaN 1))
  actual: (not (= 1 ##NaN))

FAIL in (test-min) (clojure/core_test/min.cljc:39:13)
expected: (= ##Inf (min ##-Inf ##NaN ##Inf))
  actual: (not (= ##Inf ##NaN))

I get these new errors locally as well (I guess it's #805), on the contrary to defonce ones, which I still don't reproduce 🤔

@super7ramp
Copy link
Contributor Author

Might be related to thheller/shadow-cljs#1185.

@super7ramp super7ramp marked this pull request as ready for review December 1, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clojure.core/defonce

1 participant