Skip to content

Update babashka and dissoc test #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2025
Merged

Update babashka and dissoc test #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bb.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{:min-bb-version "0.4.0"
{:min-bb-version "1.12.210"
:paths ["bb"]
:tasks
{test-jvm {:doc "Runs JVM tests"
Expand Down
11 changes: 3 additions & 8 deletions test/clojure/core_test/dissoc.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,11 @@

(testing "records"
(let [r (TestDissocRecord. 1 2 nil)]
(are [expected keys] #?(; bb preserves the record type even if a basis fields is dissociated
; https://github.com/babashka/babashka/issues/1886
:bb (= expected (into {} (apply dissoc r keys)))
; other implementations return a map
:default (= expected (apply dissoc r keys)))
(are [expected keys] (= expected (apply dissoc r keys))
{:b 2 :c nil} [:a]
{:b 2 :c nil} [:a :d]
{} [:a :b :c])
; all implementations preserve the record type if no basis field is dissociated
(is (= r (dissoc r :d)))))
{} [:a :b :c]
r [:d])))

(testing "bad shape"
(are [m keys] (thrown? #?(:cljs js/Error :default Exception) (apply dissoc m keys))
Expand Down