-
Notifications
You must be signed in to change notification settings - Fork 99
Open
Labels
questionFurther information is requestedFurther information is requested
Description
laravel-timezone/src/Timezone.php
Line 51 in 20ea12b
| private function formatTimezone(Carbon $date) : string |
I'm wondering, if we can use protected instead of private function then people can easily extends the Timezone and customize to their need.
Also, Can we extract the obtaining of the time zone in another class which will be responsible for assigning the time zone to the user (the user could be passed in the constructor and if not then we will use the Auth::user() )?
This will allow us to assign the time zone to the user without necessarily listening to the authentication event.
| $ip = $this->getFromLookup(); |
Metadata
Metadata
Assignees
Labels
questionFurther information is requestedFurther information is requested