De-lint shell scripts with shellcheck

 Safer and cleaner shell scripts courtesy of shellcheck

Author: zbeekman

build.sh

@@ -59,13 +59,13 @@
 #
 #  REQUIRES
 #    FoBiS.py : https://github.com/szaghi/FoBiS      [version 1.2.5 or later required]
-#    FORD     : https://github.com/cmacmackin/ford   [version 3.0.2 is the one tested]
+#    FORD     : https://github.com/cmacmackin/ford   [version 4.0.0 or later]
 #
 #  AUTHOR
 #    Jacob Williams : 12/27/2014
 #
 
-set -e
+set -o errexit
 
 FORDMD='json-fortran.md'        # FORD options file for building documentation
 DOCDIR='./doc/'                 # build directory for documentation
@@ -97,7 +97,7 @@ FCOMPILER='gnu' #Set default compiler to gfortran
 #       e.g., "./build.sh --compiler intel --coverage no --compiler gnu --coverage" will
 #       perform the build with the GFORTRAN compiler, and coverage analysis
 
-script_name="$(basename $0)"
+script_name="$(basename "$0")"
 
 # usage message
 print_usage () {
@@ -213,7 +213,7 @@ while [ "$#" -ge "1" ]; do # Get command line arguments while there are more lef
             shift
             ;;
         no|No|NO)
-            JF_SKIP_DOCSS="no"
+            JF_SKIP_DOCS="no"
             shift
             ;;
         *)
@@ -226,7 +226,7 @@ while [ "$#" -ge "1" ]; do # Get command line arguments while there are more lef
         exit 0
         ;;
     --clean)
-        rm -r src{,/tests}/*.o $DOCDIR* $LIBDIR* $BINDIR* *.gcov*
+        rm -r -- src{,/tests}/*.o $DOCDIR* $LIBDIR* $BINDIR* *.gcov*
         ;;
     *)
         echo "Unknown flag, \"$1\", passed to ${script_name}!" 2>&1
@@ -254,12 +254,12 @@ fi
 
 if [[ $FCOMPILER == custom ]]; then
     echo "Trying to compile with custom compiler, $FC"
-    CUSTOM="-fc $FC"
+    CUSTOM=("-fc" "$FC")
 fi
 
 if [[ $TRY_UNICODE == [yY]* ]]; then
     echo "Trying to compile library with Unicode/UCS4 support"
-    FoBiS.py build -ch -compiler ${FCOMPILER} ${CUSTOM} -cflags "${FCOMPILERFLAGS}" -dbld "${BINDIR}" -s "${INTROSPECDIR}" -dmod ./ -dobj ./ -t ${UCS4TESTCODE} -o ${UCS4TESTCODE%.f90} -colors
+    FoBiS.py build -ch -compiler "${FCOMPILER}" "${CUSTOM[@]}" -cflags "${FCOMPILERFLAGS}" -dbld "${BINDIR}" -s "${INTROSPECDIR}" -dmod ./ -dobj ./ -t "${UCS4TESTCODE}" -o "${UCS4TESTCODE%.f90}" -colors
     if "${BINDIR}/${UCS4TESTCODE%.f90}"; then
     DEFINES="-DUSE_UCS4 -Wunused-function"
     fi
@@ -269,7 +269,7 @@ fi
 echo ""
 echo "Building library..."
 
-FoBiS.py build -ch -compiler ${FCOMPILER} ${CUSTOM} -cflags "${FCOMPILERFLAGS} ${DEFINES}" ${COVERAGE} ${PROFILING} -dbld ${LIBDIR} -s ${SRCDIR} -dmod ./ -dobj ./ -t ${MODCODE} -o ${LIBOUT} -mklib static -colors
+FoBiS.py build -ch -compiler ${FCOMPILER} "${CUSTOM[@]}" -cflags "${FCOMPILERFLAGS} ${DEFINES}" ${COVERAGE} ${PROFILING} -dbld ${LIBDIR} -s ${SRCDIR} -dmod ./ -dobj ./ -t ${MODCODE} -o ${LIBOUT} -mklib static -colors
 
 #build the unit tests (uses the above library):
 if [[ $JF_SKIP_TESTS != [yY]* ]]; then
@@ -282,7 +282,7 @@ if [[ $JF_SKIP_TESTS != [yY]* ]]; then
     for TEST in "${TESTDIR%/}"/jf_test_*.[fF]90; do
     THIS_TEST=${TEST##*/}
     echo "Build ${THIS_TEST%.[fF]90}"
-    FoBiS.py build -ch -compiler ${FCOMPILER} ${CUSTOM} -cflags "${FCOMPILERFLAGS} ${DEFINES}" ${COVERAGE} ${PROFILING} -dbld ${BINDIR} -s ${TESTDIR} -i ${LIBDIR} -libs ${LIBDIR}/${LIBOUT} -dmod ./ -dobj ./ -t ${THIS_TEST} -o ${THIS_TEST%.[fF]90} -colors
+    FoBiS.py build -ch -compiler ${FCOMPILER} "${CUSTOM[@]}" -cflags "${FCOMPILERFLAGS} ${DEFINES}" ${COVERAGE} ${PROFILING} -dbld "${BINDIR}" -s "${TESTDIR}" -i "${LIBDIR}" -libs "${LIBDIR}/${LIBOUT}" -dmod ./ -dobj ./ -t "${THIS_TEST}" -o "${THIS_TEST%.[fF]90}" -colors
     done
 else
     echo "Skip building the unit tests since \$JF_SKIP_TESTS has been set to 'true'."
@@ -292,17 +292,17 @@ fi
 echo ""
 if [[ $JF_SKIP_TESTS != [yY]* ]] ; then
     echo "Running tests..."
-    cd "$BINDIR"
     OLD_IGNORES="$GLOBIGNORE"
+    # run next commands in subshell to avoid `cd -`
+    (cd "$BINDIR"
     GLOBIGNORE='*.*'
     #
     for TEST in jf_test_*; do
         # It would be nice to run json output printed to stdout through jsonlint, however,
         # some tests output more than one json structure and these need to be split
         echo "Running ${TEST}"
-        ./${TEST}
-    done
-    cd -
+        "./${TEST}"
+    done)
     GLOBIGNORE="$OLD_IGNORES"
     if [[ $CODE_COVERAGE = [yY]* ]] ; then
         for SRCFILE in json_string_utilities.F90 json_value_module.F90 json_file_module.F90 ; do

deploy.sh

@@ -3,14 +3,16 @@
 # If running under travis-ci this will automatically deploy updates to the master branch's
 # documentation on build events for the master branch, and will add/update documentation for
 # any new/updated tags that are pushed.
+set -o errexit
+set -o verbose
 if [ "$TRAVIS" ]; then #running under travis
     if $TRAVIS_SECURE_ENV_VARS ; then
 	# only try to update master's development documentation
 	if [ "$TRAVIS_BRANCH" = "master" ] && \
 	       [ "$TRAVIS_PULL_REQUEST" = "false" ] && \
-	       [ "$(ls -A $TRAVIS_BUILD_DIR/doc)" ] ; then #not empty
-            git clone --branch=gh-pages https://${GH_TOKEN}@github.com/$TRAVIS_REPO_SLUG gh-pages
-            cd gh-pages
+	       [ "$(ls -A "$TRAVIS_BUILD_DIR/doc")" ] ; then #not empty
+            git clone --branch=gh-pages "https://${GH_TOKEN}@github.com/$TRAVIS_REPO_SLUG" gh-pages
+            cd gh-pages || exit 1
 	    rm -r css favicon.png fonts index.html interface js lists media module page proc \
 	       program search.html sourcefile src tipuesearch type
 	    cp -r "$TRAVIS_BUILD_DIR"/doc/* .
@@ -19,13 +21,13 @@ if [ "$TRAVIS" ]; then #running under travis
             git push origin gh-pages
 	fi
 	# If publishing a new/updated tag, deploy it's documentation
-	if [ "$TRAVIS_TAG" ] && [ "$(ls -A $TRAVIS_BUILD_DIR/doc)" ] ; then #not empty
-	    cd "$TRAVIS_BUILD_DIR"
-	    git clone --branch=gh-pages https://${GH_TOKEN}@github.com/$TRAVIS_REPO_SLUG gh-pages
+	if [ "$TRAVIS_TAG" ] && [ "$(ls -A "$TRAVIS_BUILD_DIR/doc")" ] ; then #not empty
+	    cd "$TRAVIS_BUILD_DIR" || exit 1
+	    git clone --branch=gh-pages "https://${GH_TOKEN}@github.com/$TRAVIS_REPO_SLUG" gh-pages
 	    sed "1 s/^/version: ${TRAVIS_TAG}\n/" json-fortran.md > json-fortran.tagged.md
 	    # rebuild FORD documentation without pages, with version info, wiping out any existing tag folder
 	    ford -o "gh-pages/$TRAVIS_TAG" json-fortran.tagged.md
-	    cd gh-pages
+	    cd gh-pages || exit 1
 	    git add -A # add all new files in $TRAVIS_TAG/
 	    git commit -m "Tag/release documentation updated by travis job $TRAVIS_JOB_NUMBER for tag $TRAVIS_TAG $TRAVIS_COMMIT"
 	    git push origin gh-pages