Fixed a few more non-default integer kind issues that might trigger errors depending on the compiler flags. See #365

Author: jacobwilliams

src/json_value_module.F90

@@ -2719,7 +2719,7 @@ recursive subroutine check_if_valid(p,require_parent)
         logical,intent(in) :: require_parent !! the first one may be a root (so no parent),
                                              !! but all descendants must have a parent.
 
-        integer :: i !! counter
+        integer(IK) :: i !! counter
         type(json_value),pointer :: element
         type(json_value),pointer :: previous
 
@@ -2833,7 +2833,7 @@ recursive subroutine check_if_valid(p,require_parent)
 
                 previous => null()
                 element => p%children
-                do i = 1, p%n_children
+                do i = 1_IK, p%n_children
                     if (.not. associated(element%parent,p)) then
                         error_msg = 'child''s parent pointer not properly associated'
                         is_valid = .false.

src/tests/jf_test_12.F90

@@ -26,7 +26,7 @@ subroutine test_12(error_cnt)
 
     integer,intent(out) :: error_cnt !! report number of errors to caller
 
-    integer,parameter :: imx = 5, jmx = 3, kmx = 4 !! dimensions for raw work array of primitive type
+    integer(IK),parameter :: imx = 5, jmx = 3, kmx = 4 !! dimensions for raw work array of primitive type
 
     type(json_core)                        :: json              !! factory for manipulating `json_value` pointers
     integer(IK),dimension(3)               :: shape             !! shape of work array
@@ -38,7 +38,7 @@ subroutine test_12(error_cnt)
     real(wp)                               :: array_element
     real(wp), dimension(:), allocatable    :: fetched_array
     character(kind=CK,len=:), allocatable  :: description
-    integer                                :: i,j,k             !! loop indices
+    integer(IK)                            :: i,j,k             !! loop indices
     integer(IK)                            :: array_length, lun
     logical(LK)                            :: existed
     logical(LK), dimension(:), allocatable :: SOS
@@ -54,8 +54,8 @@ subroutine test_12(error_cnt)
     write(error_unit,'(A)') ''
 
     ! populate the raw array
-    forall (i=1:imx,j=1:jmx,k=1:kmx) ! could use size(... , dim=...) instead of constants
-       raw_array(i,j,k) = i + (j-1)*imx + (k-1)*imx*jmx
+    forall (i=1_IK:imx,j=1_IK:jmx,k=1_IK:kmx) ! could use size(... , dim=...) instead of constants
+       raw_array(i,j,k) = i + (j-1_IK)*imx + (k-1_IK)*imx*jmx
     end forall
 
     call json%create_object(root,dir//file)
@@ -218,13 +218,13 @@ subroutine get_3D_from_array(json, element, i, count)
         integer(IK),intent(in)              :: i        !! index
         integer(IK),intent(in)              :: count    !! size of array
 
-        integer :: useless !! assign count to this to silence warnings
+        integer(IK) :: useless !! assign count to this to silence warnings
 
         ! let's pretend we're c programmers!
         call json%get( element, raw_array( &
-             mod(i-1,imx) + 1, &            ! i index
-             mod((i-1)/imx,jmx) + 1, &      ! j index
-             mod((i-1)/imx/jmx,kmx) + 1 ) ) ! k inded
+             mod(i-1_IK,imx) + 1_IK, &            ! i index
+             mod((i-1_IK)/imx,jmx) + 1_IK, &      ! j index
+             mod((i-1_IK)/imx/jmx,kmx) + 1_IK ) ) ! k inded
 
         useless = count
 

src/tests/jf_test_15.F90

@@ -85,7 +85,7 @@ subroutine test_15(error_cnt)
                             compact_reals=.true.,&
                             print_signs=.false.,&
                             real_format='E',&
-                            spaces_per_tab=4,&
+                            spaces_per_tab=4_IK,&
                             strict_type_checking=.true.,&
                             trailing_spaces_significant=.false.,&
                             case_sensitive_keys=.true.)

src/tests/jf_test_32.F90

@@ -23,7 +23,6 @@ subroutine test_32(error_cnt)
     integer,intent(out) :: error_cnt
     integer :: i !! counter
     integer :: j !! counter
-    integer :: k !! counter
     type(json_core) :: json
     type(json_value),pointer :: p, p_var
     character(kind=CK,len=:),allocatable :: path_ck