Fix stack overflow in circular assignment declaration (microsoft#34543)

* Fix stack overflow in circular assignment declaration

It also needs to have multiple assignments so that it has a ValueModule
flag.

Fixes microsoft#33006

* remove errant comment

* Remove other possible circularity

* Restore fallback with additional condition

Author: sandersn

src/compiler/checker.ts

@@ -7270,7 +7270,7 @@ namespace ts {
             // Handle variable, parameter or property
             if (!pushTypeResolution(symbol, TypeSystemPropertyName.Type)) {
                 // Symbol is property of some kind that is merged with something - should use `getTypeOfFuncClassEnumModule` and not `getTypeOfVariableOrParameterOrProperty`
-                if (symbol.flags & SymbolFlags.ValueModule) {
+                if (symbol.flags & SymbolFlags.ValueModule && !(symbol.flags & SymbolFlags.Assignment)) {
                     return getTypeOfFuncClassEnumModule(symbol);
                 }
                 return reportCircularityError(symbol);
@@ -7340,7 +7340,7 @@ namespace ts {
 
             if (!popTypeResolution()) {
                 // Symbol is property of some kind that is merged with something - should use `getTypeOfFuncClassEnumModule` and not `getTypeOfVariableOrParameterOrProperty`
-                if (symbol.flags & SymbolFlags.ValueModule) {
+                if (symbol.flags & SymbolFlags.ValueModule && !(symbol.flags & SymbolFlags.Assignment)) {
                     return getTypeOfFuncClassEnumModule(symbol);
                 }
                 return reportCircularityError(symbol);

tests/baselines/reference/circularMultipleAssignmentDeclaration.symbols

@@ -0,0 +1,15 @@
+=== tests/cases/conformance/salsa/circularMultipleAssignmentDeclaration.js ===
+ns.next = ns.next || { shared: {} };
+>ns.next : Symbol(ns.next, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 1, 3))
+>ns : Symbol(ns, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 0, 36))
+>next : Symbol(ns.next, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 1, 3))
+>ns.next : Symbol(ns.next, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 1, 3))
+>ns : Symbol(ns, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 0, 36))
+>next : Symbol(ns.next, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 1, 3))
+>shared : Symbol(shared, Decl(circularMultipleAssignmentDeclaration.js, 0, 22))
+
+ns.next.shared.mymethod = {};
+>ns.next : Symbol(ns.next, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 1, 3))
+>ns : Symbol(ns, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 0, 36))
+>next : Symbol(ns.next, Decl(circularMultipleAssignmentDeclaration.js, 0, 0), Decl(circularMultipleAssignmentDeclaration.js, 1, 3))
+

tests/baselines/reference/circularMultipleAssignmentDeclaration.types

@@ -0,0 +1,25 @@
+=== tests/cases/conformance/salsa/circularMultipleAssignmentDeclaration.js ===
+ns.next = ns.next || { shared: {} };
+>ns.next = ns.next || { shared: {} } : any
+>ns.next : any
+>ns : typeof ns
+>next : any
+>ns.next || { shared: {} } : any
+>ns.next : any
+>ns : typeof ns
+>next : any
+>{ shared: {} } : { shared: {}; }
+>shared : {}
+>{} : {}
+
+ns.next.shared.mymethod = {};
+>ns.next.shared.mymethod = {} : {}
+>ns.next.shared.mymethod : any
+>ns.next.shared : any
+>ns.next : any
+>ns : typeof ns
+>next : any
+>shared : any
+>mymethod : any
+>{} : {}
+

tests/cases/conformance/salsa/circularMultipleAssignmentDeclaration.ts

@@ -0,0 +1,6 @@
+// @filename:circularMultipleAssignmentDeclaration.js
+// @allowJs: true
+// @checkJs: true
+// @noEmit: true
+ns.next = ns.next || { shared: {} };
+ns.next.shared.mymethod = {};