Skip to content

Commit c7f99cc

Browse files
Merge branch 'main' into feat-EvolutedToBetaVersion
2 parents 18106dd + 6d86b9b commit c7f99cc

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ client = ClientBuilder(endpoint="https://api.example.com"
6868
,connection_timeout=10
6969
,headers=headers
7070
,retries=5
71-
,delay=10)
71+
,initial_delay=10)
7272

7373

7474
### timeout, retry_strategy and headers are opcionals parameters

src/api_to_dataframe/controller/client_builder.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
from api_to_dataframe.models.retainer import RetryStrategies
2-
from api_to_dataframe.models.retainer import Strategies
1+
from api_to_dataframe.models.retainer import RetryStrategies, Strategies
32
from api_to_dataframe.models.get_data import GetData
43

54

@@ -9,7 +8,7 @@ def __init__(self,
98
headers: dict = None,
109
retry_strategy: Strategies = Strategies.NoRetryStrategy,
1110
retries: int = 3,
12-
delay: int = 1,
11+
initial_delay: int = 1,
1312
connection_timeout: int = 1):
1413

1514
"""
@@ -36,7 +35,7 @@ def __init__(self,
3635
raise ValueError("::: endpoint param is mandatory :::")
3736
if not isinstance(retries, int) or retries < 0:
3837
raise ValueError("retries must be a non-negative integer")
39-
if not isinstance(delay, int) or delay < 0:
38+
if not isinstance(initial_delay, int) or initial_delay < 0:
4039
raise ValueError("delay must be a non-negative integer")
4140
if not isinstance(connection_timeout, int) or connection_timeout < 0:
4241
raise ValueError("connection_timeout must be a non-negative integer")
@@ -46,7 +45,7 @@ def __init__(self,
4645
self.connection_timeout = connection_timeout
4746
self.headers = headers
4847
self.retries = retries
49-
self.delay = delay
48+
self.delay = initial_delay
5049

5150
@RetryStrategies
5251
def get_api_data(self):

tests/test_controller_client_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def test_constructor_raises():
3030
with pytest.raises(ValueError):
3131
new_client = ClientBuilder(
3232
endpoint="https://economia.awesomeapi.com.br/last/USD-BRL",
33-
delay=-1
33+
initial_delay=-1
3434
)
3535

3636
with pytest.raises(ValueError):
@@ -48,7 +48,7 @@ def test_constructor_raises():
4848
with pytest.raises(ValueError):
4949
new_client = ClientBuilder(
5050
endpoint="https://economia.awesomeapi.com.br/last/USD-BRL",
51-
delay=""
51+
initial_delay=""
5252
)
5353

5454
with pytest.raises(ValueError):

tests/test_models_retainer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def test_linear_strategy():
1111
endpoint=endpoint,
1212
retry_strategy=RetryStrategies.LinearRetryStrategy,
1313
retries=max_retries,
14-
delay=1,
14+
initial_delay=1,
1515
connection_timeout=1
1616
)
1717

@@ -47,7 +47,7 @@ def test_exponential_strategy():
4747
endpoint=endpoint,
4848
retry_strategy=RetryStrategies.ExponentialRetryStrategy,
4949
retries=max_retries,
50-
delay=1,
50+
initial_delay=1,
5151
connection_timeout=1
5252
)
5353

0 commit comments

Comments
 (0)