Close cpu profile file at exit

itzg · itzg · commit b6edd937eaed · 2019-05-04T14:22:51.000-05:00
diff --git a/cmd/mc-router/main.go b/cmd/mc-router/main.go
@@ -48,6 +48,7 @@ func main() {
 		if err != nil {
 			logrus.WithError(err).Fatal("trying to create cpu profile file")
 		}
+		defer cpuProfileFile.Close()
 
 		logrus.WithField("file", *cpuProfileFile).Info("Starting cpu profiling")
 		err = pprof.StartCPUProfile(cpuProfileFile)

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ func main() {`
`48`	`48`	`if err != nil {`
`49`	`49`	`logrus.WithError(err).Fatal("trying to create cpu profile file")`
`50`	`50`	`}`
	`51`	`+ defer cpuProfileFile.Close()`
`51`	`52`
`52`	`53`	`logrus.WithField("file", *cpuProfileFile).Info("Starting cpu profiling")`
`53`	`54`	`err = pprof.StartCPUProfile(cpuProfileFile)`