Skip to content

Provide option for regex with CF_FILENAME_MATCHER #3686

@itzg

Description

@itzg

From Discord

It seems the CF_FILENAME_MATCHER it's doing a .contains(...) (I verified in the code), but how could I restrict that a little more? With ATM10 TTS, they had version 1.5 then went to 1.5.1 and quickly went to 1.5.1b (as a hotfix). I had as a matcher: -1.5 since their filename was ATM10 To the Sky-1.5.zip and had been playing on 1.5 for a while now. But my server restarted (due to a crash) and it upgraded to 1.5.1b. Which since it's using contains, I can see why. Granted, they're using poor versioning, but it would be nice be a little more specific with the specification. Maybe a regex option or something?

Side note: while it downloaded and is running 1.5.1b (I checked the logs), the %MODPACK_VERSION% variable and value in .install-curseforge.env report it as 1.5.1 instead.

Proposal: when the value is a slash-surrounded string then it will be processed as a regex such as

/.*1\.5$/

Metadata

Metadata

Assignees

No one assigned

    Projects

    Status

    To do

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions