Skip to content

VERSION_FROM_MODRINTH_PROJECTS should consider platform #3681

@github-dotEXE

Description

@github-dotEXE

Describe the problem

I currently have this setup

    image: itzg/minecraft-server
    environment:
      TYPE: PAPER
      VERSION: 1.21.9
      MODRINTH_ALLOWED_VERSION_TYPE: beta
      VERSION_FROM_MODRINTH_PROJECTS: true
      MODRINTH_PROJECTS: |
        simple-voice-chat
        armor-poser-plugin
        worldedit
      # ...
    # ...

here, VERSION_FROM_MODRINTH_PROJECTS resolves to 1.21.8, as expected

[init] Resolved Minecraft version 1.21.8 from Modrinth projects

i also have another container with this config (only difference is that there is no worldedit plugin):

    image: itzg/minecraft-server
    environment:
      TYPE: PAPER
      VERSION: 1.21.9
      MODRINTH_ALLOWED_VERSION_TYPE: beta
      VERSION_FROM_MODRINTH_PROJECTS: true
      MODRINTH_PROJECTS: |
        simple-voice-chat
        armor-poser-plugin
      # ...
    # ...

this configuration resolves to 1.21.9 and then it errors.

[init] Resolved Minecraft version 1.21.9 from Modrinth projects
[init] Resolving type given PAPER
[mc-image-helper] 11:15:44.425 ERROR : Invalid parameter provided for 'modrinth' command: No files are available for the project 'Simple Voice Chat' for loader paper and Minecraft version 1.21.9

The error is because Simple Voice Chat currently doesnt actually currently have a version for 1.21.9 Paper. It only has a version for 1.21.9 Fabric and NeoForge.

Here are the supported versions for the other plugins mentioned above:

  • worldedit: < 1.21.8
  • simple-voice-chat: < 1.21.8 for everything but an alpha release for NeoForge and a beta release for Fabric
  • armor-poser-plugin: 1.21.9

What i get from this is that VERSION_FROM_MODRINTH_PROJECTS only checks if there is any release for the version and not that the selected platform has a release for that version

Container definition

see above

Container logs

see above

Metadata

Metadata

Assignees

No one assigned

    Projects

    Status

    To do

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions