Add tests demonstrating background bug for inner inline elements

Snipx · Snipx · commit e624c4690401 · 2018-08-09T11:13:18.000+03:00
DEVSIX-2118
diff --git a/src/main/java/com/itextpdf/html2pdf/css/apply/impl/SpanTagCssApplier.java b/src/main/java/com/itextpdf/html2pdf/css/apply/impl/SpanTagCssApplier.java
@@ -117,7 +117,7 @@ public void apply(ProcessorContext context, IStylesContainer stylesContainer, IT
      */
     protected void applyChildElementStyles(IPropertyContainer element, Map<String, String> css, ProcessorContext context, IStylesContainer stylesContainer) {
         FontStyleApplierUtil.applyFontStyles(css, context, stylesContainer, element);
-        //TODO: Background-applying currently doesn't work in html way for spans inside other spans.
+        //TODO DEVSIX-2118: Background-applying currently doesn't work in html way for spans inside other spans.
         BackgroundApplierUtil.applyBackground(css, context, element);
         //TODO: Border-applying currently doesn't work in html way for spans inside other spans.
         BorderStyleApplierUtil.applyBorders(css, context, element);
diff --git a/src/test/java/com/itextpdf/html2pdf/element/LabelTest.java b/src/test/java/com/itextpdf/html2pdf/element/LabelTest.java
@@ -46,15 +46,15 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
-
-import java.io.File;
-import java.io.IOException;
-
 import org.junit.Assert;
 import org.junit.BeforeClass;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
+import java.io.File;
+import java.io.IOException;
+
 @Category(IntegrationTest.class)
 public class LabelTest extends ExtendedITextTest {
 
@@ -84,4 +84,11 @@ public void labelDisplayBlock02Test() throws IOException, InterruptedException {
         Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "labelDisplayBlockTest02.pdf", sourceFolder + "cmp_labelDisplayBlockTest02.pdf", destinationFolder, "diffBlock02_"));
     }
 
+    @Test
+    @Ignore("DEVSIX-2118")
+    public void labelBackground01Test() throws IOException, InterruptedException {
+        HtmlConverter.convertToPdf(new File(sourceFolder + "labelBackground01Test.html"), new File(destinationFolder + "labelBackground01Test.pdf"));
+        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "labelBackground01Test.pdf", sourceFolder + "cmp_labelBackground01Test.pdf", destinationFolder, "diffBackground01_"));
+    }
+
 }
diff --git a/src/test/java/com/itextpdf/html2pdf/element/SpanTest.java b/src/test/java/com/itextpdf/html2pdf/element/SpanTest.java
@@ -46,15 +46,15 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
-
-import java.io.File;
-import java.io.IOException;
-
 import org.junit.Assert;
 import org.junit.BeforeClass;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
+import java.io.File;
+import java.io.IOException;
+
 @Category(IntegrationTest.class)
 public class SpanTest extends ExtendedITextTest {
 
@@ -133,4 +133,11 @@ public void spanTest11() throws IOException, InterruptedException {
         Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "spanTest11.pdf", sourceFolder + "cmp_spanTest11.pdf", destinationFolder, "diff11_"));
     }
 
+    @Test
+    @Ignore("DEVSIX-2118")
+    public void spanTest12() throws IOException, InterruptedException {
+        HtmlConverter.convertToPdf(new File(sourceFolder + "spanTest12.html"), new File(destinationFolder + "spanTest12.pdf"));
+        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "spanTest12.pdf", sourceFolder + "cmp_spanTest12.pdf", destinationFolder, "diff12_"));
+    }
+
 }
diff --git a/src/test/resources/com/itextpdf/html2pdf/element/LabelTest/labelBackground01Test.html b/src/test/resources/com/itextpdf/html2pdf/element/LabelTest/labelBackground01Test.html
@@ -0,0 +1,8 @@
+<html>
+
+<body>
+<label style="background-color:red">
+<span>545545454545454</span>
+</label>
+</body>
+</html>
diff --git a/src/test/resources/com/itextpdf/html2pdf/element/SpanTest/spanTest12.html b/src/test/resources/com/itextpdf/html2pdf/element/SpanTest/spanTest12.html
@@ -0,0 +1,8 @@
+<html>
+
+<body>
+<span style="background-color:red">
+<span>545545454545454</span>
+</span>
+</body>
+</html>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,8 @@ @@
 +<html>
++
 +<body>
 +<span style="background-color:red">
 +<span>545545454545454</span>
 +</span>
 +</body>
 +</html>