Process <input type="number"> correctly

Author: Snipx

src/main/java/com/itextpdf/html2pdf/attach/impl/tags/InputTagWorker.java

@@ -81,10 +81,10 @@ public InputTagWorker(IElementNode element, ProcessorContext context) {
         String name = context.getFormFieldNameResolver().resolveFormName(element.getAttribute(AttributeConstants.NAME));
         // Default input type is text
         if (inputType == null || AttributeConstants.TEXT.equals(inputType) || AttributeConstants.EMAIL.equals(inputType)
-                || AttributeConstants.PASSWORD.equals(inputType)) {
+                || AttributeConstants.PASSWORD.equals(inputType) || AttributeConstants.NUMBER.equals(inputType)) {
             Integer size = CssUtils.parseInteger(element.getAttribute(AttributeConstants.SIZE));
             formElement = new InputField(name);
-            formElement.setProperty(Html2PdfProperty.FORM_FIELD_VALUE, value);
+            formElement.setProperty(Html2PdfProperty.FORM_FIELD_VALUE, preprocessInputValue(value, inputType));
             formElement.setProperty(Html2PdfProperty.FORM_FIELD_SIZE, size);
             if (AttributeConstants.PASSWORD.equals(inputType)) {
                 formElement.setProperty(Html2PdfProperty.FORM_FIELD_PASSWORD_FLAG, true);
@@ -141,4 +141,12 @@ public boolean processTagChild(ITagWorker childTagWorker, ProcessorContext conte
     public IPropertyContainer getElementResult() {
         return formElement;
     }
+
+    private static String preprocessInputValue(String value, String inputType) {
+        if (AttributeConstants.NUMBER.equals(inputType) && value != null && !value.matches("[0-9.]*")) {
+            value = "";
+        }
+        return value;
+    }
+
 }

src/main/java/com/itextpdf/html2pdf/html/AttributeConstants.java

@@ -124,6 +124,9 @@ private AttributeConstants() {
     /** The Constant NOSHADE. */
     public static final String NOSHADE = "noshade";
 
+    /** The Constant NUMBER. */
+    public static final String NUMBER = "number";
+
     /** The Constant REL. */
     public static final String REL = "rel";
 

src/test/java/com/itextpdf/html2pdf/element/InputTest.java

@@ -46,15 +46,14 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
-
-import java.io.File;
-import java.io.IOException;
-
 import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
+import java.io.File;
+import java.io.IOException;
+
 @Category(IntegrationTest.class)
 public class InputTest extends ExtendedITextTest {
 
@@ -68,20 +67,28 @@ public static void beforeClass() {
 
     @Test
     public void input01Test() throws IOException, InterruptedException {
-        HtmlConverter.convertToPdf(new File(sourceFolder + "inputTest01.html"), new File(destinationFolder + "inputTest01.pdf"));
-        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "inputTest01.pdf", sourceFolder + "cmp_inputTest01.pdf", destinationFolder, "diff01_"));
+        runTest("inputTest01");
     }
 
     @Test
     public void input02Test() throws IOException, InterruptedException {
-        HtmlConverter.convertToPdf(new File(sourceFolder + "inputTest02.html"), new File(destinationFolder + "inputTest02.pdf"));
-        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "inputTest02.pdf", sourceFolder + "cmp_inputTest02.pdf", destinationFolder, "diff02_"));
+        runTest("inputTest02");
     }
 
     @Test
     public void input03Test() throws IOException, InterruptedException {
-        HtmlConverter.convertToPdf(new File(sourceFolder + "inputTest03.html"), new File(destinationFolder + "inputTest03.pdf"));
-        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + "inputTest03.pdf", sourceFolder + "cmp_inputTest03.pdf", destinationFolder, "diff03_"));
+        runTest("inputTest03");
     }
 
+    @Test
+    public void input04Test() throws IOException, InterruptedException {
+        runTest("inputTest04");
+    }
+
+    private void runTest(String testName) throws IOException, InterruptedException {
+        HtmlConverter.convertToPdf(new File(sourceFolder + testName + ".html"), new File(destinationFolder + testName + ".pdf"));
+        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + testName + ".pdf", sourceFolder + "cmp_" + testName + ".pdf", destinationFolder, "diff_" + testName));
+    }
+
+
 }

src/test/resources/com/itextpdf/html2pdf/element/InputTest/cmp_inputTest04.pdf

@@ -0,0 +1,16 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+input {
+color: red;
+}
+</style>
+</head>
+<body>
+
+Quantity: <input type="number" name="test1" value="12345.67890"><br>
+Invalid quantity: <input type="number" name="test2" value="Mouse"><br>
+
+</body>
+</html>