Skip to content

Commit b929b7b

Browse files
code review fixes
DEVSIX-1267
1 parent 960e86e commit b929b7b

File tree

2 files changed

+0
-150
lines changed

2 files changed

+0
-150
lines changed

src/test/java/com/itextpdf/html2pdf/css/FloatTest.java

Lines changed: 0 additions & 149 deletions
Original file line numberDiff line numberDiff line change
@@ -424,164 +424,18 @@ public void floatAndTables10Test() throws IOException, InterruptedException {
424424
runTest("floatAndTables10Test", "diffTables10_");
425425
}
426426

427-
@Test
428-
public void floatImage01Test() throws IOException, InterruptedException {
429-
runTest("floatImage01Test", "diffImages01_");
430-
}
431-
432-
@Test
433-
public void floatImage02Test() throws IOException, InterruptedException {
434-
runTest("floatImage02Test", "diffImages02_");
435-
}
436-
437-
@Test
438-
public void floatImage03Test() throws IOException, InterruptedException {
439-
runTest("floatImage03Test", "diffImages03_");
440-
}
441-
442-
@Test@Ignore
443-
public void floatImage04Test() throws IOException, InterruptedException {
444-
// TODO word splitting logic working not entirely correctly
445-
runTest("floatImage04Test", "diffImages04_");
446-
}
447-
448-
@Test
449-
public void floatImage05Test() throws IOException, InterruptedException {
450-
runTest("floatImage05Test", "diffImages05_");
451-
}
452-
453-
@Test
454-
public void floatImage06Test() throws IOException, InterruptedException {
455-
runTest("floatImage06Test", "diffImages06_");
456-
}
457-
458-
@Test
459-
public void floatImage07Test() throws IOException, InterruptedException {
460-
// TODO word splitting logic working not entirely correctly
461-
runTest("floatImage07Test", "diffImages07_");
462-
}
463-
464-
@Test
465-
public void floatImage08Test() throws IOException, InterruptedException {
466-
runTest("floatImage08Test", "diffImages08_");
467-
}
468-
469-
@Test
470-
public void floatImage09Test() throws IOException, InterruptedException {
471-
runTest("floatImage09Test", "diffImages09_");
472-
}
473-
474-
@Test
475-
public void floatImage10Test() throws IOException, InterruptedException {
476-
// TODO we don't apply leading on floats, this somewhat noticeable when huge line-height in html is used
477-
runTest("floatImage10Test", "diffImages10_");
478-
}
479-
480-
@Test
481-
public void floatImage11Test() throws IOException, InterruptedException {
482-
runTest("floatImage11Test", "diffImages11_");
483-
}
484-
485-
@Test@Ignore
486-
public void floatImage12Test() throws IOException, InterruptedException {
487-
// TODO we don't apply leading on floats, this somewhat noticeable when huge line-height in html is used
488-
runTest("floatImage12Test", "diffImages12_");
489-
}
490-
491-
@Test
492-
public void floatImage13Test() throws IOException, InterruptedException {
493-
// TODO we don't apply leading on floats, this somewhat noticeable when huge line-height in html is used
494-
runTest("floatImage13Test", "diffImages13_");
495-
}
496-
497427
@Test
498428
@Ignore("DEVSIX-1316")
499429
public void floatImage14Test() throws IOException, InterruptedException {
500430
runTest("floatImage14Test", "diffImages14_");
501431
}
502432

503-
@Test
504-
public void floatInline01Test() throws IOException, InterruptedException {
505-
runTest("floatInline01Test", "diffImages01_");
506-
}
507-
508-
@Test
509-
public void floatInline02Test() throws IOException, InterruptedException {
510-
runTest("floatInline02Test", "diffImages02_");
511-
}
512-
513-
@Test
514-
public void floatInline03Test() throws IOException, InterruptedException {
515-
runTest("floatInline03Test", "diffImages03_");
516-
}
517-
518-
@Test
519-
public void floatInline04Test() throws IOException, InterruptedException {
520-
runTest("floatInline04Test", "diffImages04_");
521-
}
522-
523-
@Test
524-
public void floatInline05Test() throws IOException, InterruptedException {
525-
runTest("floatInline05Test", "diffImages05_");
526-
}
527-
528-
@Test
529-
public void floatInline06Test() throws IOException, InterruptedException {
530-
runTest("floatInline06Test", "diffImages06_");
531-
}
532-
533-
@Test
534-
public void floatInline07Test() throws IOException, InterruptedException {
535-
runTest("floatInline07Test", "diffImages07_");
536-
}
537-
538-
@Test
539-
public void floatInline08Test() throws IOException, InterruptedException {
540-
runTest("floatInline08Test", "diffImages08_");
541-
}
542-
543433
@Test
544434
public void floatInline09Test() throws IOException, InterruptedException {
545435
// TODO DEVSIX-1269
546436
runTest("floatInline09Test", "diffImages09_");
547437
}
548438

549-
@Test
550-
public void floatInline10Test() throws IOException, InterruptedException {
551-
runTest("floatInline10Test", "diffImages10_");
552-
}
553-
554-
@Test
555-
public void floatInline11Test() throws IOException, InterruptedException {
556-
runTest("floatInline11Test", "diffImages11_");
557-
}
558-
559-
@Test
560-
public void floatInline12Test() throws IOException, InterruptedException {
561-
runTest("floatInline12Test", "diffImages12_");
562-
}
563-
564-
@Test
565-
public void floatInline13Test() throws IOException, InterruptedException {
566-
runTest("floatInline13Test", "diffImages13_");
567-
}
568-
569-
@Test
570-
public void floatInline14Test() throws IOException, InterruptedException {
571-
runTest("floatInline14Test", "diffImages14_");
572-
}
573-
574-
@Test
575-
public void floatInline15Test() throws IOException, InterruptedException {
576-
// TODO another difference concerning nested spans processing
577-
runTest("floatInline15Test", "diffImages15_");
578-
}
579-
580-
@Test
581-
public void floatInline16Test() throws IOException, InterruptedException {
582-
runTest("floatInline16Test", "diffImages16_");
583-
}
584-
585439
@Test
586440
public void floatInline17Test() throws IOException, InterruptedException {
587441
runTest("floatInline17Test", "diffImages17_");
@@ -597,9 +451,6 @@ private void runTest(String testName, String diff) throws IOException, Interrupt
597451

598452
@Test
599453
public void responsiveIText() throws IOException, InterruptedException {
600-
// TODO results to be reviewed after floating elements splitting support (DEVSIX-1267)
601-
// Split floating element parent has zero height (and therefore border is not drawn around it),
602-
// even though :after { clear: both} feature is applied in html.
603454
PageSize[] pageSizes = {
604455
null,
605456
new PageSize(PageSize.A3.getHeight(), PageSize.A4.getHeight()),

src/test/java/com/itextpdf/html2pdf/css/w3c/css21/positioning/PositionAbsolute008Test.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ This file is part of the iText (R) project.
4444

4545
import com.itextpdf.html2pdf.css.w3c.W3CCssTest;
4646

47-
// TODO DEVSIX-1267
4847
public class PositionAbsolute008Test extends W3CCssTest {
4948
@Override
5049
protected String getHtmlFileName() {

0 commit comments

Comments
 (0)