Fix sonarqube issues for new_lcns_base branch

DEVSIX-5570

Author: Eugene Bochilo

src/main/java/com/itextpdf/html2pdf/actions/data/PdfHtmlProductData.java

@@ -28,7 +28,7 @@ This file is part of the iText (R) project.
 /**
  * Stores an instance of {@link ProductData} related to iText pdfHTML module.
  */
-public class PdfHtmlProductData {
+public final class PdfHtmlProductData {
     private static final String PDF_HTML_PUBLIC_PRODUCT_NAME = "pdfHTML";
     private static final String PDF_HTML_VERSION = "4.0.0-SNAPSHOT";
     private static final int PDF_HTML_COPYRIGHT_SINCE = 2000;
@@ -37,6 +37,10 @@ public class PdfHtmlProductData {
     private static final ProductData PDF_HTML_PRODUCT_DATA = new ProductData(PDF_HTML_PUBLIC_PRODUCT_NAME,
             ProductNameConstant.PDF_HTML, PDF_HTML_VERSION, PDF_HTML_COPYRIGHT_SINCE, PDF_HTML_COPYRIGHT_TO);
 
+    private PdfHtmlProductData() {
+        // Empty constructor.
+    }
+
     /**
      * Getter for an instance of {@link ProductData} related to iText pdfHTML module.
      *

src/main/java/com/itextpdf/html2pdf/actions/events/PdfHtmlProductEvent.java

@@ -31,7 +31,7 @@ This file is part of the iText (R) project.
 /**
  * Class represents events registered in iText pdfHTML module.
  */
-public class PdfHtmlProductEvent extends AbstractProductProcessITextEvent {
+public final class PdfHtmlProductEvent extends AbstractProductProcessITextEvent {
     /**
      * Convert html event type.
      */

src/main/java/com/itextpdf/html2pdf/attach/ProcessorContext.java

@@ -126,7 +126,7 @@ public class ProcessorContext {
 
     /**
      * Indicates whether the document should be opened in immediate flush or not
-     **/
+     */
     private boolean immediateFlush;
 
     // Variable fields
@@ -464,8 +464,8 @@ public boolean isImmediateFlush() {
 
     /**
      * Gets html meta info container.
-     * <p>
-     * Meta info will be used to determine event origin.
+     *
+     * <p>Meta info will be used to determine event origin.
      *
      * @return html meta info container
      */
@@ -484,6 +484,7 @@ public void setMetaInfo(IMetaInfo metaInfo) {
 
     /**
      * Check if the processor is currently processing an inline svg
+     *
      * @return True if the processor is processing an inline Svg, false otherwise.
      */
     public boolean isProcessingInlineSvg() {

src/main/java/com/itextpdf/html2pdf/attach/impl/DefaultHtmlProcessor.java

@@ -241,8 +241,8 @@ public List<com.itextpdf.layout.element.IElement> processElements(INode root) {
      */
     @Override
     public Document processDocument(INode root, PdfDocument pdfDocument) {
-        EventManager.getInstance().onEvent(PdfHtmlProductEvent.createConvertHtmlEvent(pdfDocument.getDocumentIdWrapper(),
-                context.getMetaInfoContainer().getMetaInfo()));
+        EventManager.getInstance().onEvent(PdfHtmlProductEvent.createConvertHtmlEvent(
+                pdfDocument.getDocumentIdWrapper(), context.getMetaInfoContainer().getMetaInfo()));
 
         context.reset(pdfDocument);
         if (!context.hasFonts()) {
@@ -269,8 +269,8 @@ public Document processDocument(INode root, PdfDocument pdfDocument) {
                     ++counter;
                     doc.relayout();
                     if (counter >= context.getLimitOfLayouts()) {
-                        logger.warn(
-                                MessageFormatUtil.format(Html2PdfLogMessageConstant.EXCEEDED_THE_MAXIMUM_NUMBER_OF_RELAYOUTS));
+                        logger.warn(MessageFormatUtil.format(
+                                Html2PdfLogMessageConstant.EXCEEDED_THE_MAXIMUM_NUMBER_OF_RELAYOUTS));
                         break;
                     }
                 } while (((DocumentRenderer) doc.getRenderer()).isRelayoutRequired());
@@ -330,8 +330,10 @@ private void visit(INode node) {
             } else {
                 context.getState().push(tagWorker);
             }
-            if (context.getState().getStack().size() == 1 && tagWorker != null && tagWorker.getElementResult() != null) {
-                tagWorker.getElementResult().setProperty(Property.META_INFO, new MetaInfoContainer(context.getMetaInfoContainer().getMetaInfo()));
+            if (context.getState().getStack().size() == 1 &&
+                    tagWorker != null && tagWorker.getElementResult() != null) {
+                tagWorker.getElementResult().setProperty(
+                        Property.META_INFO, new MetaInfoContainer(context.getMetaInfoContainer().getMetaInfo()));
             }
             if (tagWorker instanceof HtmlTagWorker) {
                 ((HtmlTagWorker) tagWorker).processPageRules(node, cssResolver, context);

src/main/java/com/itextpdf/html2pdf/attach/impl/DefaultTagWorkerFactory.java

@@ -61,7 +61,7 @@ public class DefaultTagWorkerFactory implements ITagWorkerFactory {
     private static final ITagWorkerFactory INSTANCE = new DefaultTagWorkerFactory();
 
     /** The default mapping. */
-    TagProcessorMapping defaultMapping;
+    private final TagProcessorMapping defaultMapping;
 
     /**
      * Instantiates a new default tag worker factory.
@@ -105,6 +105,10 @@ public final ITagWorker getTagWorker(IElementNode tag, ProcessorContext context)
         return tagWorker;
     }
 
+    TagProcessorMapping getDefaultMapping() {
+        return defaultMapping;
+    }
+
     /**
      * Gets the tag worker class for a specific element node.
      *

src/main/java/com/itextpdf/html2pdf/attach/impl/HtmlMetaInfoContainer.java

@@ -41,7 +41,7 @@ public HtmlMetaInfoContainer(IMetaInfo metaInfo) {
     }
 
     /**
-     * Return the IMetaInfo object
+     * Return the IMetaInfo object.
      *
      * @return returns IMetaInfo
      */

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/PageTargetCountRenderer.java

@@ -93,7 +93,8 @@ public LayoutResult layout(LayoutContext layoutContext) {
     @Override
     public void draw(DrawContext drawContext) {
         if (!TargetCounterHandler.isValueDefinedForThisId(this, target)) {
-            LOGGER.warn(MessageFormatUtil.format(Html2PdfLogMessageConstant.CANNOT_RESOLVE_TARGET_COUNTER_VALUE, target));
+            LOGGER.warn(MessageFormatUtil.format(
+                    Html2PdfLogMessageConstant.CANNOT_RESOLVE_TARGET_COUNTER_VALUE, target));
         }
         super.draw(drawContext);
     }

src/main/java/com/itextpdf/html2pdf/css/apply/impl/DefaultCssApplierFactory.java

@@ -57,7 +57,7 @@ public class DefaultCssApplierFactory implements ICssApplierFactory {
     private static final ICssApplierFactory INSTANCE = new DefaultCssApplierFactory();
 
     /** The default mapping of CSS keywords and CSS appliers. */
-    TagProcessorMapping defaultMapping;
+    private final TagProcessorMapping defaultMapping;
 
     /**
      * Creates a new {@link DefaultCssApplierFactory} instance.
@@ -108,6 +108,10 @@ public ICssApplier getCustomCssApplier(IElementNode tag) {
         return null;
     }
 
+    TagProcessorMapping getDefaultMapping() {
+        return defaultMapping;
+    }
+
     /**
      * Gets the css applier class.
      *

src/main/java/com/itextpdf/html2pdf/css/apply/util/CounterProcessorUtil.java

@@ -47,7 +47,6 @@ This file is part of the iText (R) project.
 import com.itextpdf.html2pdf.css.resolve.func.counter.CssCounterManager;
 import com.itextpdf.styledxmlparser.css.util.CssDimensionParsingUtils;
 import com.itextpdf.styledxmlparser.node.IElementNode;
-import com.itextpdf.styledxmlparser.node.INode;
 
 import java.util.Map;
 

src/main/java/com/itextpdf/html2pdf/css/apply/util/FontStyleApplierUtil.java

@@ -242,15 +242,16 @@ public static void applyFontStyles(Map<String, String> cssProps, ProcessorContex
             element.setProperty(Property.UNDERLINE, underlineList);
         }
 
-        String textIndent = cssProps.get(CssConstants.TEXT_INDENT);
+        String textIndent = cssProps.get(CommonCssConstants.TEXT_INDENT);
         if (textIndent != null) {
             UnitValue textIndentValue = CssDimensionParsingUtils.parseLengthValueToPt(textIndent, em, rem);
             if (textIndentValue != null) {
                 if (textIndentValue.isPointValue()) {
                     element.setProperty(Property.FIRST_LINE_INDENT, textIndentValue.getValue());
                 } else {
                     logger.error(MessageFormatUtil.format(
-                            Html2PdfLogMessageConstant.CSS_PROPERTY_IN_PERCENTS_NOT_SUPPORTED, CssConstants.TEXT_INDENT));
+                            Html2PdfLogMessageConstant.CSS_PROPERTY_IN_PERCENTS_NOT_SUPPORTED,
+                            CommonCssConstants.TEXT_INDENT));
                 }
             }
         }