Skip to content

Commit ab7a886

Browse files
author
vitali.prudnikovich
committed
Test cropped images height
The test imageBase64DifferentFormatsTest started to fail during fixing DEVSIX-6985 because svg image didn't fit on the 1st page and was (correctly) rendered on the second page. Now Svg image size is decreased to still put it on the 1st page and cmp pdf file is replaced. DEVSIX-6985
1 parent 10909d2 commit ab7a886

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

src/test/java/com/itextpdf/html2pdf/element/FigureTest.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,21 +69,18 @@ public void figureInSpanTest() throws IOException, InterruptedException {
6969
}
7070

7171
@Test
72-
//TODO DEVSIX-6985: change 1 to 2 in "PdfImageXObject image = doc.getPage(1).getResources()", change the assert
73-
// from "Assert.assertTrue(isImageCropped)" to assertFalse
7472
public void checkImageRemainsUncutWithFigureTagTest() throws IOException {
7573
File pdfFile = new File(destinationFolder + "imageInFigure.pdf");
76-
HtmlConverter.convertToPdf(new File(sourceFolder + "imageInFigure.html"),
77-
pdfFile);
74+
HtmlConverter.convertToPdf(new File(sourceFolder + "imageInFigure.html"), pdfFile);
7875
try (PdfDocument doc = new PdfDocument(new PdfReader(pdfFile))) {
79-
PdfImageXObject image = doc.getPage(1).getResources()
80-
.getImage(new PdfName("Im1"));
76+
final int pageNr = 2;
77+
PdfImageXObject image = doc.getPage(pageNr).getResources().getImage(new PdfName("Im1"));
8178
Assert.assertNotNull(image);
82-
ImageSizeMeasuringListener listener = new ImageSizeMeasuringListener(1);
79+
ImageSizeMeasuringListener listener = new ImageSizeMeasuringListener(pageNr);
8380
PdfCanvasProcessor processor = new PdfCanvasProcessor(listener);
84-
processor.processPageContent(doc.getPage(1));
81+
processor.processPageContent(doc.getPage(pageNr));
8582
boolean isImageCropped = listener.bbox.getY() < 0;
86-
Assert.assertTrue(isImageCropped);
83+
Assert.assertFalse(isImageCropped);
8784
}
8885
}
8986
}
Binary file not shown.

src/test/resources/com/itextpdf/html2pdf/element/ImageTest/imageBase64DifferentFormats.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</div>
2424
<div>
2525
<p>SVG image</p>
26-
<img src="data:image/svg+xml;base64,PHN2ZyB3aWR0aD0nODAwJyBoZWlnaHQ9JzgwMCcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2ZXJzaW9uPSIxLjEiPgogICAgPGNpcmNsZSBjeD0nMTAwJyBjeT0nMTAwJyByPSc4MCcgc3Ryb2tlPSdyZWQnIGZpbGw9J2dyZWVuJy8+Cjwvc3ZnPg==">
26+
<img src="data:image/svg+xml;base64,PHN2ZyB3aWR0aD0nMzUwJyBoZWlnaHQ9JzM1MCcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2ZXJzaW9uPSIxLjEiPgogICAgPGNpcmNsZSBjeD0nMTAwJyBjeT0nMTAwJyByPSc4MCcgc3Ryb2tlPSdyZWQnIGZpbGw9J2dyZWVuJy8+Cjwvc3ZnPg==">
2727
</div>
2828
<div>
2929
<p>TIFF image</p>

0 commit comments

Comments
 (0)