[RELEASE] iText 7 pdfHTML - 3.0.1

https://github.com/itext/i7j-pdfhtml/releases/tag/3.0.1

* release/3.0.1:
  [RELEASE] 3.0.1-SNAPSHOT -> 3.0.1
  Fix issues with number filtering for <input type="number">
  Update cmp files
  Remove closed TODO remarks. Add ticket references for unresolved TODOs
  Refactor tests since zero or negative size log message level changed to INFO
  Fix problem with NullPointerException in ListStyleApplierUtil class and add invalidLinearGradientTest
  Add logic of parsing linear-gradient in CSS 'content' property
  Pass svg root renderer to SvgDrawContext
  Add PdfDocument as an argument for build linear gradient
  Add new tests for border collapse in table elements
  Add shorthand text decoration support
  Add integration tests for CSS linear-gradient background-image for different HTML elements
  Tests update
  Updates after review
  Add tests for TR's border style
  Add missing copyright headers
  Test update
  Add linear gradient support to ListStyleApplierUtil class
  Add tests for the linear gradient in list-style-image property
  Tests update and add test with span element with image background
  Add test reproducing the exception on rendering table inside of page margin
  Add missing copyright headers
  Linear Gradient support for background image
  Minor fix in a comment
  Add DEVSIX link in TODO
  Specify ticket IDs for several TODOs
  Update .mailmap
  Fix Javadoc warning and a typo in the method description
  Update cmp files
  Update some KEEP_TOGETHER related cmps
  Add some new tagging tests. Update some cmps
  Add missing copyright headers
  Improve detection of whether pages counter reference is present in the stylesheet
  Change RND to DEVSIX task and delete closed DEVSIX
  Move TableAlignmentIssuesTest from samples internal repository
  Add test on font weight style applying to anonymous paragraphs
  Delete document font size setting in BodyTagWorker constructor and move runApplier method
  Add extending from the ExtendedITextTest to OrphansWidowsUnitTest class
  Add tests for text-decoration shorthand CSS property
  Add tests for line-height property in span elements
  [RELEASE] Update dependency versions
  Refine TODO regarding incomplete support for absolute positioning for images

Author: iText-CI

.mailmap

@@ -64,7 +64,6 @@ Peter Goodman <pete@petegoo.com>                              <github@petegoo.co
 Peter Goodman <pete@petegoo.com>                              <pete@petegoo.com>
 Peter Goodman <pete@petegoo.com>                              <peter.goodman@pushpay.com>
 Peter Kjuak <peter.kjuak@itextpdf.com>                        <peter.kjuak@itextpdf.com>
-Richard Cohn <rcohn@adobe.com>                                <richard@cohns.org>
 Richard Schwark <richard.schwark@planet.de>                   <richard.schwark@planet.de>
 Roman Leonov <roman.leonov@duallab.com>                       <roman.leonov@duallab.com>
 Roman Nadvodny <roman.nadvodniuk@duallab.com>                 <roman.nadvodniuk@duallab.com>

pom.xml

@@ -5,12 +5,12 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.11</version>
+    <version>7.1.12</version>
     <relativePath/>
   </parent>
 
   <artifactId>html2pdf</artifactId>
-  <version>3.0.0</version>
+  <version>3.0.1</version>
 
   <name>pdfHTML</name>
   <description>pdfHTML is an iText 7 add-on that lets you to parse (X)HTML snippets and the associated CSS and converts

src/main/java/com/itextpdf/html2pdf/LogMessageConstant.java

@@ -73,6 +73,8 @@ public final class LogMessageConstant {
     public static final String INPUT_TYPE_IS_NOT_SUPPORTED = "Input type {0} is not supported";
     /** The Constant INVALID_CSS_PROPERTY_DECLARATION. */
     public static final String INVALID_CSS_PROPERTY_DECLARATION = "Invalid css property declaration: {0}";
+    /** The Constant INVALID_CSS_PROPERTY_DECLARATION. */
+    public static final String INVALID_GRADIENT_DECLARATION = "Invalid gradient declaration: {0}";
     /** The Constant MARGIN_VALUE_IN_PERCENT_NOT_SUPPORTED. */
     public static final String MARGIN_VALUE_IN_PERCENT_NOT_SUPPORTED = "Margin value in percents not supported";
     /** The Constant NOT_SUPPORTED_LIST_STYLE_TYPE. */
@@ -99,6 +101,8 @@ public final class LogMessageConstant {
     public static final String QUOTES_PROPERTY_INVALID = "Quote property \"{0}\" is invalid. It should contain even number of <string> values.";
     /** The Constant TEXT_DECORATION_BLINK_NOT_SUPPORTED. */
     public static final String TEXT_DECORATION_BLINK_NOT_SUPPORTED = "text-decoration: blink not supported";
+    /** The Constant HSL_COLOR_NOT_SUPPORTED. */
+    public static final String HSL_COLOR_NOT_SUPPORTED = "Hsl colors are not supported";
     /** The Constant UNABLE_TO_PROCESS_EXTERNAL_CSS_FILE. */
     public static final String UNABLE_TO_PROCESS_EXTERNAL_CSS_FILE = "Unable to process external css file";
     /** The Constant UNABLE_TO_PROCESS_IMAGE_AS_SVG */

src/main/java/com/itextpdf/html2pdf/attach/impl/DefaultHtmlProcessor.java

@@ -350,13 +350,14 @@ private void visit(INode node) {
                 ((HtmlTagWorker) tagWorker).processPageRules(node, cssResolver, context);
             }
 
-            context.getOutlineHandler().addOutlineAndDestToDocument(tagWorker, element, context);
+            if (TagConstants.BODY.equals(element.name()) || TagConstants.HTML.equals(element.name())) {
+                runApplier(element, tagWorker);
+            }
 
+            context.getOutlineHandler().addOutlineAndDestToDocument(tagWorker, element, context);
 
             visitPseudoElement(element, tagWorker, CssConstants.BEFORE);
             visitPseudoElement(element, tagWorker, CssConstants.PLACEHOLDER);
-            if (TagConstants.BODY.equals(element.name()) || TagConstants.HTML.equals(element.name()))
-                runApplier(element, tagWorker);
             for (INode childNode : element.childNodes()) {
                 if (!context.isProcessingInlineSvg()) {
                     visit(childNode);

src/main/java/com/itextpdf/html2pdf/attach/impl/DefaultTagWorkerMapping.java

@@ -223,6 +223,7 @@ class DefaultTagWorkerMapping {
         workerMapping.putMapping(beforePseudoElemName, CssConstants.TABLE, DivTagWorker.class);
         workerMapping.putMapping(afterPseudoElemName, CssConstants.TABLE, DivTagWorker.class);
         workerMapping.putMapping(CssPseudoElementUtil.createPseudoElementTagName(TagConstants.IMG), ImgTagWorker.class);
+        workerMapping.putMapping(CssPseudoElementUtil.createPseudoElementTagName(TagConstants.DIV), DivTagWorker.class);
 
         // custom elements mapping, implementation-specific
         workerMapping.putMapping(PageCountElementNode.PAGE_COUNTER_TAG, PageCountWorker.class);

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/HtmlDocumentRenderer.java

@@ -143,7 +143,7 @@ public HtmlDocumentRenderer(Document document, boolean immediateFlush) {
     public void processPageRules(INode rootNode, ICssResolver cssResolver, ProcessorContext context) {
         PageContextProperties firstPageProps = PageContextProperties.resolve(rootNode, cssResolver, context.getCssContext(),
                 PageContextConstants.FIRST, PageContextConstants.RIGHT);
-        // TODO in documents with set to rtl on root document, first page is considered as left
+        // TODO DEVSIX-4118 in documents with set to rtl on root document, first page is considered as left
         PageContextProperties leftPageProps = PageContextProperties.resolve(rootNode, cssResolver, context.getCssContext(),
                 PageContextConstants.LEFT);
         PageContextProperties rightPageProps = PageContextProperties.resolve(rootNode, cssResolver, context.getCssContext(),
@@ -462,7 +462,7 @@ private PageContextProcessor getPageProcessor(int pageNum) {
      * @return true, if is current page left
      */
     private boolean isPageLeft(int pageNum) {
-        // TODO rtl
+        // TODO DEVSIX-4118 rtl
         boolean pageIsEven = pageNum % 2 == 0;
         return evenPagesAreLeft == pageIsEven;
     }

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/PageMarginBoxBuilder.java

@@ -47,6 +47,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.html2pdf.attach.ProcessorContext;
 import com.itextpdf.html2pdf.css.apply.ICssApplier;
 import com.itextpdf.html2pdf.css.page.PageMarginRunningElementNode;
+import com.itextpdf.html2pdf.css.resolve.DefaultCssResolver;
 import com.itextpdf.kernel.geom.PageSize;
 import com.itextpdf.kernel.geom.Rectangle;
 import com.itextpdf.kernel.pdf.PdfDocument;
@@ -64,6 +65,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.styledxmlparser.css.util.CssUtils;
 import com.itextpdf.styledxmlparser.node.IElementNode;
 import com.itextpdf.styledxmlparser.node.INode;
+import com.itextpdf.styledxmlparser.node.IStylesContainer;
 import com.itextpdf.styledxmlparser.node.ITextNode;
 import org.slf4j.LoggerFactory;
 
@@ -133,6 +135,7 @@ public PageMarginBoxContextNode[] getNodes() {
     private IElement processMarginBoxContent(PageMarginBoxContextNode marginBoxContentNode, int pageNumber, ProcessorContext context) {
         IElementNode dummyMarginBoxNode = new PageMarginBoxDummyElement();
         dummyMarginBoxNode.setStyles(marginBoxContentNode.getStyles());
+        DefaultCssResolver cssResolver = new DefaultCssResolver(marginBoxContentNode, context);
         ITagWorker marginBoxWorker = context.getTagWorkerFactory().getTagWorker(dummyMarginBoxNode, context);
         for (int i = 0; i < marginBoxContentNode.childNodes().size(); i++) {
             INode childNode = marginBoxContentNode.childNodes().get(i);
@@ -142,6 +145,13 @@ private IElement processMarginBoxContent(PageMarginBoxContextNode marginBoxConte
             } else if (childNode instanceof IElementNode) {
                 ITagWorker childTagWorker = context.getTagWorkerFactory().getTagWorker((IElementNode) childNode, context);
                 if (childTagWorker != null) {
+                    Map<String, String> stringStringMap = cssResolver.resolveStyles(childNode, context.getCssContext());
+                    ((IElementNode) childNode).setStyles(stringStringMap);
+                    ICssApplier cssApplier = context.getCssApplierFactory().getCssApplier((IElementNode) childNode);
+                    if (cssApplier != null) {
+                        cssApplier.apply(context, (IStylesContainer) childNode, childTagWorker);
+                    }
+
                     childTagWorker.processEnd((IElementNode) childNode, context);
                     marginBoxWorker.processTagChild(childTagWorker, context);
                 }
@@ -584,7 +594,7 @@ private float[] calculateDistribution(float argA, float argC, float flexA, float
      * @param dim        Dimension container containing min and max dimension info
      * @param dimensions array of calculated auto values for boxes in the given dimension
      * @param index      position in the array to look at
-     * @return True if the values in dimensions trigger a recalculation, false otherwise
+     * @return <code>true</code> if the values in dimensions trigger a recalculation, <code>false</code> otherwise
      */
     private boolean recalculateIfNecessary(DimensionContainer dim, float[] dimensions, int index) {
         if (dim != null) {
@@ -603,7 +613,7 @@ private boolean recalculateIfNecessary(DimensionContainer dim, float[] dimension
     /**
      * Calculate the margin boxes given the list of margin boxes that have generated content
      *
-     * @return Rectangle[12] containing the calulated bounding boxes of the margin-box-nodes. Rectangles with 0 width and/or heigh
+     * @return Rectangle[12] containing the calculated bounding boxes of the margin-box-nodes. Rectangles with 0 width and/or height
      * refer to empty boxes. The order is TLC(top-left-corner)-TL-TC-TY-TRC-RT-RM-RB-RBC-BR-BC-BL-BLC-LB-LM-LT
      */
     private Rectangle[] calculateMarginBoxRectanglesCornersOnly() {

src/main/java/com/itextpdf/html2pdf/attach/impl/tags/BodyTagWorker.java

@@ -52,11 +52,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.IPropertyContainer;
 import com.itextpdf.layout.element.Div;
 import com.itextpdf.layout.element.IElement;
-import com.itextpdf.layout.property.Property;
-import com.itextpdf.layout.property.UnitValue;
-import com.itextpdf.html2pdf.css.CssConstants;
 import com.itextpdf.layout.tagging.IAccessibleElement;
-import com.itextpdf.styledxmlparser.css.util.CssUtils;
 import com.itextpdf.styledxmlparser.node.IElementNode;
 
 /**
@@ -79,15 +75,6 @@ public class BodyTagWorker extends DivTagWorker {
     public BodyTagWorker(IElementNode element, ProcessorContext context) {
         super(element, context);
         parentTagWorker = context.getState().empty() ? null : context.getState().top();
-        if (parentTagWorker != null && parentTagWorker.getElementResult() != null) {
-            // TODO this is not in css applier because css applier is called after the elements are added to the document
-            // We need to apply font styles here specifically to set font-size to the document because this is needed for
-            // inline-blocks with fixed height when the height is smaller than the defined font size
-            float em = CssUtils.parseAbsoluteLength(element.getStyles().get(CssConstants.FONT_SIZE));
-            if (em != 0) {
-                parentTagWorker.getElementResult().setProperty(Property.FONT_SIZE, UnitValue.createPointValue(em));
-            }
-        }
 
         PdfDocument pdfDocument = context.getPdfDocument();
         if (pdfDocument != null) {

src/main/java/com/itextpdf/html2pdf/attach/impl/tags/ImgTagWorker.java

@@ -96,8 +96,10 @@ public ImgTagWorker(IElementNode element, ProcessorContext context) {
         }
 
         display = element.getStyles() != null ? element.getStyles().get(CssConstants.DISPLAY) : null;
-        // TODO this is a workaround for now Imgto that image is not added as inline
         if (element.getStyles() != null && CssConstants.ABSOLUTE.equals(element.getStyles().get(CssConstants.POSITION))) {
+            // TODO DEVSIX-1393: we don't support absolute positioning in inline context.
+            // This workaround allows to identify image as an element which needs to be processed outside of inline context.
+            // See AbsoluteReplacedHeight001Test.
             display = CssConstants.BLOCK;
         }
 

src/main/java/com/itextpdf/html2pdf/attach/impl/tags/InputTagWorker.java

@@ -58,6 +58,8 @@ This file is part of the iText (R) project.
 import com.itextpdf.html2pdf.html.AttributeConstants;
 import com.itextpdf.styledxmlparser.css.util.CssUtils;
 import com.itextpdf.styledxmlparser.node.IElementNode;
+
+import java.util.regex.Pattern;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -66,6 +68,9 @@ This file is part of the iText (R) project.
  */
 public class InputTagWorker implements ITagWorker, IDisplayAware {
 
+    private static final Pattern NUMBER_INPUT_ALLOWED_VALUES =
+            Pattern.compile("^(((-?[0-9]+)(\\.[0-9]+)?)|(-?\\.[0-9]+))$");
+
     /**
      * The form element.
      */
@@ -190,8 +195,9 @@ public IPropertyContainer getElementResult() {
         return formElement;
     }
 
-    private static String preprocessInputValue(String value, String inputType) {
-        if (AttributeConstants.NUMBER.equals(inputType) && value != null && !value.matches("[0-9.]*")) {
+    static String preprocessInputValue(String value, String inputType) {
+        if (AttributeConstants.NUMBER.equals(inputType) && value != null &&
+                !NUMBER_INPUT_ALLOWED_VALUES.matcher(value).matches()) {
             value = "";
         }
         return value;