Apply overflow: visible on anonymous flex items

ars18wrw · ars18wrw · commit 76cead495615 · 2021-03-18T17:00:44.000+03:00
Otherwise iText's internal FIT is set, which causes overflow
being processed incorrectly

DEVSIX-5178
diff --git a/src/main/java/com/itextpdf/html2pdf/attach/util/WaitingInlineElementsHelper.java b/src/main/java/com/itextpdf/html2pdf/attach/util/WaitingInlineElementsHelper.java
@@ -195,6 +195,7 @@ public void flushHangingLeaves(IPropertyContainer container) {
                 }
             } else if (((IElement) container).getRenderer() instanceof FlexContainerRenderer) {
                 final Div div = new Div();
+                OverflowApplierUtil.applyOverflow(map, div);
                 div.add(p);
                 ((Div) container).add(div);
             } else if (container instanceof Div) {
diff --git a/src/test/java/com/itextpdf/html2pdf/css/DisplayFlexTest.java b/src/test/java/com/itextpdf/html2pdf/css/DisplayFlexTest.java
@@ -481,6 +481,12 @@ public void smallHeightAndBigMaxHeightOnContainerTest() throws IOException, Inte
         convertToPdfAndCompare("smallHeightAndBigMaxHeightOnContainer", SOURCE_FOLDER, DESTINATION_FOLDER);
     }
 
+    @Test
+    public void smallHeightAndBigMaxHeightOnContainerAnonymousFlexItemTest() throws IOException, InterruptedException {
+        convertToPdfAndCompare("smallHeightAndBigMaxHeightOnContainerAnonymousFlexItem",
+                SOURCE_FOLDER, DESTINATION_FOLDER);
+    }
+
     private static void assertDiv(IElement element, String text) {
         Assert.assertTrue(element instanceof Div);
         Assert.assertEquals(1, ((Div) element).getChildren().size());
diff --git a/src/test/resources/com/itextpdf/html2pdf/css/DisplayFlexTest/cmp_smallHeightAndBigMaxHeightOnContainerAnonymousFlexItem.pdf b/src/test/resources/com/itextpdf/html2pdf/css/DisplayFlexTest/cmp_smallHeightAndBigMaxHeightOnContainerAnonymousFlexItem.pdf
diff --git a/src/test/resources/com/itextpdf/html2pdf/css/DisplayFlexTest/smallHeightAndBigMaxHeightOnContainerAnonymousFlexItem.html b/src/test/resources/com/itextpdf/html2pdf/css/DisplayFlexTest/smallHeightAndBigMaxHeightOnContainerAnonymousFlexItem.html
@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<html xmlns="http://www.w3.org/1999/xhtml">
+<head>
+    <style>
+        div { width: 200px; }
+        div.flexbox {
+            border: 1px dashed blue;
+            background: lightgreen;
+            font-size: 10px;
+            display: flex;
+        }
+    </style>
+</head>
+<body>
+
+<div class="flexbox" style="height: 2px; max-height: 100px; background-color: blue;">
+    text<br/>text<br/>text<br/>text<br/>text<br/>
+</div>
+
+</body>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,7 @@ public void flushHangingLeaves(IPropertyContainer container) {`
`195`	`195`	`}`
`196`	`196`	`} else if (((IElement) container).getRenderer() instanceof FlexContainerRenderer) {`
`197`	`197`	`final Div div = new Div();`
	`198`	`+ OverflowApplierUtil.applyOverflow(map, div);`
`198`	`199`	`div.add(p);`
`199`	`200`	`((Div) container).add(div);`
`200`	`201`	`} else if (container instanceof Div) {`