Fix bug in distribution, add tests

DEVSIX-1050

Author: LodrKumquat

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/HeightDimensionContainer.java

@@ -5,26 +5,35 @@
 import com.itextpdf.layout.layout.LayoutArea;
 import com.itextpdf.layout.layout.LayoutContext;
 import com.itextpdf.layout.layout.LayoutResult;
+import com.itextpdf.layout.minmaxwidth.MinMaxWidthUtils;
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.styledxmlparser.css.CssContextNode;
 
 class HeightDimensionContainer extends DimensionContainer {
 
+    private static final float infHeight = 1e6f;;
+
     HeightDimensionContainer(CssContextNode pmbcNode, float width, float maxHeight, IRenderer renderer, float additionalWidthFix) {
         String height = pmbcNode.getStyles().get(CssConstants.HEIGHT);
-        if (height != null && !height.equals("auto")) {
+        if (height != null && !height.equals(CssConstants.AUTO)) {
             dimension = parseDimension(pmbcNode, height, maxHeight, additionalWidthFix);
         }
         minDimension = getMinHeight(pmbcNode, maxHeight, additionalWidthFix);
         maxDimension = getMaxHeight(pmbcNode, maxHeight, additionalWidthFix);
 
-        LayoutArea layoutArea = new LayoutArea(1, new Rectangle(0, 0, width, maxHeight));
-        LayoutContext minimalContext = new LayoutContext(layoutArea);
-
-        LayoutResult quickLayout = renderer.layout(minimalContext);
-
-        maxContentDimension = quickLayout.getOccupiedArea().getBBox().getHeight();
-        minContentDimension = maxContentDimension;
+        if (!isAutoDimension()) {
+            maxContentDimension = dimension;
+            maxContentDimension = dimension;
+        } else {
+            LayoutArea layoutArea = new LayoutArea(1, new Rectangle(0, 0, width, infHeight));
+            LayoutContext minimalContext = new LayoutContext(layoutArea);
+
+            LayoutResult quickLayout = renderer.layout(minimalContext);
+            if (quickLayout.getStatus() != LayoutResult.NOTHING) {
+                maxContentDimension = quickLayout.getOccupiedArea().getBBox().getHeight();
+                minContentDimension = maxContentDimension;
+            }
+        }
     }
 
     private float getMinHeight(CssContextNode node, float maxAvailableHeight, float additionalWidthFix) {

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/PageContextProcessor.java

@@ -10,14 +10,17 @@ class WidthDimensionContainer extends DimensionContainer {
 
     public WidthDimensionContainer(CssContextNode node, float maxWidth, IRenderer renderer, float additionalWidthFix) {
         String width = node.getStyles().get(CssConstants.WIDTH);
-        if (width != null && !width.equals("auto")) {
+        if (width != null && !width.equals(CssConstants.AUTO)) {
             dimension = parseDimension(node, width, maxWidth, additionalWidthFix);
         }
         minDimension = getMinWidth(node, maxWidth, additionalWidthFix);
         maxDimension = getMaxWidth(node, maxWidth, additionalWidthFix);
-        MinMaxWidth minMaxWidth = null;
-        if (renderer instanceof BlockRenderer) {
-            minMaxWidth = ((BlockRenderer) renderer).getMinMaxWidth();
+
+        if (!isAutoDimension()) {
+            maxContentDimension = dimension;
+            maxContentDimension = dimension;
+        } else if (renderer instanceof BlockRenderer) {
+            MinMaxWidth minMaxWidth = ((BlockRenderer) renderer).getMinMaxWidth();
             maxContentDimension = minMaxWidth.getMaxWidth();
             minContentDimension = minMaxWidth.getMinWidth();
         }

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/WidthDimensionContainer.java

@@ -61,8 +61,6 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.property.UnitValue;
 import com.itextpdf.styledxmlparser.css.resolve.CssDefaults;
 import com.itextpdf.styledxmlparser.css.util.CssUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.util.Map;
 
@@ -71,11 +69,6 @@ This file is part of the iText (R) project.
  */
 public class BorderStyleApplierUtil {
 
-    /**
-     * The logger.
-     */
-    private static final Logger LOGGER = LoggerFactory.getLogger(BorderStyleApplierUtil.class);
-
     /**
      * Creates a new {@link BorderStyleApplierUtil} instance.
      */
@@ -192,7 +185,6 @@ public static Border getCertainBorder(String borderWidth, String borderStyle, St
             return null;
         }
         if (unitValue.isPercentValue()) {
-            LOGGER.error("border-width in percents is not supported");
             return null;
         }
 

src/main/java/com/itextpdf/html2pdf/css/apply/util/BorderStyleApplierUtil.java

@@ -1,8 +1,6 @@
 package com.itextpdf.html2pdf.css.media.page;
 
 import com.itextpdf.html2pdf.ExtendedHtmlConversionITextTest;
-import com.itextpdf.test.annotations.LogMessage;
-import com.itextpdf.test.annotations.LogMessages;
 import com.itextpdf.test.annotations.type.IntegrationTest;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -282,4 +280,24 @@ public void largeFixedSidesNoMiddleTest() throws IOException, InterruptedExcepti
     public void allFixedWithMBPTest() throws IOException, InterruptedException {
         convertToPdfAndCompare("allFixedWithMBPTest", sourceFolder, destinationFolder);
     }
+
+    @Test
+    public void percentageVerticalTest() throws IOException, InterruptedException {
+        convertToPdfAndCompare("percentageVerticalTest", sourceFolder, destinationFolder);
+    }
+
+    @Test
+    public void cornerPrecisionTest() throws IOException, InterruptedException {
+        convertToPdfAndCompare("cornerPrecisionTest", sourceFolder, destinationFolder);
+    }
+
+    @Test
+    public void negativeMarginsTest() throws IOException, InterruptedException {
+        convertToPdfAndCompare("negativeMarginsTest", sourceFolder, destinationFolder);
+    }
+
+    @Test
+    public void hugeImageTest() throws IOException, InterruptedException {
+        convertToPdfAndCompare("hugeImageTest", sourceFolder, destinationFolder);
+    }
 }