Skip to content

Commit 4ae8e2e

Browse files
committed
Fix issue with align-content space-between, space-around and space-evenly values in case gap is applied
DEVSIX-9473
1 parent 78eb8c5 commit 4ae8e2e

30 files changed

+351
-8
lines changed

src/test/java/com/itextpdf/html2pdf/css/flex/FlexGapTest.java

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,13 +175,28 @@ public void gapAlignContentRowRevDirTest() throws IOException, InterruptedExcept
175175
}
176176

177177
@Test
178-
// TODO DEVSIX-9473 Fix issues on page split
179178
public void gapAlignContentColumnDirTest() throws IOException, InterruptedException {
180179
convertToPdfAndCompare("gapAlignContentColumnDir", SOURCE_FOLDER, DESTINATION_FOLDER);
181180
}
182181

183182
@Test
184-
// TODO DEVSIX-9473 Fix issues on page split
183+
public void gapAlignContentColumnDirPageSplitTest() throws IOException, InterruptedException {
184+
convertToPdfAndCompare("gapAlignContentColumnDirPageSplit", SOURCE_FOLDER, DESTINATION_FOLDER);
185+
}
186+
187+
@Test
188+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
189+
public void gapAlignContentColumnDirSmallHeightTest() throws IOException, InterruptedException {
190+
convertToPdfAndCompare("gapAlignContentColumnDirSmallHeight", SOURCE_FOLDER, DESTINATION_FOLDER);
191+
}
192+
193+
@Test
194+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
195+
public void gapAlignContentColumnDirSmallHeightWrapRevTest() throws IOException, InterruptedException {
196+
convertToPdfAndCompare("gapAlignContentColumnDirSmallHeightWrapRev", SOURCE_FOLDER, DESTINATION_FOLDER);
197+
}
198+
199+
@Test
185200
public void gapAlignContentColumnRevDirTest() throws IOException, InterruptedException {
186201
convertToPdfAndCompare("gapAlignContentColumnRevDir", SOURCE_FOLDER, DESTINATION_FOLDER);
187202
}

src/test/java/com/itextpdf/html2pdf/css/flex/PageSplitTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,13 @@ public void alignContentFlexEndWrapReverseTest() throws IOException, Interrupted
7575
}
7676

7777
@Test
78+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
7879
public void alignContentCenterTest() throws IOException, InterruptedException {
7980
convertToPdfAndCompare("alignContentCenter", SOURCE_FOLDER, DESTINATION_FOLDER);
8081
}
8182

8283
@Test
84+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
8385
public void alignContentCenterWrapReverseTest() throws IOException, InterruptedException {
8486
convertToPdfAndCompare("alignContentCenterWrapReverse", SOURCE_FOLDER, DESTINATION_FOLDER);
8587
}
@@ -165,11 +167,13 @@ public void rowRevAlignContentFlexEndWrapReverseTest() throws IOException, Inter
165167
}
166168

167169
@Test
170+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
168171
public void rowRevAlignContentCenterTest() throws IOException, InterruptedException {
169172
convertToPdfAndCompare("rowRevAlignContentCenter", SOURCE_FOLDER, DESTINATION_FOLDER);
170173
}
171174

172175
@Test
176+
// TODO DEVSIX-9559 Fix align-content in case free space is negative
173177
public void rowRevAlignContentCenterWrapReverseTest() throws IOException, InterruptedException {
174178
convertToPdfAndCompare("rowRevAlignContentCenterWrapReverse", SOURCE_FOLDER, DESTINATION_FOLDER);
175179
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

src/test/resources/com/itextpdf/html2pdf/css/flex/FlexGapTest/colGapAlignContent.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
<div class="item">8</div>
6363
</div>
6464

65-
<!-- Incorrect layout on page split -->
6665
<div class="sample" style="align-content: space-between;">
6766
<div class="item">1</div>
6867
<div class="item">2</div>

0 commit comments

Comments
 (0)