Review orphaned TODOs in pdfHTML (5)

DEVSIX-6981

Author: Evgeniy Prudnikov

src/main/java/com/itextpdf/html2pdf/attach/impl/DefaultHtmlProcessor.java

@@ -431,20 +431,6 @@ private ITagWorker processRunningElement(ITagWorker tagWorker, IElementNode elem
             return tagWorker;
         }
 
-        // TODO For now the whole ITagWorker of the running element is preserved inside RunningElementContainer
-        // for the sake of future processing in page margin box. This is somewhat a workaround and storing
-        // tag workers might be easily seen as something undesirable, however at least for now it seems to be
-        // most suitable solution because:
-        // - in any case, processing of the whole running element with it's children should be done in
-        //   "normal flow", i.e. in DefaultHtmlProcessor, based on the spec that says that element should be
-        //   processed as it was still in the same position in DOM, but visually as if "display: none" was set.
-        // - the whole process would need to be repeated in PageContextProcessor again, so it's a double work;
-        //   also currently there is still no convenient way for unifying the processing here and in
-        //   PageContextProcessor, currently only running elements require processing of the whole hierarchy of
-        //   children outside of the default DOM processing and also it's unclear whether this code would be suitable
-        //   for the simplified approach of processing all other children of page margin boxes.
-        // - ITagWorker is only publicly passed to the constructor, but there is no exposed way to get it out of
-        //   RunningElementContainer, so it would be fairly easy to change this approach in future if needed.
         RunningElementContainer runningElementContainer = new RunningElementContainer(element, tagWorker);
         context.getCssContext().getRunningManager().addRunningElement(runningElemName, runningElementContainer);
 
@@ -455,7 +441,6 @@ private ITagWorker processRunningElement(ITagWorker tagWorker, IElementNode elem
      * Adds @font-face fonts to the FontProvider.
      */
     private void addFontFaceFonts() {
-        //TODO Shall we add getFonts() to ICssResolver?
         if (cssResolver instanceof DefaultCssResolver) {
             for (CssFontFaceRule fontFace : ((DefaultCssResolver) cssResolver).getFonts()) {
                 boolean findSupportedSrc = false;

src/main/java/com/itextpdf/html2pdf/attach/util/WaitingInlineElementsHelper.java

@@ -237,9 +237,7 @@ private Paragraph createLeavesContainer() {
                 }
             }
             if (runningElementsOnly) {
-                // TODO this might be avoided in future if we will come up with removing of completely empty
-                // (both in terms of content and possible properties like background and borders) tags from
-                // logical structure of resultant PDF documents
+                // TODO DEVSIX-7008 Remove completely empty tags from logical structure of resultant PDF documents
                 p.getAccessibilityProperties().setRole(StandardRoles.ARTIFACT);
             }
             return p;

src/main/java/com/itextpdf/html2pdf/css/apply/impl/PageMarginBoxCssApplier.java

@@ -131,7 +131,7 @@ public void apply(ProcessorContext context, IStylesContainer stylesContainer, IT
             marginBox.setProperty(Property.OVERFLOW_Y, OverflowPropertyValue.VISIBLE);
         }
 
-        // TODO outlines are currently not supported for page margin boxes, because of the outlines handling specificity (they are handled on renderer's parent level)
+        //TODO DEVSIX-7024 Support outlines for page margin boxes
         OutlineApplierUtil.applyOutlines(boxStyles, context, marginBox);
 
         marginBox.setProperty(Property.FONT_PROVIDER, context.getFontProvider());

src/main/java/com/itextpdf/html2pdf/css/apply/impl/SpanTagCssApplier.java

@@ -81,7 +81,7 @@ public void apply(ProcessorContext context, IStylesContainer stylesContainer, IT
         Map<String, String> cssStyles = stylesContainer.getStyles();
         for (IPropertyContainer child : spanTagWorker.getOwnLeafElements()) {
             // Workaround for form fields so that SpanTagCssApplier does not apply its font-size to the child.
-            // Form fields have their own CSS applier // TODO remove when form fields are not leaf elements anymore
+            // Form fields have their own CSS applier
             if (!(child instanceof IFormField)) {
                 applyChildElementStyles(child, cssStyles, context, stylesContainer);
             }