Deprecate VISIBLE and OVERFLOW in CssConstants

Deprecated in favour of the same constants in CommonCssConstants in Styled-Xml-parser

DEVSIX-2240

Author: Samuel Huylebroeck

src/main/java/com/itextpdf/html2pdf/attach/util/WaitingInlineElementsHelper.java

@@ -56,6 +56,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.element.ListItem;
 import com.itextpdf.layout.element.Paragraph;
 import com.itextpdf.layout.element.Text;
+import com.itextpdf.styledxmlparser.css.CommonCssConstants;
 import com.itextpdf.styledxmlparser.util.WhiteSpaceUtil;
 
 import java.util.ArrayList;
@@ -178,7 +179,7 @@ public void flushHangingLeaves(IPropertyContainer container) {
         Paragraph p = createLeavesContainer();
         if (p != null) {
             Map<String, String> map = new HashMap<>();
-            map.put(CssConstants.OVERFLOW, CssConstants.VISIBLE);
+            map.put(CssConstants.OVERFLOW, CommonCssConstants.VISIBLE);
             OverflowApplierUtil.applyOverflow(map, p);
             if (container instanceof Document) {
                 ((Document) container).add(p);

src/main/java/com/itextpdf/html2pdf/css/CssConstants.java

@@ -94,7 +94,8 @@ public class CssConstants extends CommonCssConstants {
     /** The Constant OUTLINE_OFFSET. */
     public static final String OUTLINE_OFFSET = "outline-offset";
 
-    /** The Constant OVERFLOW. */
+    /** The Constant OVERFLOW. @Deprecated in favour of CommonCssConstants.OVERFLOW */
+    @Deprecated
     public static final String OVERFLOW = "overflow";
 
     /** The Constant OVERFLOW_X. */
@@ -121,7 +122,10 @@ public class CssConstants extends CommonCssConstants {
     /** The Constant VERTICAL_ALIGN. */
     public static final String VERTICAL_ALIGN = "vertical-align";
 
-    /** The Constant VISIBLE. */
+    /** The Constant VISIBLE.
+     * @deprecated in favour of StyledXmlParser
+     */
+    @Deprecated
     public static final String VISIBLE = "visible";
 
     // property values
@@ -262,7 +266,7 @@ public class CssConstants extends CommonCssConstants {
 
     /** The Constant OVERFLOW_VALUES. */
     public static final Set<String> OVERFLOW_VALUES = new HashSet<>(
-            Arrays.asList(new String[] {VISIBLE, HIDDEN, SCROLL, AUTO}));
+            Arrays.asList(new String[] {CommonCssConstants.VISIBLE, HIDDEN, SCROLL, AUTO}));
 
     // pseudo-elements
 

src/test/java/com/itextpdf/html2pdf/css/PageRuleTest.java

@@ -63,6 +63,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.Document;
 import com.itextpdf.layout.element.Image;
 import com.itextpdf.layout.tagging.IAccessibleElement;
+import com.itextpdf.styledxmlparser.css.CommonCssConstants;
 import com.itextpdf.styledxmlparser.css.media.MediaDeviceDescription;
 import com.itextpdf.styledxmlparser.css.page.PageMarginBoxContextNode;
 import com.itextpdf.styledxmlparser.node.IElementNode;
@@ -267,7 +268,7 @@ private static class CustomOverflowPageMarginBoxCssApplier extends PageMarginBox
         public void apply(ProcessorContext context, IStylesContainer stylesContainer, ITagWorker tagWorker) {
             Map<String, String> styles = stylesContainer.getStyles();
             if (styles.get(CssConstants.OVERFLOW) == null) {
-                styles.put(CssConstants.OVERFLOW, CssConstants.VISIBLE);
+                styles.put(CssConstants.OVERFLOW, CommonCssConstants.VISIBLE);
             }
             super.apply(context, stylesContainer, tagWorker);
         }