Deprecate VISIBLE and OVERFLOW in CssConstants

Deprecated in favour of the same constants in CommonCssConstants in Styled-Xml-parser

DEVSIX-2240

Autoported commit.
Original commit hash: [09bbe640]

Author: Samuel Huylebroeck

itext.tests/itext.html2pdf.tests/itext/html2pdf/css/PageRuleTest.cs

@@ -57,6 +57,7 @@ source product.
 using iText.Layout;
 using iText.Layout.Element;
 using iText.Layout.Tagging;
+using iText.StyledXmlParser.Css;
 using iText.StyledXmlParser.Css.Media;
 using iText.StyledXmlParser.Css.Page;
 using iText.StyledXmlParser.Node;
@@ -243,7 +244,7 @@ public override void Apply(ProcessorContext context, IStylesContainer stylesCont
                 ) {
                 IDictionary<String, String> styles = stylesContainer.GetStyles();
                 if (styles.Get(CssConstants.OVERFLOW) == null) {
-                    styles.Put(CssConstants.OVERFLOW, CssConstants.VISIBLE);
+                    styles.Put(CssConstants.OVERFLOW, CommonCssConstants.VISIBLE);
                 }
                 base.Apply(context, stylesContainer, tagWorker);
             }

itext/itext.html2pdf/itext/html2pdf/attach/util/WaitingInlineElementsHelper.cs

@@ -49,6 +49,7 @@ source product.
 using iText.Kernel.Pdf.Tagging;
 using iText.Layout;
 using iText.Layout.Element;
+using iText.StyledXmlParser.Css;
 using iText.StyledXmlParser.Util;
 
 namespace iText.Html2pdf.Attach.Util {
@@ -151,7 +152,7 @@ public virtual void FlushHangingLeaves(IPropertyContainer container) {
             Paragraph p = CreateLeavesContainer();
             if (p != null) {
                 IDictionary<String, String> map = new Dictionary<String, String>();
-                map.Put(CssConstants.OVERFLOW, CssConstants.VISIBLE);
+                map.Put(CssConstants.OVERFLOW, CommonCssConstants.VISIBLE);
                 OverflowApplierUtil.ApplyOverflow(map, p);
                 if (container is Document) {
                     ((Document)container).Add(p);

itext/itext.html2pdf/itext/html2pdf/css/CssConstants.cs

@@ -90,6 +90,8 @@ public class CssConstants : CommonCssConstants {
         public const String OUTLINE_OFFSET = "outline-offset";
 
         /// <summary>The Constant OVERFLOW.</summary>
+        /// <remarks>The Constant OVERFLOW. @Deprecated in favour of CommonCssConstants.OVERFLOW</remarks>
+        [Obsolete]
         public const String OVERFLOW = "overflow";
 
         /// <summary>The Constant OVERFLOW_X.</summary>
@@ -117,6 +119,7 @@ public class CssConstants : CommonCssConstants {
         public const String VERTICAL_ALIGN = "vertical-align";
 
         /// <summary>The Constant VISIBLE.</summary>
+        [System.ObsoleteAttribute(@"in favour of StyledXmlParser")]
         public const String VISIBLE = "visible";
 
         // property values
@@ -254,7 +257,7 @@ public class CssConstants : CommonCssConstants {
 
         /// <summary>The Constant OVERFLOW_VALUES.</summary>
         public static readonly ICollection<String> OVERFLOW_VALUES = new HashSet<String>(JavaUtil.ArraysAsList(new 
-            String[] { VISIBLE, HIDDEN, SCROLL, AUTO }));
+            String[] { CommonCssConstants.VISIBLE, HIDDEN, SCROLL, AUTO }));
 
         // pseudo-elements
         /// <summary>The Constant AFTER.</summary>

port-hash

@@ -1 +1 @@
-908db288a1720230f09f1952879bd336e08d5606
+09bbe6400e33e289eebc0e77e94bd0719a581538