[RELEASE] iText 7 Core - 7.1.7

https://github.com/itext/itext7/releases/tag/7.1.7

* release/7.1.7:
  Ignore tests related to SNAPSHOT being written to extracted images.
  [RELEASE] 7.1.7-SNAPSHOT -> 7.1.7
  Deprecate duplicate methods
  Documentation and binary compatibility loose ends
  Add missing copyright headers
  Add log messages handler in svg
  Add setFont3Ways test
  Update javadoc for PdfFormField#drawButton()
  Fix bytes retrieval from pdf byte string during PdfEncryption init
  Add missing copyright headers
  Fix smart-mode serialization content cluttering by internal buffer out-of-range bytes
  Make explicit fallback to zero more focused when NaN is attempted to be written
  Add new test for #setPage method of PdfFormField
  Moved Pkcs12FileHelper from sign module to pdftest module.
  Exclude modules pdftest, font-asian and hyph from SonarQube analysis
  Add missing copyright headers
  Implement disabled pseudo class selector. Minor refactoring.
  Add missing copyright headers
  SVG: Support floating numbers with exponent notation in path painting instructions
  Restore src and cmp in test
  Implement memory limits aware handler. Filter some SpotBugs expections.
  Change PdfDocument id generation process
  Add System out println for compare Xmls method
  Explicitly fallback to zero when NaN is attempted to be written
  Make PdfImageXObject more independent of underlying object flushing
  Implement PageFlushingHelper for deep page structure flushing/releasing
  Do not skip spotbugs run in the test profile
  Add one more FormField test with Noto
  Use pure declarative syntax in the Jenkinsfile
  Fix poosible issue with incorrect DA
  Compare Sonar analysis to develop instead of master for other branches than master and develop
  Add a test which demonstrates margin-collapse processing with a custom renderer.
  Syncronize DA and DR. Retrieve FormField's font.
  SVG: Switch to PX as a default font-size metric. Update cmps.
  Do not fail if the appearance dictionary doesn't contain N entry.
  Add missing copyright headers
  Add new unit test for testig Pattern.split functionality in Java
  Add a getter for a set of fields for flattening in PdfAcroForm
  Remove invalid determinig of transparency on the page
  Fix Matrix.toString()
  Unify names of some tests and resources.
  Add some new SVG tests for preserveAspectRatio attribute.
  Add new test that demonstrates bug of PdfReader locking the file when exception occurred during parsing
  Fix color setting when colorspace needs to be kept
  Fix close-path operator not being applied
  Fixup for TestCrlClient making it reusable and more verbose
  Resolve styles of SVG tag. Add a test.
  Rotate signature's appearance if page is rotated. Add some new tests.
  Remove unpredictably failing test.
  Process scale transformation values correctly. Add some new tests.
  Fix XMP dc:subject property value type
  Reuse pdfHTML's font-size resolution algorithms. Minor refactoring.
  Remove unnecessary Verdana font-family usage from test svgs.
  Fix DataMatrix barcode porting bug
  Fix Unicode characters
  Resolve URL containing in xlink:href attribute of SVG against baseURL
  Remove unused test resources
  Add additional file types to .gitattributes
  Skip SpotBugs in Artifactory Deploy stage
  Run SonarQube from Jenkinsfile
  Unify text offset pattern for all justification cases
  Avoid adding new indirect references to the xref table when its already completely read
  Run install goal instead of package goal in Artifactory upload phase
  [RELEASE] 7.1.6-SNAPSHOT -> 7.1.7-SNAPSHOT

Author: iText-CI

.gitattributes

@@ -5,39 +5,57 @@
 # to LF line endings on checkout.
 *.afm text eol=lf
 *.cmap text eol=lf
-*.crt text eol=lf
-*.cs text eol=lf
+*.cs text eol=lf ident
+*.css text eol=lf
+*.htm text eol=lf
 *.html text eol=lf
 *.java text eol=lf ident
 *.lng text eol=lf
 *.md text eol=lf
 *.pom text eol=lf
 *.properties text eol=lf
+*.svg text eol=lf
 *.txt text eol=lf
 *.xfdf text eol=lf
+*.xht text eol=lf
+*.xhtml text eol=lf
 *.xml text eol=lf
+port-hash text eol=lf
 
 # Declare files that will always have CRLF line endings on checkout.
 *.bat text eol=crlf
 *.csproj text eol=crlf
 *.sln text eol=crlf
 
 # Denote all files that are truly binary and should not be modified.
+*.aif binary
+*.aiff binary
 *.bmp binary
+*.cer binary
 *.cmp binary
+*.crt binary
 *.dib binary
 *.gif binary
+*.icc binary
 *.j2k binary
 *.jb2 binary
 *.jp2 binary
+*.jpc binary
 *.jpg binary
 *.key binary
 *.otf binary
+*.p12 binary
 *.pdf binary
 *.pfb binary
+*.pfm binary
 *.png binary
+*.snd binary
 *.tif binary
 *.tiff binary
 *.ttc binary
 *.ttf binary
+*.u3d binary
+*.wav binary
 *.wmf binary
+*.woff binary
+*.woff2 binary

Jenkinsfile

@@ -11,7 +11,6 @@ pipeline {
     options {
         ansiColor('xterm')
         buildDiscarder(logRotator(artifactNumToKeepStr: '1'))
-        compressBuildLog()
         parallelsAlwaysFailFast()
         retry(1)
         skipStagesAfterUnstable()
@@ -50,25 +49,16 @@ pipeline {
             }
         }
         stage('Run Tests') {
-            stages {
-                stage('Surefire (Unit Tests)') {
-                    options {
-                        timeout(time: 30, unit: 'MINUTES')
-                    }
-                    steps {
-                        withMaven(jdk: "${JDK_VERSION}", maven: 'M3') {
-                            sh 'mvn --activate-profiles test test -DgsExec="${gsExec}" -DcompareExec="${compareExec}" -Dmaven.test.skip=false'
-                        }
-                    }
-                }
-                stage('Failsafe (Integration Tests)') {
-                    options {
-                        timeout(time: 30, unit: 'MINUTES')
-                    }
-                    steps {
-                        withMaven(jdk: "${JDK_VERSION}", maven: 'M3') {
-                            sh 'mvn --activate-profiles test verify -DgsExec="${gsExec}" -DcompareExec="${compareExec}" -Dmaven.test.skip=false -Dmaven.javadoc.skip=true'
-                        }
+            options {
+                timeout(time: 30, unit: 'MINUTES')
+            }
+            environment {
+                SONAR_BRANCH_TARGET= sh (returnStdout: true, script: '[ $BRANCH_NAME = master ] && echo master || echo develop').trim()
+            }
+            steps {
+                withMaven(jdk: "${JDK_VERSION}", maven: 'M3') {
+                    withSonarQubeEnv('Sonar') {
+                        sh 'mvn --activate-profiles test test verify org.jacoco:jacoco-maven-plugin:prepare-agent org.jacoco:jacoco-maven-plugin:report sonar:sonar -DgsExec="${gsExec}" -DcompareExec="${compareExec}" -Dmaven.test.skip=false -Dmaven.test.failure.ignore=false -Dmaven.javadoc.skip=true -Dsonar.branch.name="${BRANCH_NAME}" -Dsonar.branch.target="${SONAR_BRANCH_TARGET}"'
                     }
                 }
             }
@@ -83,6 +73,13 @@ pipeline {
                 }
             }
         }
+        stage("Quality Gate") {
+            steps {
+                timeout(time: 1, unit: 'HOURS') {
+                    waitForQualityGate abortPipeline: true
+                }
+            }
+        }
         stage('Artifactory Deploy') {
             options {
                 timeout(time: 5, unit: 'MINUTES')
@@ -101,7 +98,7 @@ pipeline {
                     def rtMaven = Artifactory.newMavenBuild()
                     rtMaven.deployer server: server, releaseRepo: 'releases', snapshotRepo: 'snapshot'
                     rtMaven.tool = 'M3'
-                    def buildInfo = rtMaven.run pom: 'pom.xml', goals: 'package -Dmaven.test.skip=true -Dmaven.javadoc.failOnError=false'
+                    def buildInfo = rtMaven.run pom: 'pom.xml', goals: 'install -Dmaven.test.skip=true -Dspotbugs.skip=true -Dmaven.javadoc.failOnError=false'
                     server.publishBuildInfo buildInfo
                 }
             }

barcodes/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.6</version>
+    <version>7.1.7</version>
   </parent>
   <artifactId>barcodes</artifactId>
   <name>iText 7 - barcodes</name>

barcodes/src/main/java/com/itextpdf/barcodes/BarcodeDataMatrix.java

@@ -1050,7 +1050,7 @@ private int C40OrTextEncodation(byte[] text, int textOffset, int textLength, byt
                     for (i = unlatch + 1; i < dataOffset; i++) {
                         if (data[i] == EXTENDED_ASCII)
                             i++;
-                        if (data[i] >= -127 && data[i] <= -27)
+                        if (data[i] >= (byte) 129 && data[i] <= (byte) 229)
                             amountOfEncodedWithASCII++;
                         amountOfEncodedWithASCII++;
                     }

barcodes/src/test/java/com/itextpdf/barcodes/BarcodeDataMatrixTest.java

@@ -52,29 +52,28 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
+import java.io.IOException;
 import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.junit.rules.ExpectedException;
 
-import java.io.IOException;
-
 @Category(IntegrationTest.class)
 public class BarcodeDataMatrixTest extends ExtendedITextTest {
 
-    public static final String sourceFolder = "./src/test/resources/com/itextpdf/barcodes/";
     public static final String destinationFolder = "./target/test/com/itextpdf/barcodes/BarcodeDataMatrix/";
+    public static final String sourceFolder = "./src/test/resources/com/itextpdf/barcodes/";
+
+    @Rule
+    public ExpectedException junitExpectedException = ExpectedException.none();
 
     @BeforeClass
     public static void beforeClass() {
         createOrClearDestinationFolder(destinationFolder);
     }
 
-    @Rule
-    public ExpectedException junitExpectedException = ExpectedException.none();
-    
     @Test
     public void barcode01Test() throws IOException, PdfException, InterruptedException {
         String filename = "barcodeDataMatrix.pdf";
@@ -271,4 +270,19 @@ public void barcode15Test() {
         int result = barcodeDataMatrix.setCode(str, str.length, 0);
         Assert.assertEquals(BarcodeDataMatrix.DM_NO_ERROR, result);
     }
+
+    @Test
+    public void barcode16Test() throws IOException, PdfException, InterruptedException {
+        String filename = "barcode16Test.pdf";
+        PdfDocument document = new PdfDocument(new PdfWriter(destinationFolder + filename));
+
+        PdfCanvas canvas = new PdfCanvas(document.addNewPage());
+        BarcodeDataMatrix barcode = new BarcodeDataMatrix();
+        barcode.setCode("999999DILLERT XANG LIMITON 18               000");
+        canvas.concatMatrix(1, 0, 0, 1, 100, 600);
+        barcode.placeBarcode(canvas, ColorConstants.BLACK, 3);
+        document.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + filename, sourceFolder + "cmp_" + filename, destinationFolder));
+    }
 }

barcodes/src/test/resources/com/itextpdf/barcodes/cmp_barcode16Test.pdf

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.6</version>
+    <version>7.1.7</version>
   </parent>
   <artifactId>font-asian</artifactId>
   <name>iText 7 - Asian fonts</name>
@@ -15,6 +15,9 @@
       <name>Various licenses (see individual files)</name>
     </license>
   </licenses>
+  <properties>
+    <sonar.skip>true</sonar.skip>
+  </properties>
   <build>
     <plugins>
       <plugin>

font-asian/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.6</version>
+    <version>7.1.7</version>
   </parent>
   <artifactId>forms</artifactId>
   <name>iText 7 - forms</name>
@@ -20,6 +20,12 @@
       <artifactId>layout</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>com.itextpdf</groupId>
+      <artifactId>font-asian</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>com.itextpdf</groupId>
       <artifactId>pdftest</artifactId>