Fix Names PdfObject not being marked as modified in append mode

Fix Names PdfObject present in Catalog not being marked as modified in append mode when adding embedded files, when the Names object was present already and indirect.
Fix capitalization in tests

DEVSIX-2826

Author: Samuel Huylebroeck

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDocument.java

@@ -2251,6 +2251,7 @@ private void ensureTreeRootAddedToNames(PdfObject treeRoot, PdfName treeType) {
             names.makeIndirect(this);
         }
         names.put(treeType, treeRoot);
+        names.setModified();
     }
 
     private static boolean isXmpMetaHasProperty(XMPMeta xmpMeta, String schemaNS, String propName) throws XMPException {

kernel/src/test/java/com/itextpdf/kernel/pdf/PdfNameTreeTest.java

@@ -48,6 +48,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.geom.Rectangle;
 import com.itextpdf.kernel.pdf.annot.PdfAnnotationAppearance;
 import com.itextpdf.kernel.pdf.canvas.PdfCanvas;
+import com.itextpdf.kernel.pdf.filespec.PdfFileSpec;
 import com.itextpdf.kernel.pdf.xobject.PdfFormXObject;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
@@ -56,6 +57,8 @@ This file is part of the iText (R) project.
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.util.Map;
 
@@ -71,7 +74,7 @@ public static void beforeClass() {
     }
 
     @Test
-    public void EmbeddedFileAndJavascriptTest() throws IOException {
+    public void embeddedFileAndJavascriptTest() throws IOException {
         PdfDocument pdfDocument = new PdfDocument(new PdfReader(sourceFolder + "FileWithSingleAttachment.pdf"));
         PdfNameTree embeddedFilesNameTree = pdfDocument.getCatalog().getNameTree(PdfName.EmbeddedFiles);
         Map<String, PdfObject> objs = embeddedFilesNameTree.getNames();
@@ -83,7 +86,47 @@ public void EmbeddedFileAndJavascriptTest() throws IOException {
     }
 
     @Test
-    public void AnnotationAppearanceTest() throws IOException {
+    public void embeddedFileAddedInAppendModeTest() throws  IOException{
+        //Create input document
+        ByteArrayOutputStream boasEmpty = new ByteArrayOutputStream();
+        PdfWriter emptyDocWriter = new PdfWriter(boasEmpty);
+        PdfDocument emptyDoc = new PdfDocument(emptyDocWriter);
+        emptyDoc.addNewPage();
+        PdfDictionary emptyNamesDic = new PdfDictionary();
+        emptyNamesDic.makeIndirect(emptyDoc);
+        emptyDoc.getCatalog().getPdfObject().put(PdfName.Names,emptyNamesDic);
+
+        emptyDoc.close();
+
+        //Create input document
+        ByteArrayOutputStream boasAttached = new ByteArrayOutputStream();
+        PdfWriter attachDocWriter = new PdfWriter(boasAttached);
+        PdfDocument attachDoc = new PdfDocument(attachDocWriter);
+        attachDoc.addNewPage();
+        attachDoc.close();
+
+        //Attach file in append mode
+        PdfReader appendReader = new PdfReader(new ByteArrayInputStream(boasEmpty.toByteArray()));
+        ByteArrayOutputStream boasAppend = new ByteArrayOutputStream();
+        PdfWriter appendWriter = new PdfWriter(boasAppend);
+        PdfDocument appendDoc = new PdfDocument(appendReader,appendWriter,new StampingProperties().useAppendMode());
+
+        appendDoc.addFileAttachment("Test File", PdfFileSpec.createEmbeddedFileSpec(appendDoc,boasAttached.toByteArray(),"Append Embedded File test","Test file",null));
+        appendDoc.close();
+
+        //Check final result
+        PdfReader finalReader = new PdfReader(new ByteArrayInputStream(boasAppend.toByteArray()));
+        PdfDocument finalDoc = new PdfDocument(finalReader);
+
+        PdfNameTree embeddedFilesNameTree = finalDoc.getCatalog().getNameTree(PdfName.EmbeddedFiles);
+        Map<String, PdfObject> embeddedFilesMap = embeddedFilesNameTree.getNames();
+
+        Assert.assertTrue(embeddedFilesMap.size()>0);
+        Assert.assertTrue(embeddedFilesMap.containsKey("Test File"));
+    }
+
+    @Test
+    public void annotationAppearanceTest() throws IOException {
         PdfDocument pdfDocument = new PdfDocument(new PdfWriter(destinationFolder + "AnnotationAppearanceTest.pdf"));
         PdfPage page = pdfDocument.addNewPage();
         PdfCanvas canvas = new PdfCanvas(page);