Fix for UnsupportedOperationException if AreaBreak is inside inline-block

DEVSIX-9001

Author: Dmitry Radchuk

layout/src/main/java/com/itextpdf/layout/renderer/LineRenderer.java

@@ -672,7 +672,11 @@ && hasChildRendererInHtmlMode()) {
                     result = new LineLayoutResult(LayoutResult.PARTIAL, occupiedArea, split[0],
                             split[1], causeOfNothing);
                 } else {
-                    result = new LineLayoutResult(LayoutResult.NOTHING, null, null, split[1], null);
+                    //Passing any cause of nothing here breaks RootRenderer#tryDisableKeepTogether logic, since it
+                    //traverses over causeOfNothing parents and those are invalidated at ParagraphRenderer level, so
+                    //in such a case we want ParagraphRenderer to be set as a causeOfNothing
+                    result = new LineLayoutResult(LayoutResult.NOTHING, null, null, split[1],
+                            causeOfNothing instanceof AreaBreakRenderer ? causeOfNothing : null);
                 }
                 result.setFloatsOverflowedToNextPage(floatsToNextPageOverflowRenderers);
                 if (newLineOccurred) {

layout/src/main/java/com/itextpdf/layout/renderer/ParagraphRenderer.java

@@ -416,7 +416,8 @@ protected LayoutResult directLayout(LayoutContext layoutContext) {
                                 }
                             } else {
                                 floatRendererAreas.retainAll(nonChildFloatingRendererAreas);
-                                return new MinMaxWidthLayoutResult(LayoutResult.NOTHING, null, null, this, null == result.getCauseOfNothing() ? this : result.getCauseOfNothing());
+                                IRenderer overflowRenderer = result.getCauseOfNothing() instanceof AreaBreakRenderer ? split[1] : this;
+                                return new MinMaxWidthLayoutResult(LayoutResult.NOTHING, null, null, overflowRenderer, null == result.getCauseOfNothing() ? this : result.getCauseOfNothing());
                             }
                         }
                     }

layout/src/main/java/com/itextpdf/layout/tagging/ProhibitedTagRelationsResolver.java

@@ -28,6 +28,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.tagutils.IRoleMappingResolver;
 import com.itextpdf.kernel.pdf.tagutils.PdfAllowedTagRelations;
 import com.itextpdf.kernel.pdf.tagutils.TagStructureContext;
+import com.itextpdf.layout.renderer.AreaBreakRenderer;
 import com.itextpdf.layout.renderer.IRenderer;
 
 import java.util.Arrays;
@@ -112,6 +113,9 @@ public void repairTagStructure(LayoutTaggingHelper taggingHelper, IRenderer topR
         }
         final String normalizedParentRole = resolveToFinalRole(taggingHelper, currentThk, false);
         for (IRenderer childRenderer : topRender.getChildRenderers()) {
+            if (childRenderer instanceof AreaBreakRenderer) {
+                continue;
+            }
             final TaggingHintKey kid = LayoutTaggingHelper.getOrCreateHintKey(childRenderer);
             if (!kid.isAccessible()) {
                 continue;

layout/src/test/java/com/itextpdf/layout/AreaBreakTest.java

@@ -35,6 +35,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.properties.AreaBreakType;
 import com.itextpdf.layout.renderer.DivRenderer;
 import com.itextpdf.layout.renderer.IRenderer;
+import com.itextpdf.layout.tagging.ProhibitedTagRelationsResolver;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.TestUtil;
 
@@ -239,6 +240,20 @@ public void areaBreakInsideDiv04Test() throws IOException, InterruptedException
         Assertions.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder, "diff"));
     }
 
+    @Test
+    public void areaBreakInsideDivInTaggedDocumentTest() throws IOException, InterruptedException {
+        String outFileName = destinationFolder + "areaBreakInsideDivInTaggedDocument.pdf";
+        String cmpFileName = sourceFolder + "cmp_areaBreakInsideDivInTaggedDocument.pdf";
+        PdfDocument pdfDocument = new PdfDocument(new PdfWriter(outFileName));
+        pdfDocument.setTagged();
+        pdfDocument.getDiContainer().register(ProhibitedTagRelationsResolver.class, new ProhibitedTagRelationsResolver(pdfDocument));
+        Document document = new Document(pdfDocument);
+        Div div = new Div().add(new AreaBreak()).add(new Div().add(new Paragraph("test")));
+        document.add(div);
+        document.close();
+        Assertions.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder, "diff"));
+    }
+
     private static class DivRendererWithAreas extends DivRenderer {
 
         public DivRendererWithAreas(Div modelElement) {

layout/src/test/java/com/itextpdf/layout/InlineBlockTest.java

@@ -31,10 +31,13 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.layout.borders.DashedBorder;
 import com.itextpdf.layout.borders.SolidBorder;
+import com.itextpdf.layout.element.AnonymousInlineBox;
+import com.itextpdf.layout.element.AreaBreak;
 import com.itextpdf.layout.element.Cell;
 import com.itextpdf.layout.element.Div;
 import com.itextpdf.layout.element.Paragraph;
 import com.itextpdf.layout.element.Table;
+import com.itextpdf.layout.logs.LayoutLogMessageConstant;
 import com.itextpdf.layout.properties.FloatPropertyValue;
 import com.itextpdf.layout.properties.OverflowPropertyValue;
 import com.itextpdf.layout.properties.Property;
@@ -43,6 +46,9 @@ This file is part of the iText (R) project.
 import com.itextpdf.test.TestUtil;
 
 import java.io.IOException;
+
+import com.itextpdf.test.annotations.LogMessage;
+import com.itextpdf.test.annotations.LogMessages;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Tag;
@@ -173,4 +179,21 @@ public void wrappingAfter100PercentWidthFloatTest() throws IOException, Interrup
 
         Assertions.assertNull(new CompareTool().compareByContent(output, cmp, destinationFolder));
     }
+
+    @LogMessages(messages = {@LogMessage(messageTemplate = LayoutLogMessageConstant.ELEMENT_DOES_NOT_FIT_AREA)})
+    @Test
+    public void areaBreakWithinInlineBlockTest() throws IOException, InterruptedException {
+        String name = "areaBreakWithinInlineBlockTest.pdf";
+        String output = destinationFolder + name;
+        String cmp = sourceFolder + "cmp_" + name;
+        try (Document doc = new Document(new PdfDocument(new PdfWriter(output)))) {
+            AnonymousInlineBox root = new AnonymousInlineBox();
+            Div container = new Div();
+            container.add(new AreaBreak());
+            container.add(new Paragraph("test"));
+            root.add(container);
+            doc.add(root);
+        }
+        Assertions.assertNull(new CompareTool().compareByContent(output, cmp, destinationFolder));
+    }
 }