Fix NPE in PdfDocument.getFont with direct font

DEVSIX-3499

Autoported commit.
Original commit hash: [a734801d8]

Author: BezrukovM

itext.tests/itext.forms.tests/resources/itext/forms/PdfFormFieldMultilineTextTest/cmp_multilineFormFieldNewLineFontType3Test.pdf

@@ -22,6 +22,7 @@ You should have received a copy of the GNU Affero General Public License
 */
 using System;
 using iText.IO.Font.Otf;
+using iText.IO.Util;
 using iText.Kernel;
 using iText.Kernel.Pdf;
 using iText.Test;
@@ -43,7 +44,7 @@ public virtual void AddDifferentGlyphsInConstructorTest() {
             dictionary.Put(PdfName.Widths, new PdfArray());
             dictionary.Put(PdfName.ToUnicode, PdfName.IdentityH);
             dictionary.Put(PdfName.Encoding, new PdfName("zapfdingbatsencoding"));
-            PdfType3Font type3Font = new _PdfType3Font_64(dictionary);
+            PdfType3Font type3Font = new _PdfType3Font_65(dictionary);
             NUnit.Framework.Assert.IsNotNull(type3Font.GetFontProgram());
             int spaceGlyphCode = 32;
             Glyph glyph = type3Font.GetFontProgram().GetGlyph(spaceGlyphCode);
@@ -53,8 +54,8 @@ public virtual void AddDifferentGlyphsInConstructorTest() {
             NUnit.Framework.Assert.AreEqual(new Glyph(AGlyphCode, 0, new char[] { 'A' }), glyph);
         }
 
-        private sealed class _PdfType3Font_64 : PdfType3Font {
-            public _PdfType3Font_64(PdfDictionary baseArg1)
+        private sealed class _PdfType3Font_65 : PdfType3Font {
+            public _PdfType3Font_65(PdfDictionary baseArg1)
                 : base(baseArg1) {
             }
 
@@ -72,7 +73,7 @@ public virtual void AddAlreadyExistingGlyphTest() {
             charProcs.Put(new PdfName("A"), new PdfStream());
             dictionary.Put(PdfName.CharProcs, charProcs);
             dictionary.Put(PdfName.Widths, new PdfArray());
-            PdfType3Font type3Font = new _PdfType3Font_89(dictionary);
+            PdfType3Font type3Font = new _PdfType3Font_90(dictionary);
             Type3Glyph type3Glyph = type3Font.AddGlyph('A', 1, 2, 3, 5, 8);
             NUnit.Framework.Assert.AreEqual(0, type3Glyph.GetWx(), EPS);
             NUnit.Framework.Assert.AreEqual(0, type3Glyph.GetLlx(), EPS);
@@ -81,8 +82,8 @@ public virtual void AddAlreadyExistingGlyphTest() {
             NUnit.Framework.Assert.AreEqual(0, type3Glyph.GetUry(), EPS);
         }
 
-        private sealed class _PdfType3Font_89 : PdfType3Font {
-            public _PdfType3Font_89(PdfDictionary baseArg1)
+        private sealed class _PdfType3Font_90 : PdfType3Font {
+            public _PdfType3Font_90(PdfDictionary baseArg1)
                 : base(baseArg1) {
             }
 
@@ -143,7 +144,7 @@ public virtual void ContainsGlyphTest() {
             PdfDictionary charProcs = new PdfDictionary();
             dictionary.Put(PdfName.CharProcs, charProcs);
             dictionary.Put(PdfName.Widths, new PdfArray());
-            PdfType3Font type3Font = new _PdfType3Font_159(dictionary);
+            PdfType3Font type3Font = new _PdfType3Font_160(dictionary);
             NUnit.Framework.Assert.IsFalse(type3Font.ContainsGlyph(333));
             NUnit.Framework.Assert.IsFalse(type3Font.ContainsGlyph(-5));
             NUnit.Framework.Assert.IsFalse(type3Font.ContainsGlyph(32));
@@ -153,8 +154,8 @@ public virtual void ContainsGlyphTest() {
             NUnit.Framework.Assert.IsTrue(type3Font.ContainsGlyph(65));
         }
 
-        private sealed class _PdfType3Font_159 : PdfType3Font {
-            public _PdfType3Font_159(PdfDictionary baseArg1)
+        private sealed class _PdfType3Font_160 : PdfType3Font {
+            public _PdfType3Font_160(PdfDictionary baseArg1)
                 : base(baseArg1) {
             }
 
@@ -192,14 +193,14 @@ public virtual void FillFontDescriptorTest() {
             String fontStretch = "test";
             fontDescriptor.Put(PdfName.FontStretch, new PdfName(fontStretch));
             dictionary.Put(PdfName.FontDescriptor, fontDescriptor);
-            PdfType3Font type3Font = new _PdfType3Font_202(dictionary);
+            PdfType3Font type3Font = new _PdfType3Font_203(dictionary);
             NUnit.Framework.Assert.IsNotNull(type3Font.fontProgram);
             NUnit.Framework.Assert.IsNotNull(type3Font.fontProgram.GetFontNames());
             NUnit.Framework.Assert.AreEqual(fontStretch, type3Font.fontProgram.GetFontNames().GetFontStretch());
         }
 
-        private sealed class _PdfType3Font_202 : PdfType3Font {
-            public _PdfType3Font_202(PdfDictionary baseArg1)
+        private sealed class _PdfType3Font_203 : PdfType3Font {
+            public _PdfType3Font_203(PdfDictionary baseArg1)
                 : base(baseArg1) {
             }
 
@@ -241,6 +242,34 @@ public virtual void NoDifferenceTest() {
             NUnit.Framework.Assert.DoesNotThrow(() => new PdfType3Font(dictionary));
         }
 
+        [NUnit.Framework.Test]
+        [LogMessage(iText.IO.LogMessageConstant.TYPE3_FONT_INITIALIZATION_ISSUE)]
+        public virtual void MissingFontMatrixTest() {
+            PdfDictionary dictionary = new PdfDictionary();
+            dictionary.Put(PdfName.Widths, new PdfArray());
+            dictionary.Put(PdfName.ToUnicode, PdfName.IdentityH);
+            dictionary.Put(PdfName.Encoding, new PdfName("zapfdingbatsencoding"));
+            NUnit.Framework.Assert.That(() =>  {
+                new PdfType3Font(dictionary);
+            }
+            , NUnit.Framework.Throws.InstanceOf<PdfException>().With.Message.EqualTo(MessageFormatUtil.Format(PdfException.MissingRequiredFieldInFontDictionary, PdfName.FontMatrix)))
+;
+        }
+
+        [NUnit.Framework.Test]
+        [LogMessage(iText.IO.LogMessageConstant.TYPE3_FONT_INITIALIZATION_ISSUE)]
+        public virtual void MissingWidthsTest() {
+            PdfDictionary dictionary = new PdfDictionary();
+            dictionary.Put(PdfName.FontMatrix, new PdfArray());
+            dictionary.Put(PdfName.ToUnicode, PdfName.IdentityH);
+            dictionary.Put(PdfName.Encoding, new PdfName("zapfdingbatsencoding"));
+            NUnit.Framework.Assert.That(() =>  {
+                new PdfType3Font(dictionary);
+            }
+            , NUnit.Framework.Throws.InstanceOf<PdfException>().With.Message.EqualTo(MessageFormatUtil.Format(PdfException.MissingRequiredFieldInFontDictionary, PdfName.Widths)))
+;
+        }
+
         [NUnit.Framework.Test]
         public virtual void NoCharProcGlyphForDifferenceTest() {
             PdfDictionary font = new PdfDictionary();

itext.tests/itext.kernel.tests/itext/kernel/font/PdfType3FontTest.cs

@@ -44,13 +44,39 @@ source product.
 using System;
 using System.Collections.Generic;
 using System.IO;
+using iText.IO.Font;
 using iText.IO.Source;
+using iText.Kernel.Font;
 using iText.Kernel.Pdf.Layer;
 using iText.Test;
 using iText.Test.Attributes;
 
 namespace iText.Kernel.Pdf {
     public class PdfDocumentUnitTest : ExtendedITextTest {
+        [NUnit.Framework.Test]
+        [LogMessage(iText.IO.LogMessageConstant.TYPE3_FONT_INITIALIZATION_ISSUE)]
+        public virtual void GetFontWithDirectFontDictionaryTest() {
+            PdfDictionary initialFontDict = new PdfDictionary();
+            initialFontDict.Put(PdfName.Subtype, PdfName.Type3);
+            initialFontDict.Put(PdfName.FontMatrix, new PdfArray(new float[] { 0.001F, 0, 0, 0.001F, 0, 0 }));
+            initialFontDict.Put(PdfName.Widths, new PdfArray());
+            PdfDictionary encoding = new PdfDictionary();
+            initialFontDict.Put(PdfName.Encoding, encoding);
+            PdfArray differences = new PdfArray();
+            differences.Add(new PdfNumber(AdobeGlyphList.NameToUnicode("a")));
+            differences.Add(new PdfName("a"));
+            encoding.Put(PdfName.Differences, differences);
+            NUnit.Framework.Assert.IsNull(initialFontDict.GetIndirectReference());
+            using (PdfDocument doc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()))) {
+                // prevent no pages exception on close
+                doc.AddNewPage();
+                PdfType3Font font1 = (PdfType3Font)doc.GetFont(initialFontDict);
+                NUnit.Framework.Assert.IsNotNull(font1);
+                // prevent no glyphs for type3 font on close
+                font1.AddGlyph('a', 0, 0, 0, 0, 0);
+            }
+        }
+
         [NUnit.Framework.Test]
         public virtual void CopyPagesWithOCGDifferentNames() {
             IList<IList<String>> ocgNames = new List<IList<String>>();