Merge pull request #17633 from iterate-ch/bugfix/GH-17620

dkocher · web-flow · commit afd87988165d · 2025-11-15T18:27:06.000+01:00
Handle parser failures as interoperability error.
diff --git a/onedrive/pom.xml b/onedrive/pom.xml
@@ -23,7 +23,7 @@
     </parent>
     <artifactId>onedrive</artifactId>
     <properties>
-        <onedrive-java-client-version>3.2.4</onedrive-java-client-version>
+        <onedrive-java-client-version>3.3.0</onedrive-java-client-version>
     </properties>
     <dependencies>
         <dependency>
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/AbstractSharepointSession.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/AbstractSharepointSession.java
@@ -31,6 +31,7 @@
 import org.apache.commons.lang3.StringUtils;
 import org.nuxeo.onedrive.client.ODataQuery;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.Drive;
 import org.nuxeo.onedrive.client.types.DriveItem;
 import org.nuxeo.onedrive.client.types.GroupItem;
@@ -115,11 +116,14 @@ public DriveItem getItem(final Path file, final boolean resolveLastItem) throws
                     return (DriveItem) remoteMetadata.getItem();
                 }
             }
-            catch(OneDriveAPIException oneDriveAPIException) {
-                throw new GraphExceptionMappingService(fileid).map(oneDriveAPIException);
+            catch(OneDriveAPIException e) {
+                throw new GraphExceptionMappingService(fileid).map(e);
             }
-            catch(IOException ioException) {
-                throw new DefaultIOExceptionMappingService().map(ioException);
+            catch(IOException e) {
+                throw new DefaultIOExceptionMappingService().map(e);
+            }
+            catch(OneDriveRuntimeException e) {
+                throw new GraphExceptionMappingService(fileid).map(e.getCause());
             }
         }
         return ownItem;
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/GraphSession.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/GraphSession.java
@@ -51,6 +51,7 @@
 import org.nuxeo.onedrive.client.ODataQuery;
 import org.nuxeo.onedrive.client.OneDriveAPI;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.RequestExecutor;
 import org.nuxeo.onedrive.client.RequestHeader;
 import org.nuxeo.onedrive.client.Users;
@@ -229,6 +230,9 @@ public void login(final LoginCallback prompt, final CancelCallback cancel) throw
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map(e);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map(e.getCause());
+        }
     }
 
     @Override
@@ -295,7 +299,7 @@ public <T> T _getFeature(final Class<T> type) {
             return (T) new GraphUrlProvider();
         }
         if(type == Share.class) {
-            return (T) new GraphSharedLinkFeature(this);
+            return (T) new GraphSharedLinkFeature(this, fileid);
         }
         if(type == Versioning.class) {
             return (T) new GraphVersioningFeature(this, fileid);
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphAttributesFinderFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphAttributesFinderFeature.java
@@ -30,6 +30,7 @@
 
 import org.apache.commons.lang3.StringUtils;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 import org.nuxeo.onedrive.client.types.DriveItemVersion;
 import org.nuxeo.onedrive.client.types.File;
@@ -85,6 +86,9 @@ private DriveItem.Metadata toMetadata(final Path file, final DriveItem item) thr
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Failure to read attributes of {0}", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to read attributes of {0}", e.getCause(), file);
+        }
     }
 
     @Override
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphCopyFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphCopyFeature.java
@@ -35,6 +35,7 @@
 import org.nuxeo.onedrive.client.CopyOperation;
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
@@ -88,6 +89,9 @@ public Path copy(final Path file, final Path target, final TransferStatus status
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Cannot copy {0}", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Cannot copy {0}", e.getCause(), file);
+        }
     }
 
     @Override
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphDeleteFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphDeleteFeature.java
@@ -28,6 +28,7 @@
 
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
@@ -60,6 +61,9 @@ public void delete(final Map<Path, TransferStatus> files, final PasswordCallback
             catch(IOException e) {
                 throw new DefaultIOExceptionMappingService().map("Cannot delete {0}", e, file);
             }
+            catch(OneDriveRuntimeException e) {
+                throw new GraphExceptionMappingService(fileid).map("Cannot delete {0}", e.getCause(), file);
+            }
         }
     }
 
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphDirectoryFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphDirectoryFeature.java
@@ -29,6 +29,7 @@
 
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
@@ -61,6 +62,9 @@ public Path mkdir(final Write<DriveItem.Metadata> writer, final Path directory,
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Cannot create folder {0}", e, directory);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Cannot create folder {0}", e.getCause(), directory);
+        }
     }
 
     @Override
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphLockFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphLockFeature.java
@@ -28,6 +28,7 @@
 import org.apache.http.HttpStatus;
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
@@ -53,10 +54,13 @@ public String lock(final Path file) throws BackgroundException {
             if(e.getResponseCode() == HttpStatus.SC_INTERNAL_SERVER_ERROR) {
                 throw new LockedException(e.getMessage(), e);
             }
-            throw new GraphExceptionMappingService(fileid).map("Failure to checkout file {0}", e, file);
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e, file);
         }
         catch(IOException e) {
-            throw new DefaultIOExceptionMappingService().map(e, file);
+            throw new DefaultIOExceptionMappingService().map("Failure to write attributes of {0}", e, file);
+        }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e.getCause(), file);
         }
     }
 
@@ -69,10 +73,13 @@ public void unlock(final Path file, final String token) throws BackgroundExcepti
                     new AlphanumericRandomStringService().random()));
         }
         catch(OneDriveAPIException e) {
-            throw new GraphExceptionMappingService(fileid).map("Failure to check in file {0}", e, file);
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e, file);
         }
         catch(IOException e) {
-            throw new DefaultIOExceptionMappingService().map(e, file);
+            throw new DefaultIOExceptionMappingService().map("Failure to write attributes of {0}", e, file);
+        }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e.getCause(), file);
         }
     }
 }
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphMoveFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphMoveFeature.java
@@ -35,6 +35,7 @@
 import org.apache.logging.log4j.Logger;
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.PatchOperation;
 import org.nuxeo.onedrive.client.types.DriveItem;
 import org.nuxeo.onedrive.client.types.FileSystemInfo;
@@ -96,6 +97,9 @@ public Path move(final Path file, final Path renamed, final TransferStatus statu
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Cannot rename {0}", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Cannot rename {0}", e.getCause(), file);
+        }
     }
 
     @Override
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphQuotaFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphQuotaFeature.java
@@ -25,6 +25,7 @@
 
 import org.nuxeo.onedrive.client.ODataQuery;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.Drive;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
@@ -62,15 +63,17 @@ public Space get() throws BackgroundException {
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Failure to read attributes of {0}", e, home);
         }
-        final org.nuxeo.onedrive.client.types.Quota quota = metadata.getQuota();
-        if(quota != null) {
-            Long used = quota.getUsed();
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to read attributes of {0}", e.getCause(), home);
+        }
+        if(metadata.getQuota() != null) {
+            Long used = metadata.getQuota().getUsed();
             if(used != null) {
-                Long remaining = quota.getRemaining();
+                Long remaining = metadata.getQuota().getRemaining();
                 if(remaining != null && (used != 0 || remaining != 0)) {
                     return new Space(used, remaining);
                 }
-                Long total = quota.getTotal();
+                Long total = metadata.getQuota().getTotal();
                 if(total != null && (used != 0 || total != 0)) {
                     return new Space(used, total - used);
                 }
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphReadFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphReadFeature.java
@@ -34,6 +34,7 @@
 import org.apache.logging.log4j.Logger;
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
@@ -101,5 +102,8 @@ public InputStream read(final Path file, final TransferStatus status, final Conn
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Download {0} failed", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Download {0} failed", e.getCause(), file);
+        }
     }
 }
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphSharedLinkFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphSharedLinkFeature.java
@@ -22,21 +22,26 @@
 import ch.cyberduck.core.Path;
 import ch.cyberduck.core.exception.BackgroundException;
 import ch.cyberduck.core.features.Share;
+import ch.cyberduck.core.onedrive.GraphExceptionMappingService;
 import ch.cyberduck.core.onedrive.GraphSession;
-import ch.cyberduck.core.worker.DefaultExceptionMappingService;
 
 import org.nuxeo.onedrive.client.Files;
+import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.OneDriveSharingLink;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
 import java.text.MessageFormat;
 
-public class GraphSharedLinkFeature implements Share {
+public class GraphSharedLinkFeature implements Share<Object, Object> {
+
     private final GraphSession session;
+    private final GraphFileIdProvider fileid;
 
-    public GraphSharedLinkFeature(final GraphSession session) {
+    public GraphSharedLinkFeature(final GraphSession session, final GraphFileIdProvider fileid) {
         this.session = session;
+        this.fileid = fileid;
     }
 
     @Override
@@ -55,11 +60,14 @@ public DescriptiveUrl toDownloadUrl(final Path file, final Sharee sharee, final
             return new DescriptiveUrl(Files.createSharedLink(item, OneDriveSharingLink.Type.VIEW).getLink().getWebUrl(),
                     DescriptiveUrl.Type.signed, MessageFormat.format(LocaleFactory.localizedString("{0} URL"), LocaleFactory.localizedString("Pre-Signed", "S3")));
         }
+        catch(OneDriveAPIException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e, file);
+        }
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map(e, file);
         }
-        catch(IllegalArgumentException e) {
-            throw new DefaultExceptionMappingService().map("Failed creating download url", e);
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e.getCause(), file);
         }
     }
 
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphTimestampFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphTimestampFeature.java
@@ -27,6 +27,7 @@
 import org.apache.logging.log4j.Logger;
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.PatchOperation;
 import org.nuxeo.onedrive.client.types.DriveItem;
 import org.nuxeo.onedrive.client.types.FileSystemInfo;
@@ -68,5 +69,8 @@ public void setTimestamp(final Path file, final TransferStatus status) throws Ba
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Failure to write attributes of {0}", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to write attributes of {0}", e.getCause(), file);
+        }
     }
 }
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphTouchFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphTouchFeature.java
@@ -32,6 +32,7 @@
 import org.apache.commons.lang3.StringUtils;
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
 import java.io.IOException;
@@ -63,6 +64,9 @@ public Path touch(final Write<DriveItem.Metadata> writer, final Path file, final
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Cannot create {0}", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Cannot create {0}", e.getCause(), file);
+        }
     }
 
     @Override
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphVersioningFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphVersioningFeature.java
@@ -29,6 +29,7 @@
 
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.types.DriveItem;
 import org.nuxeo.onedrive.client.types.DriveItemVersion;
 
@@ -71,6 +72,9 @@ public void revert(Path file) throws BackgroundException {
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Cannot revert file", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Cannot revert file", e.getCause(), file);
+        }
     }
 
     @Override
@@ -95,6 +99,9 @@ public AttributedList<Path> list(Path file, ListProgressListener listener) throw
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Failure to read attributes of {0}", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Failure to read attributes of {0}", e.getCause(), file);
+        }
         return versions;
     }
 
diff --git a/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphWriteFeature.java b/onedrive/src/main/java/ch/cyberduck/core/onedrive/features/GraphWriteFeature.java
@@ -38,6 +38,7 @@
 import org.nuxeo.onedrive.client.Files;
 import org.nuxeo.onedrive.client.OneDriveAPIException;
 import org.nuxeo.onedrive.client.OneDriveJsonObject;
+import org.nuxeo.onedrive.client.OneDriveRuntimeException;
 import org.nuxeo.onedrive.client.UploadSession;
 import org.nuxeo.onedrive.client.types.DriveItem;
 
@@ -89,6 +90,9 @@ public DriveItem.Metadata getStatus() {
         catch(IOException e) {
             throw new DefaultIOExceptionMappingService().map("Upload {0} failed", e, file);
         }
+        catch(OneDriveRuntimeException e) {
+            throw new GraphExceptionMappingService(fileid).map("Upload {0} failed", e.getCause(), file);
+        }
     }
 
     private final class ChunkedOutputStream extends OutputStream {
@@ -140,6 +144,9 @@ public Void call() throws BackgroundException {
                         catch(IOException e) {
                             throw new DefaultIOExceptionMappingService().map("Upload {0} failed", e, file);
                         }
+                        catch(OneDriveRuntimeException e) {
+                            throw new GraphExceptionMappingService(fileid).map("Download {0} failed", e.getCause(), file);
+                        }
                         return null;
                     }
                 }, overall).call();
diff --git a/onedrive/src/test/java/ch/cyberduck/core/onedrive/GraphShareTest.java b/onedrive/src/test/java/ch/cyberduck/core/onedrive/GraphShareTest.java
@@ -44,7 +44,7 @@ public class GraphShareTest extends AbstractOneDriveTest {
     public void toUrl() throws Exception {
         final Path file = new Path(new OneDriveHomeFinderService().find(), new AlphanumericRandomStringService().random(), EnumSet.of(Path.Type.file));
         new GraphTouchFeature(session, fileid).touch(new GraphWriteFeature(session, fileid), file, new TransferStatus().setMime("x-application/cyberduck"));
-        assertNotEquals(DescriptiveUrl.EMPTY, new GraphSharedLinkFeature(session).toDownloadUrl(file, Share.Sharee.world, null, new DisabledPasswordCallback()));
+        assertNotEquals(DescriptiveUrl.EMPTY, new GraphSharedLinkFeature(session, fileid).toDownloadUrl(file, Share.Sharee.world, null, new DisabledPasswordCallback()));
         new GraphDeleteFeature(session, fileid).delete(Collections.singletonList(file), new DisabledLoginCallback(), new Delete.DisabledCallback());
     }
 }
diff --git a/onedrive/src/test/java/ch/cyberduck/core/onedrive/GraphTimestampFeatureTest.java b/onedrive/src/test/java/ch/cyberduck/core/onedrive/GraphTimestampFeatureTest.java

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@`
`31`	`31`	`import org.apache.commons.lang3.StringUtils;`
`32`	`32`	`import org.nuxeo.onedrive.client.ODataQuery;`
`33`	`33`	`import org.nuxeo.onedrive.client.OneDriveAPIException;`
	`34`	`+import org.nuxeo.onedrive.client.OneDriveRuntimeException;`
`34`	`35`	`import org.nuxeo.onedrive.client.types.Drive;`
`35`	`36`	`import org.nuxeo.onedrive.client.types.DriveItem;`
`36`	`37`	`import org.nuxeo.onedrive.client.types.GroupItem;`
`@@ -115,11 +116,14 @@ public DriveItem getItem(final Path file, final boolean resolveLastItem) throws`
`115`	`116`	`return (DriveItem) remoteMetadata.getItem();`
`116`	`117`	`}`
`117`	`118`	`}`
`118`		`- catch(OneDriveAPIException oneDriveAPIException) {`
`119`		`- throw new GraphExceptionMappingService(fileid).map(oneDriveAPIException);`
	`119`	`+ catch(OneDriveAPIException e) {`
	`120`	`+ throw new GraphExceptionMappingService(fileid).map(e);`
`120`	`121`	`}`
`121`		`- catch(IOException ioException) {`
`122`		`- throw new DefaultIOExceptionMappingService().map(ioException);`
	`122`	`+ catch(IOException e) {`
	`123`	`+ throw new DefaultIOExceptionMappingService().map(e);`
	`124`	`+ }`
	`125`	`+ catch(OneDriveRuntimeException e) {`
	`126`	`+ throw new GraphExceptionMappingService(fileid).map(e.getCause());`
`123`	`127`	`}`
`124`	`128`	`}`
`125`	`129`	`return ownItem;`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@`
`51`	`51`	`import org.nuxeo.onedrive.client.ODataQuery;`
`52`	`52`	`import org.nuxeo.onedrive.client.OneDriveAPI;`
`53`	`53`	`import org.nuxeo.onedrive.client.OneDriveAPIException;`
	`54`	`+import org.nuxeo.onedrive.client.OneDriveRuntimeException;`
`54`	`55`	`import org.nuxeo.onedrive.client.RequestExecutor;`
`55`	`56`	`import org.nuxeo.onedrive.client.RequestHeader;`
`56`	`57`	`import org.nuxeo.onedrive.client.Users;`
`@@ -229,6 +230,9 @@ public void login(final LoginCallback prompt, final CancelCallback cancel) throw`
`229`	`230`	`catch(IOException e) {`
`230`	`231`	`throw new DefaultIOExceptionMappingService().map(e);`
`231`	`232`	`}`
	`233`	`+ catch(OneDriveRuntimeException e) {`
	`234`	`+ throw new GraphExceptionMappingService(fileid).map(e.getCause());`
	`235`	`+ }`
`232`	`236`	`}`
`233`	`237`
`234`	`238`	`@Override`
`@@ -295,7 +299,7 @@ public <T> T _getFeature(final Class<T> type) {`
`295`	`299`	`return (T) new GraphUrlProvider();`
`296`	`300`	`}`
`297`	`301`	`if(type == Share.class) {`
`298`		`- return (T) new GraphSharedLinkFeature(this);`
	`302`	`+ return (T) new GraphSharedLinkFeature(this, fileid);`
`299`	`303`	`}`
`300`	`304`	`if(type == Versioning.class) {`
`301`	`305`	`return (T) new GraphVersioningFeature(this, fileid);`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`
`29`	`29`	`import org.nuxeo.onedrive.client.Files;`
`30`	`30`	`import org.nuxeo.onedrive.client.OneDriveAPIException;`
	`31`	`+import org.nuxeo.onedrive.client.OneDriveRuntimeException;`
`31`	`32`	`import org.nuxeo.onedrive.client.types.DriveItem;`
`32`	`33`
`33`	`34`	`import java.io.IOException;`
`@@ -60,6 +61,9 @@ public void delete(final Map<Path, TransferStatus> files, final PasswordCallback`
`60`	`61`	`catch(IOException e) {`
`61`	`62`	`throw new DefaultIOExceptionMappingService().map("Cannot delete {0}", e, file);`
`62`	`63`	`}`
	`64`	`+ catch(OneDriveRuntimeException e) {`
	`65`	`+ throw new GraphExceptionMappingService(fileid).map("Cannot delete {0}", e.getCause(), file);`
	`66`	`+ }`
`63`	`67`	`}`
`64`	`68`	`}`
`65`	`69`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@`
`29`	`29`
`30`	`30`	`import org.nuxeo.onedrive.client.Files;`
`31`	`31`	`import org.nuxeo.onedrive.client.OneDriveAPIException;`
	`32`	`+import org.nuxeo.onedrive.client.OneDriveRuntimeException;`
`32`	`33`	`import org.nuxeo.onedrive.client.types.DriveItem;`
`33`	`34`
`34`	`35`	`import java.io.IOException;`
`@@ -61,6 +62,9 @@ public Path mkdir(final Write<DriveItem.Metadata> writer, final Path directory,`
`61`	`62`	`catch(IOException e) {`
`62`	`63`	`throw new DefaultIOExceptionMappingService().map("Cannot create folder {0}", e, directory);`
`63`	`64`	`}`
	`65`	`+ catch(OneDriveRuntimeException e) {`
	`66`	`+ throw new GraphExceptionMappingService(fileid).map("Cannot create folder {0}", e.getCause(), directory);`
	`67`	`+ }`
`64`	`68`	`}`
`65`	`69`
`66`	`70`	`@Override`