not allow to use loops in strings

Author: EduardTrutsyk

extensions/assert-linesOfCode.js

@@ -1,7 +1,7 @@
 import assert from 'assert';
 
 function linesOfCode(fn, expected, recommended) {
-  const actualLinesOfCode = fn.toString().split('\n').length - 2;
+  const actualLinesOfCode = fn.toString().split('\n').filter(s => s.trim()).length - 2;
   const isValid = actualLinesOfCode <= expected;
   if (actualLinesOfCode <= expected && actualLinesOfCode > recommended) {
     console.log(`Recommended lines of code for ${fn.name} is ${recommended}`); 

test/01-strings-tests.js

@@ -1,5 +1,7 @@
 import assert from 'assert';
-import {
+import * as tasks from '../task/01-strings-tasks';
+
+const {
   concatenateStrings,
   getStringLength,
   getStringFromTemplate,
@@ -15,7 +17,7 @@ import {
   encodeToRot13,
   isString,
   getCardId
-} from '../task/01-strings-tasks';
+} = tasks;
 
 it.optional = require('../extensions/it-optional');
 
@@ -155,4 +157,15 @@ describe('01-strings-tasks', () => {
     });
     assert.linesOfCode(getCardId, 3);
   });
+
+  it.optional('Functions from 01-strings-test.js should not use basic loops statements', () => {
+    Object.getOwnPropertyNames(tasks)
+      .filter(x => tasks[x] instanceof Function)
+      .forEach(f => {
+        assert(
+          !/([;{]\s*(for|while)\s*\()|(\.forEach\s*\()/.test(tasks[f].toString()),
+          `Function "${f}" should not use basic loop statements (for, while or Array.forEach)! Please use specialized array methods (Array.map, Array.reduce etc).`
+        );
+      });
+  });
 });

test/04-arrays-tests.js

@@ -950,7 +950,6 @@ describe('04-arrays-tasks', () => {
     assert.linesOfCode(swapHeadAndTail, 8, 2);
   });
 
-
   it.optional('Functions from 04-array-test.js should not use basic loops statements', () => {
     Object.getOwnPropertyNames(tasks)
       .filter(x => tasks[x] instanceof Function)