Skip to content

Conversation

@mateoguaman
Copy link
Contributor

Description

Currently, .dockerignore does not include env_isaaclab nor **/wandb/* in the files to be ignored, which should be ignored for cluster deployment since a) all Python packages are already part of the docker image (if env_isaaclab is not included in .dockerignore, it rsyncs over a 24GB dir), and b) local wandb logs should be ignored. This PR adds env_isaaclab and **/wandb/* to .dockerignore.

Fixes #4026

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Before:
Screenshot from 2025-11-16 15-27-52

After:
Screenshot from 2025-11-16 15-29-33

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added bug Something isn't working infrastructure labels Nov 17, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 17, 2025

Greptile Summary

  • Adds env_isaaclab and **/wandb/* to .dockerignore to prevent syncing 24GB virtual environment directory and local wandb logs during cluster deployment
  • Adds author to CONTRIBUTORS.md in alphabetical order

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal, well-tested, and directly address a documented issue. Adding entries to .dockerignore is a non-breaking change that only affects build-time file copying behavior, and the contributor addition follows the existing alphabetical format.
  • No files require special attention

Important Files Changed

Filename Overview
.dockerignore Added **/wandb/* and env_isaaclab to prevent syncing 24GB virtual environment and local wandb logs to Docker

Sequence Diagram

sequenceDiagram
    participant User
    participant "Docker Build" as Docker
    participant ".dockerignore" as DI
    User->>Docker: "Build container for cluster deployment"
    Docker->>DI: "Read ignore patterns"
    DI-->>Docker: "Exclude env_isaaclab and **/wandb/*"
    Docker->>Docker: "Copy files (excluding 24GB env dir)"
    Docker-->>User: "Container ready with smaller image"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@Mayankm96 Mayankm96 changed the title Fix/docker env isaaclab Adds wandb and uv env to dockerignore Nov 19, 2025
@Mayankm96 Mayankm96 merged commit c627940 into isaac-sim:main Nov 19, 2025
1 check passed
@Mayankm96
Copy link
Contributor

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] env_isaaclab and wandb dir are missing in .dockerignore

2 participants