don't put cluster_id in app.name

app.name affects which config files to load

Author: minrk

ipyparallel/apps/baseapp.py

@@ -118,13 +118,6 @@ def _work_dir_changed(self, change):
         """,
     )
 
-    @observe('cluster_id')
-    def _cluster_id_changed(self, change):
-        if change['new']:
-            self.name = '{}-{}'.format(self.__class__.name, change['new'])
-        else:
-            self.name = self.__class__.name
-
     loop = Instance(IOLoop)
 
     def _loop_default(self):
@@ -197,7 +190,7 @@ def reinit_logging(self):
                         pass
         if self.log_to_file:
             # Start logging to the new log file
-            log_filename = self.name + u'-' + str(os.getpid()) + u'.log'
+            log_filename = f"{self.name}-{self.cluster_id}-{os.getpid()}.log"
             logfile = os.path.join(log_dir, log_filename)
             if sys.__stderr__:
                 print(f"Sending logs to {logfile}", file=sys.__stderr__)

ipyparallel/controller/app.py

@@ -235,9 +235,11 @@ class IPController(BaseParallelApplication):
 
     @observe('cluster_id')
     def _cluster_id_changed(self, change):
-        super()._cluster_id_changed(change)
-        self.engine_json_file = "%s-engine.json" % self.name
-        self.client_json_file = "%s-client.json" % self.name
+        base = 'ipcontroller'
+        if change.new:
+            base = f"{base}-{change.new}"
+        self.engine_json_file = f"{base}-engine.json"
+        self.client_json_file = f"{base}-client.json"
 
     # internal
     children = List()