Merge pull request #25 from ipfs/make-consistent-with-go

Make consistent with go

Author: achingbrain

src/index.js

@@ -73,15 +73,23 @@ function Data (type, data) {
     }
     let fileSize = this.fileSize()
 
-    if (!fileSize) {
-      fileSize = undefined
+    let data = this.data
+
+    if (!this.data || !this.data.length) {
+      data = undefined
+    }
+
+    let blockSizes = this.blockSizes
+
+    if (!this.blockSizes || !this.blockSizes.length) {
+      blockSizes = undefined
     }
 
     return unixfsData.encode({
       Type: type,
-      Data: this.data,
+      Data: data,
       filesize: fileSize,
-      blocksizes: this.blockSizes.length > 0 ? this.blockSizes : undefined,
+      blocksizes: blockSizes,
       hashType: this.hashType,
       fanout: this.fanout
     })

test/unixfs-format.spec.js

@@ -15,88 +15,81 @@ const symlink = loadFixture('test/fixtures/symlink.txt.unixfs')
 const Buffer = require('safe-buffer').Buffer
 
 describe('unixfs-format', () => {
-  it('raw', (done) => {
+  it('raw', () => {
     const data = new UnixFS('raw', Buffer.from('bananas'))
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
   })
 
-  it('directory', (done) => {
+  it('directory', () => {
     const data = new UnixFS('directory')
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
   })
 
-  it('hamt-sharded-directory', (done) => {
+  it('hamt-sharded-directory', () => {
     const data = new UnixFS('hamt-sharded-directory')
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
   })
 
-  it('file', (done) => {
+  it('file', () => {
     const data = new UnixFS('file', new Buffer('batata'))
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
   })
 
-  it('file add blocksize', (done) => {
+  it('file add blocksize', () => {
     const data = new UnixFS('file')
     data.addBlockSize(256)
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
   })
 
-  it('file add and remove blocksize', (done) => {
+  it('file add and remove blocksize', () => {
     const data = new UnixFS('file')
     data.addBlockSize(256)
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    unmarsheled.removeBlockSize(0)
-    expect(data.blockSizes).to.not.deep.equal(unmarsheled.blockSizes)
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
+    unmarshalled.removeBlockSize(0)
+    expect(data.blockSizes).to.not.deep.equal(unmarshalled.blockSizes)
   })
 
   // figuring out what is this metadata for https://github.com/ipfs/js-ipfs-data-importing/issues/3#issuecomment-182336526
-  it.skip('metadata', (done) => {})
+  it.skip('metadata', () => {})
 
-  it('symlink', (done) => {
+  it('symlink', () => {
     const data = new UnixFS('symlink')
-    const marsheled = data.marshal()
-    const unmarsheled = UnixFS.unmarshal(marsheled)
-    expect(data.type).to.equal(unmarsheled.type)
-    expect(data.data).to.deep.equal(unmarsheled.data)
-    expect(data.blockSizes).to.deep.equal(unmarsheled.blockSizes)
-    expect(data.fileSize()).to.deep.equal(unmarsheled.fileSize())
-    done()
+    const marshalled = data.marshal()
+    const unmarshalled = UnixFS.unmarshal(marshalled)
+    expect(data.type).to.equal(unmarshalled.type)
+    expect(data.data).to.deep.equal(unmarshalled.data)
+    expect(data.blockSizes).to.deep.equal(unmarshalled.blockSizes)
+    expect(data.fileSize()).to.deep.equal(unmarshalled.fileSize())
   })
   it('wrong type', (done) => {
     let data
@@ -110,40 +103,43 @@ describe('unixfs-format', () => {
   })
 
   describe('interop', () => {
-    it('raw', (done) => {
-      const unmarsheled = UnixFS.unmarshal(raw)
-      expect(unmarsheled.data).to.eql(Buffer.from('Hello UnixFS\n'))
-      expect(unmarsheled.type).to.equal('file')
-      expect(unmarsheled.marshal()).to.deep.equal(raw)
-      done()
+    it('raw', () => {
+      const unmarshalled = UnixFS.unmarshal(raw)
+      expect(unmarshalled.data).to.eql(Buffer.from('Hello UnixFS\n'))
+      expect(unmarshalled.type).to.equal('file')
+      expect(unmarshalled.marshal()).to.deep.equal(raw)
     })
 
-    it('directory', (done) => {
-      const unmarsheled = UnixFS.unmarshal(directory)
-      expect(unmarsheled.data).to.deep.equal(undefined)
-      expect(unmarsheled.type).to.equal('directory')
-      expect(unmarsheled.marshal()).to.deep.equal(directory)
-      done()
+    it('directory', () => {
+      const unmarshalled = UnixFS.unmarshal(directory)
+      expect(unmarshalled.data).to.deep.equal(undefined)
+      expect(unmarshalled.type).to.equal('directory')
+      expect(unmarshalled.marshal()).to.deep.equal(directory)
     })
 
-    it('file', (done) => {
-      const unmarsheled = UnixFS.unmarshal(file)
-      expect(unmarsheled.data).to.deep.equal(Buffer.from('Hello UnixFS\n'))
-      expect(unmarsheled.type).to.equal('file')
-      expect(unmarsheled.marshal()).to.deep.equal(file)
-      done()
+    it('file', () => {
+      const unmarshalled = UnixFS.unmarshal(file)
+      expect(unmarshalled.data).to.deep.equal(Buffer.from('Hello UnixFS\n'))
+      expect(unmarshalled.type).to.equal('file')
+      expect(unmarshalled.marshal()).to.deep.equal(file)
     })
 
-    it.skip('metadata', (done) => {
+    it.skip('metadata', () => {
     })
 
-    it('symlink', (done) => {
-      const unmarsheled = UnixFS.unmarshal(symlink)
-      expect(unmarsheled.data).to.deep.equal(Buffer.from('file.txt'))
-      expect(unmarsheled.type).to.equal('symlink')
+    it('symlink', () => {
+      const unmarshalled = UnixFS.unmarshal(symlink)
+      expect(unmarshalled.data).to.deep.equal(Buffer.from('file.txt'))
+      expect(unmarshalled.type).to.equal('symlink')
       // TODO: waiting on https://github.com/ipfs/js-ipfs-data-importing/issues/3#issuecomment-182440079
-      // expect(unmarsheled.marshal()).to.deep.equal(symlink)
-      done()
+      // expect(unmarshalled.marshal()).to.deep.equal(symlink)
     })
   })
+
+  it('empty', () => {
+    const data = new UnixFS('file')
+    const marshalled = data.marshal()
+
+    expect(marshalled).to.deep.equal(Buffer.from([0x08, 0x02, 0x18, 0x00]))
+  })
 })