Skip to content

Commit 95412df

Browse files
committed
Fix gosec linting
1 parent 463234e commit 95412df

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

internal/service/vmservice/bootstrap.go

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -252,39 +252,40 @@ func getDefaultNetworkDevice(ctx context.Context, machineScope *scope.MachineSco
252252
func getAdditionalNetworkDevices(ctx context.Context, machineScope *scope.MachineScope, network infrav1alpha1.NetworkSpec) ([]cloudinit.NetworkConfigData, error) {
253253
networkConfigData := make([]cloudinit.NetworkConfigData, 0, len(network.AdditionalDevices))
254254

255+
nics := network.AdditionalDevices
255256
// additional network devices.
256-
for _, nic := range network.AdditionalDevices {
257+
for i := range network.AdditionalDevices {
257258
var config = ptr.To(cloudinit.NetworkConfigData{})
258259

259-
if nic.IPv4PoolRef != nil {
260-
device := fmt.Sprintf("%s-%s", nic.Name, infrav1alpha1.DefaultSuffix)
260+
if nics[i].IPv4PoolRef != nil {
261+
device := fmt.Sprintf("%s-%s", nics[i].Name, infrav1alpha1.DefaultSuffix)
261262
conf, err := getNetworkConfigDataForDevice(ctx,
262263
machineScope,
263-
&nic.NetworkDevice,
264+
&nics[i].NetworkDevice,
264265
device,
265266
infrav1alpha1.IPV4Format)
266267
if err != nil {
267268
return nil, errors.Wrapf(err, "unable to get network config data for device=%s", device)
268269
}
269-
if len(nic.DNSServers) != 0 {
270-
config.DNSServers = nic.DNSServers
270+
if len(nics[i].DNSServers) != 0 {
271+
config.DNSServers = nics[i].DNSServers
271272
}
272273
config = conf
273274
}
274275

275-
if nic.IPv6PoolRef != nil {
276+
if nics[i].IPv6PoolRef != nil {
276277
suffix := infrav1alpha1.DefaultSuffix + "6"
277-
device := fmt.Sprintf("%s-%s", nic.Name, suffix)
278+
device := fmt.Sprintf("%s-%s", nics[i].Name, suffix)
278279
conf, err := getNetworkConfigDataForDevice(ctx,
279280
machineScope,
280-
&nic.NetworkDevice,
281+
&nics[i].NetworkDevice,
281282
device,
282283
infrav1alpha1.IPV6Format)
283284
if err != nil {
284285
return nil, errors.Wrapf(err, "unable to get network config data for device=%s", device)
285286
}
286-
if len(nic.DNSServers) != 0 {
287-
config.DNSServers = nic.DNSServers
287+
if len(nics[i].DNSServers) != 0 {
288+
config.DNSServers = nics[i].DNSServers
288289
}
289290

290291
switch {

0 commit comments

Comments
 (0)