Issue #1228 - google analytics (#1247)

* Add key param check

* Tests fix

* Tests fix

Author: vitaliy-bobrov

src/plugins/googleAnalytics.js

@@ -56,8 +56,13 @@ angular.module('ngCordova.plugins.googleAnalytics', [])
 
       addCustomDimension: function (key, value) {
         var d = $q.defer();
+        var parsedKey = parseInt(key, 10);
 
-        $window.analytics.addCustomDimension(key, value, function () {
+        if (isNaN(parsedKey)) {
+          d.reject('Parameter "key" must be an integer.');
+        }
+
+        $window.analytics.addCustomDimension(parsedKey, value, function () {
           d.resolve();
         }, function (error) {
           d.reject(error);

test/plugins/googleAnalytics.spec.js

@@ -192,15 +192,15 @@ describe('Service: $cordovaGoogleAnalytics', function() {
       });
 
     $cordovaGoogleAnalytics
-      .addCustomDimension('dimension1', 'Level 1')
+      .addCustomDimension(1, 'Level 1')
       .then(function (response) {
         result = 'success';
       });
 
     $rootScope.$digest();
 
     expect(result).toBe('success');
-    expect($window.analytics.addCustomDimension.calls.argsFor(0)[0]).toBe('dimension1');
+    expect($window.analytics.addCustomDimension.calls.argsFor(0)[0]).toBe(1);
     expect($window.analytics.addCustomDimension.calls.argsFor(0)[1]).toBe('Level 1');
   });
 
@@ -210,7 +210,7 @@ describe('Service: $cordovaGoogleAnalytics', function() {
 
     spyOn($window.analytics, 'addCustomDimension')
       .and.callFake(function (key, value, successCb, errorCb) {
-        errorCb('Expected one non-empty string argument');
+        errorCb('Parameter "key" must be an integer.');
       });
 
     $cordovaGoogleAnalytics.addCustomDimension()
@@ -220,7 +220,7 @@ describe('Service: $cordovaGoogleAnalytics', function() {
 
     $rootScope.$digest();
 
-    expect(result).toBe('Expected one non-empty string argument');
+    expect(result).toBe('Parameter "key" must be an integer.');
   });
 
   it('should call $window\'s analytics.trackEvent method', function() {