feat(): remove hideKeyboardAccessoryBar

BREAKING CHANGE: hideKeyboardAccessoryBar has started causing apps to be
rejected from the app store, so is removed until there is a valid
alternative.

Author: tlancina

README.md

@@ -8,7 +8,7 @@ The `cordova.plugins.Keyboard` object provides functions to make interacting wit
 Methods
 -------
 
-- cordova.plugins.Keyboard.hideKeyboardAccessoryBar
+- ~~cordova.plugins.Keyboard.hideKeyboardAccessoryBar~~ (**removed in 2.0, see below**)
 - cordova.plugins.Keyboard.close
 - cordova.plugins.Keyboard.disableScroll
 - cordova.plugins.Keyboard.show
@@ -30,9 +30,11 @@ These events are fired on the window.
 
 # API reference
 
-Keyboard.hideKeyboardAccessoryBar
+~~Keyboard.hideKeyboardAccessoryBar~~
 =================
 
+**NOTE: This method started causing apps to be rejected from the App Store, so has been removed until a workaround is found.**
+
 Hide the keyboard accessory bar with the next, previous and done buttons.
 
     cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
@@ -54,7 +56,7 @@ Close the keyboard if it is open.
 Supported Platforms
 -------------------
 
-- iOS, Android, Blackberry 10, Windows 
+- iOS, Android, Blackberry 10, Windows
 
 
 Keyboard.disableScroll
@@ -79,7 +81,7 @@ Force keyboard to be shown. This typically helps if autofocus on a text element
 
 Supported Platforms
 
-- Android, Blackberry 10, Windows 
+- Android, Blackberry 10, Windows
 
 native.keyboardshow
 =================

plugin.xml

@@ -41,8 +41,10 @@
 
         <header-file src="src/ios/IonicKeyboard.h" />
         <source-file src="src/ios/IonicKeyboard.m" />
+    <!--
         <header-file src="src/ios/UIWebViewExtension.h" />
         <source-file src="src/ios/UIWebViewExtension.m" />
+     -->
     </platform>
 
     <!-- blackberry10 -->

src/ios/IonicKeyboard.h

@@ -5,7 +5,7 @@
     id _keyboardShowObserver, _keyboardHideObserver;
 }
 
-@property (readwrite, assign) BOOL hideKeyboardAccessoryBar;
+// @property (readwrite, assign) BOOL hideKeyboardAccessoryBar;
 @property (readwrite, assign) BOOL disableScroll;
 //@property (readwrite, assign) BOOL styleDark;
 

src/ios/IonicKeyboard.m

@@ -1,37 +1,37 @@
 #import "IonicKeyboard.h"
-#import "UIWebViewExtension.h"
+// #import "UIWebViewExtension.h"
 #import <Cordova/CDVAvailability.h>
 
 @implementation IonicKeyboard
 
-@synthesize hideKeyboardAccessoryBar = _hideKeyboardAccessoryBar;
+// @synthesize hideKeyboardAccessoryBar = _hideKeyboardAccessoryBar;
 @synthesize disableScroll = _disableScroll;
 //@synthesize styleDark = _styleDark;
 
 - (void)pluginInitialize {
-  
+
     NSNotificationCenter* nc = [NSNotificationCenter defaultCenter];
     __weak IonicKeyboard* weakSelf = self;
 
     //set defaults
-    self.hideKeyboardAccessoryBar = YES;
+    // self.hideKeyboardAccessoryBar = YES;
     self.disableScroll = NO;
     //self.styleDark = NO;
-    
+
     _keyboardShowObserver = [nc addObserverForName:UIKeyboardWillShowNotification
                                object:nil
                                queue:[NSOperationQueue mainQueue]
                                usingBlock:^(NSNotification* notification) {
-                                   
+
                                    CGRect keyboardFrame = [notification.userInfo[UIKeyboardFrameEndUserInfoKey] CGRectValue];
                                    keyboardFrame = [self.viewController.view convertRect:keyboardFrame fromView:nil];
-                                   
+
                                    [weakSelf.commandDelegate evalJs:[NSString stringWithFormat:@"cordova.plugins.Keyboard.isVisible = true; cordova.fireWindowEvent('native.keyboardshow', { 'keyboardHeight': %@ }); ", [@(keyboardFrame.size.height) stringValue]]];
 
                                    //deprecated
                                    [weakSelf.commandDelegate evalJs:[NSString stringWithFormat:@"cordova.fireWindowEvent('native.showkeyboard', { 'keyboardHeight': %@ }); ", [@(keyboardFrame.size.height) stringValue]]];
                                }];
-    
+
     _keyboardHideObserver = [nc addObserverForName:UIKeyboardWillHideNotification
                                object:nil
                                queue:[NSOperationQueue mainQueue]
@@ -63,23 +63,23 @@ - (void)setDisableScroll:(BOOL)disableScroll {
 }
 
 
-- (BOOL)hideKeyboardAccessoryBar {
-    return _hideKeyboardAccessoryBar;
-}
-
-- (void)setHideKeyboardAccessoryBar:(BOOL)hideKeyboardAccessoryBar {
-    if (hideKeyboardAccessoryBar == _hideKeyboardAccessoryBar || ![self.webView isKindOfClass:[UIWebView class]]) {
-        return;
-    }
-    if (hideKeyboardAccessoryBar) {
-        ((UIWebView*)self.webView).hackishlyHidesInputAccessoryView = YES;
-    }
-    else {
-        ((UIWebView*)self.webView).hackishlyHidesInputAccessoryView = NO;
-    }
-
-    _hideKeyboardAccessoryBar = hideKeyboardAccessoryBar;
-}
+// - (BOOL)hideKeyboardAccessoryBar {
+//     return _hideKeyboardAccessoryBar;
+// }
+//
+// - (void)setHideKeyboardAccessoryBar:(BOOL)hideKeyboardAccessoryBar {
+//     if (hideKeyboardAccessoryBar == _hideKeyboardAccessoryBar || ![self.webView isKindOfClass:[UIWebView class]]) {
+//         return;
+//     }
+//     if (hideKeyboardAccessoryBar) {
+//         ((UIWebView*)self.webView).hackishlyHidesInputAccessoryView = YES;
+//     }
+//     else {
+//         ((UIWebView*)self.webView).hackishlyHidesInputAccessoryView = NO;
+//     }
+//
+//     _hideKeyboardAccessoryBar = hideKeyboardAccessoryBar;
+// }
 
 /*
 - (BOOL)styleDark {
@@ -129,15 +129,15 @@ - (void) disableScroll:(CDVInvokedUrlCommand*)command {
     }
 }
 
-- (void) hideKeyboardAccessoryBar:(CDVInvokedUrlCommand*)command {
-    if (!command.arguments || ![command.arguments count]){
-      return;
-    }
-    id value = [command.arguments objectAtIndex:0];
-    if (value != [NSNull null]) {
-      self.hideKeyboardAccessoryBar = [value boolValue];
-    }
-}
+// - (void) hideKeyboardAccessoryBar:(CDVInvokedUrlCommand*)command {
+//     if (!command.arguments || ![command.arguments count]){
+//       return;
+//     }
+//     id value = [command.arguments objectAtIndex:0];
+//     if (value != [NSNull null]) {
+//       self.hideKeyboardAccessoryBar = [value boolValue];
+//     }
+// }
 
 - (void) close:(CDVInvokedUrlCommand*)command {
     [self.webView endEditing:YES];
@@ -153,7 +153,7 @@ - (void) styleDark:(CDVInvokedUrlCommand*)command {
       return;
     }
     id value = [command.arguments objectAtIndex:0];
-    
+
     self.styleDark = [value boolValue];
 }
 */

src/ios/UIWebViewExtension.h

@@ -1,4 +1,4 @@
-@interface UIWebView (HackishAccessoryHiding)
-@property (nonatomic, assign) BOOL hackishlyHidesInputAccessoryView;
-//@property (nonatomic, assign) BOOL styleDark;
-@end
+// @interface UIWebView (HackishAccessoryHiding)
+// @property (nonatomic, assign) BOOL hackishlyHidesInputAccessoryView;
+// //@property (nonatomic, assign) BOOL styleDark;
+// @end