From 64a4ffe55cbf821e319c284b7b065e874733cb59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=CC=81=20Rio?= Date: Thu, 6 Nov 2025 10:13:20 +0000 Subject: [PATCH 1/3] feat(select-modal): add ionic select default modal styling --- core/src/components/modal/modal.ionic.scss | 12 +++++++++++- .../select-modal/select-modal.ionic.scss | 4 ++++ core/src/components/select-modal/select-modal.tsx | 15 +++++++++++++-- 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/core/src/components/modal/modal.ionic.scss b/core/src/components/modal/modal.ionic.scss index 80244c5ba68..d786b9e68a0 100644 --- a/core/src/components/modal/modal.ionic.scss +++ b/core/src/components/modal/modal.ionic.scss @@ -27,6 +27,16 @@ --border-radius: #{globals.$ion-border-radius-0}; } +// Default Modal +// -------------------------------------------------- + +// Modal when inside a select default-modal +:host(.select-modal.modal-default) { + --max-height: 45%; + --max-width: calc(100% - (#{globals.$ion-space-400} * 2)); + --min-height: 340px; +} + // Sheet Modal // -------------------------------------------------- @@ -54,4 +64,4 @@ */ :host(.modal-sheet) { --height: calc(100% - (var(--ion-safe-area-top) + #{globals.$ion-scale-250})); -} +} \ No newline at end of file diff --git a/core/src/components/select-modal/select-modal.ionic.scss b/core/src/components/select-modal/select-modal.ionic.scss index cd0df6ce3a9..23d7705b660 100644 --- a/core/src/components/select-modal/select-modal.ionic.scss +++ b/core/src/components/select-modal/select-modal.ionic.scss @@ -4,6 +4,10 @@ // Ionic Select Modal // -------------------------------------------------- +:host(.in-modal-default) ion-content::part(scroll) { + --padding-bottom: #{globals.$ion-space-400}; +} + // Item // ---------------------------------------------------------------- diff --git a/core/src/components/select-modal/select-modal.tsx b/core/src/components/select-modal/select-modal.tsx index 1e61c933fdf..e72c762bce4 100644 --- a/core/src/components/select-modal/select-modal.tsx +++ b/core/src/components/select-modal/select-modal.tsx @@ -2,7 +2,7 @@ import { getIonMode } from '@global/ionic-global'; import type { ComponentInterface } from '@stencil/core'; import { Component, Element, Host, Prop, forceUpdate, h } from '@stencil/core'; import { safeCall } from '@utils/overlays'; -import { getClassMap } from '@utils/theme'; +import { getClassMap, hostContext } from '@utils/theme'; import type { CheckboxCustomEvent } from '../checkbox/checkbox-interface'; import type { RadioGroupCustomEvent } from '../radio-group/radio-group-interface'; @@ -74,6 +74,14 @@ export class SelectModal implements ComponentInterface { } } + private getModalContextClasses() { + const el = this.el; + return { + 'in-modal-default': hostContext('ion-modal.modal-default', el), + 'in-modalsheet': hostContext('ion-modal.modal-sheet', el), + }; + } + private renderRadioOptions() { const checked = this.options.filter((o) => o.checked).map((o) => o.value)[0]; @@ -143,7 +151,10 @@ export class SelectModal implements ComponentInterface { render() { return ( - + {this.header !== undefined && {this.header}} From 2e73d8943c406d5446702147f9dc32c2cb2f433d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=CC=81=20Rio?= Date: Thu, 6 Nov 2025 12:31:58 +0000 Subject: [PATCH 2/3] fix(select-modal): typo --- core/src/components/select-modal/select-modal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/components/select-modal/select-modal.tsx b/core/src/components/select-modal/select-modal.tsx index e72c762bce4..627ae418eb4 100644 --- a/core/src/components/select-modal/select-modal.tsx +++ b/core/src/components/select-modal/select-modal.tsx @@ -78,7 +78,7 @@ export class SelectModal implements ComponentInterface { const el = this.el; return { 'in-modal-default': hostContext('ion-modal.modal-default', el), - 'in-modalsheet': hostContext('ion-modal.modal-sheet', el), + 'in-modal-sheet': hostContext('ion-modal.modal-sheet', el), }; } From 088eb51f28261e728bbf0fea74c1bd6770c63e7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=CC=81=20Rio?= Date: Thu, 6 Nov 2025 12:41:48 +0000 Subject: [PATCH 3/3] fix(select-modal): run lint --- core/src/components/modal/modal.ionic.scss | 2 +- core/src/components/select-modal/select-modal.tsx | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/core/src/components/modal/modal.ionic.scss b/core/src/components/modal/modal.ionic.scss index d786b9e68a0..30306fce969 100644 --- a/core/src/components/modal/modal.ionic.scss +++ b/core/src/components/modal/modal.ionic.scss @@ -64,4 +64,4 @@ */ :host(.modal-sheet) { --height: calc(100% - (var(--ion-safe-area-top) + #{globals.$ion-scale-250})); -} \ No newline at end of file +} diff --git a/core/src/components/select-modal/select-modal.tsx b/core/src/components/select-modal/select-modal.tsx index 627ae418eb4..8b4ed90193e 100644 --- a/core/src/components/select-modal/select-modal.tsx +++ b/core/src/components/select-modal/select-modal.tsx @@ -151,10 +151,12 @@ export class SelectModal implements ComponentInterface { render() { return ( - + {this.header !== undefined && {this.header}}