Merge remote-tracking branch 'upstream/main' into mtewani/add-angular-v20-support

Author: maneesht

.changeset/chubby-zebras-enjoy.md

@@ -4,8 +4,8 @@
   "commit": false,
   "fixed": [],
   "linked": [],
-  "access": "restricted",
+  "access": "public",
   "baseBranch": "main",
   "updateInternalDependencies": "patch",
-  "ignore": []
+  "ignore": ["example-*"]
 }

.changeset/config.json

@@ -14,8 +14,9 @@ concurrency:
   group: release
   cancel-in-progress: false
 
-# Minimal permissions for security
+# Permissions: add id-token for OIDC; keep others for PRs
 permissions:
+  id-token: write
   contents: write
   pull-requests: write
   issues: write
@@ -61,6 +62,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 45
     needs: quality
+    environment: publish
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -73,6 +75,9 @@ jobs:
           node-version: "20"
           registry-url: "https://registry.npmjs.org"
 
+      - name: Ensure npm >= 11.5.1 for OIDC
+        run: npm i -g npm@^11.5.1
+
       - name: Enable Corepack
         run: corepack enable
 
@@ -92,6 +97,9 @@ jobs:
 
       - name: Install dependencies
         run: pnpm install
+        # If you have PRIVATE deps, uncomment and set a read-only token:
+        # env:
+        #   NODE_AUTH_TOKEN: ${{ secrets.NPM_READ_TOKEN }}
 
       - name: Cache Firebase emulators
         uses: actions/cache@v4
@@ -118,7 +126,6 @@ jobs:
       - name: Verify build outputs
         run: |
           echo "Checking build outputs..."
-          # Check all packages for dist directories
           MISSING_BUILDS=""
           for PKG_DIR in packages/*; do
             if [ -d "$PKG_DIR" ] && [ -f "$PKG_DIR/package.json" ]; then
@@ -128,44 +135,23 @@ jobs:
               fi
             fi
           done
-          
           if [ -n "$MISSING_BUILDS" ]; then
             echo "❌ Build outputs missing for: $MISSING_BUILDS"
             exit 1
           fi
-          
           echo "✅ All build outputs verified"
 
-      - name: Validate changesets
-        run: |
-          set -e
-          CHANGESET_FILES=$(find .changeset -name "*.md" -type f ! -name "README.md" 2>/dev/null || true)
-          
-          if [ -z "$CHANGESET_FILES" ]; then
-            echo "❌ No changesets found!"
-            echo ""
-            echo "Please create changesets locally with: pnpm changeset"
-            echo "Changesets should be created during development, not during release."
-            exit 1
-          fi
-          
-          CHANGESET_COUNT=$(echo "$CHANGESET_FILES" | wc -l | tr -d ' ')
-          echo "✅ Found $CHANGESET_COUNT changeset(s):"
-          echo "$CHANGESET_FILES" | while read -r file; do
-            echo "  - $(basename "$file")"
-          done
-
       - name: Create Release Pull Request or Publish
         if: ${{ !inputs.dry_run }}
         id: changesets
         uses: changesets/action@v1
         with:
-          publish: pnpm release
+          publish: pnpm release # runs: pnpm build && changeset publish
           commit: "chore: version packages"
           title: "chore: version packages"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          # NPM_TOKEN removed – OIDC will be used automatically
 
       - name: Dry Run - Show Changes
         if: ${{ inputs.dry_run }}
@@ -180,24 +166,17 @@ jobs:
               echo ""
             fi
           done
-
           echo "📦 Version changes that would be applied:"
-          # Configure git user for changeset version command
           git config user.name "github-actions[bot]"
           git config user.email "github-actions[bot]@users.noreply.github.com"
-          
-          # Save current HEAD reference before making changes
           ORIGINAL_HEAD=$(git rev-parse HEAD)
-          # Create a temporary branch for dry run with unique name
           FALLBACK_ID=${GITHUB_RUN_ID:-$RANDOM$RANDOM}
           TEMP_BRANCH="dry-run-temp-$FALLBACK_ID"
           git checkout -b "$TEMP_BRANCH"
           pnpm changeset version
-          
           echo ""
           echo "🔍 Changed files:"
           git diff --name-status "$ORIGINAL_HEAD"
-          
           echo ""
           echo "🔍 Package version changes:"
           VERSION_CHANGES=$(git diff "$ORIGINAL_HEAD" -- '**/package.json' | grep -E "^[+-]\s*\"version\"" || true)
@@ -206,10 +185,7 @@ jobs:
           else
             echo "$VERSION_CHANGES"
           fi
-          
-          # Clean up
           git checkout -
           git branch -D "$TEMP_BRANCH"
-          
           echo ""
           echo "✅ Dry run completed successfully"

.changeset/proud-rice-vanish.md

@@ -0,0 +1,87 @@
+name: Test React Package with Firebase v12
+
+on:
+  workflow_dispatch:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+    paths:
+      - "packages/react/**"
+      - "dataconnect-sdk/**"
+      - ".github/workflows/test-react-firebase-v12.yml"
+
+jobs:
+  test-react-v12:
+    name: React Package - Firebase v12
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
+      - name: Enable Corepack
+        run: corepack enable
+
+      - name: Install dependencies
+        run: pnpm install
+
+      # IMPROVED: Use actions/setup-java instead of apt-get
+      - name: Setup Java
+        uses: actions/setup-java@v4
+        with:
+          distribution: "temurin"
+          java-version: "17"
+
+      - name: Install Firebase CLI
+        uses: nick-invision/retry@v3
+        with:
+          timeout_minutes: 10
+          retry_wait_seconds: 60
+          max_attempts: 3
+          command: npm i -g firebase-tools@latest
+
+      - name: Update to Firebase v12
+        run: |
+          # Update root devDependencies to Firebase v12
+          pnpm add -Dw firebase@^12.1.0
+
+      - name: Update Data Connect SDK for Firebase v12
+        run: |
+          # Manually update the generated SDK to support Firebase v12
+          # This is temporary until Firebase CLI officially supports v12
+          cd dataconnect-sdk/js/default-connector
+          # Update the peer dependency to include v12
+          npm pkg set 'peerDependencies.firebase=^12.1.0'
+          cd ../../..
+
+      - name: Reinstall dependencies with v12
+        run: |
+          # Install with no-frozen-lockfile to allow dependency changes
+          pnpm install --no-frozen-lockfile
+          # Force React package to use Firebase v12
+          cd packages/react
+          pnpm add -D firebase@^12.1.0
+          cd ../..
+
+      - name: Verify Firebase v12 is installed
+        run: |
+          cd packages/react
+          pnpm ls firebase | grep -E "firebase.*12\." || (echo "Firebase v12 not found!" && exit 1)
+
+      - name: Build React package
+        run: |
+          cd packages/react
+          pnpm build
+
+      - name: Run React package tests with emulator
+        run: |
+          # Run only React package tests with emulator
+          firebase emulators:exec --project test-project "cd packages/react && pnpm test:ci"
+        env:
+          CI: true