Skip to content

feat(firestore): implement withCoverter #8744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+2,631 −145
Open

feat(firestore): implement withCoverter #8744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f020f5a
feat(firestore): implement withConverter
JiriHoffmann Nov 3, 2025
3cdb8cf
fix(firestore): test converter with undefined property
JiriHoffmann Nov 5, 2025
2c33955
fix(firestore): adjust modular types for withConverter
JiriHoffmann Nov 5, 2025
cce8962
fix(firestore): Query typedef import
JiriHoffmann Nov 7, 2025
bde3f92
fix(firestore): make Constraint classes abstract
JiriHoffmann Nov 7, 2025
67a8002
fix(firestore): remove unknown from modular types
JiriHoffmann Nov 7, 2025
9434263
fix(firestore): modular/namespace imports in jest test
JiriHoffmann Nov 7, 2025
5b2093e
fix(firestore): additional Query typedef imports
JiriHoffmann Nov 7, 2025
b8571e5
fix(firestore): text in test comments
JiriHoffmann Nov 7, 2025
e56ab94
fix(firestore): improve withConverter e2e tests
JiriHoffmann Nov 10, 2025
04d563a
chore(firestore): format type-test.ts
JiriHoffmann Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/firestore/__tests__/firestore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => getCountFromServer(query),
// @ts-expect-error Combines modular and namespace imports
() => query.count(),
'count',
);
Expand All @@ -958,6 +959,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => getCountFromServer(query),
// @ts-expect-error Combines modular and namespace API
() => query.countFromServer(),
'countFromServer',
);
Expand All @@ -970,6 +972,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => endAt('foo'),
// @ts-expect-error Combines modular and namespace API
() => query.endAt('foo'),
'endAt',
);
Expand All @@ -982,6 +985,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => endBefore('foo'),
// @ts-expect-error Combines modular and namespace API
() => query.endBefore('foo'),
'endBefore',
);
Expand All @@ -994,6 +998,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => getDocs(query),
// @ts-expect-error Combines modular and namespace API
() => query.get(),
'get',
);
Expand All @@ -1007,6 +1012,7 @@ describe('Firestore', function () {
collectionRefV9Deprecation(
// no equivalent method
() => {},
// @ts-expect-error Combines modular and namespace API
() => query.isEqual(query),
'isEqual',
);
Expand All @@ -1019,6 +1025,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => limit(9),
// @ts-expect-error Combines modular and namespace API
() => query.limit(9),
'limit',
);
Expand All @@ -1031,6 +1038,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => limitToLast(9),
// @ts-expect-error Combines modular and namespace API
() => query.limitToLast(9),
'limitToLast',
);
Expand All @@ -1043,6 +1051,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => onSnapshot(query, () => {}),
// @ts-expect-error Combines modular and namespace API
() => query.onSnapshot(() => {}),
'onSnapshot',
);
Expand All @@ -1055,6 +1064,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => orderBy('foo', 'asc'),
// @ts-expect-error Combines modular and namespace API
() => query.orderBy('foo', 'asc'),
'orderBy',
);
Expand All @@ -1067,6 +1077,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => startAfter('foo'),
// @ts-expect-error Combines modular and namespace API
() => query.startAfter('foo'),
'startAfter',
);
Expand All @@ -1079,6 +1090,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => startAt('foo'),
// @ts-expect-error Combines modular and namespace API
() => query.startAt('foo'),
'startAt',
);
Expand All @@ -1091,6 +1103,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => where('foo', '==', 'bar'),
// @ts-expect-error Combines modular and namespace API
() => query.where('foo', '==', 'bar'),
'where',
);
Expand All @@ -1103,6 +1116,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => addDoc(query, { foo: 'bar' }),
// @ts-expect-error Combines modular and namespace API
() => query.add({ foo: 'bar' }),
'add',
);
Expand All @@ -1115,6 +1129,7 @@ describe('Firestore', function () {

collectionRefV9Deprecation(
() => doc(query, 'bar'),
// @ts-expect-error Combines modular and namespace API
() => query.doc('foo'),
'doc',
);
Expand All @@ -1140,6 +1155,7 @@ describe('Firestore', function () {
const docRef = firestore.doc('some/foo');

docRefV9Deprecation(
// @ts-expect-error Combines modular and namespace imports
() => deleteDoc(docRef),
() => docRef.delete(),
'delete',
Expand All @@ -1152,6 +1168,7 @@ describe('Firestore', function () {
const docRef = firestore.doc('some/foo');

docRefV9Deprecation(
// @ts-expect-error Combines modular and namespace imports
() => getDoc(docRef),
() => docRef.get(),
'get',
Expand All @@ -1177,6 +1194,7 @@ describe('Firestore', function () {
const docRef = firestore.doc('some/foo');

docRefV9Deprecation(
// @ts-expect-error Combines modular and namespace imports
() => onSnapshot(docRef, () => {}),
() => docRef.onSnapshot(() => {}),
'onSnapshot',
Expand All @@ -1189,6 +1207,7 @@ describe('Firestore', function () {
const docRef = firestore.doc('some/foo');

docRefV9Deprecation(
// @ts-expect-error Combines modular and namespace imports
() => setDoc(docRef, { foo: 'bar' }),
() => docRef.set({ foo: 'bar' }),
'set',
Expand All @@ -1201,6 +1220,7 @@ describe('Firestore', function () {
const docRef = firestore.doc('some/foo');

docRefV9Deprecation(
// @ts-expect-error Combines modular and namespace imports
() => updateDoc(docRef, { foo: 'bar' }),
() => docRef.update({ foo: 'bar' }),
'update',
Expand Down
Loading
Loading