-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(firestore): implement withCoverter #8744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(firestore): implement withCoverter #8744
Conversation
|
@JiriHoffmann is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
That is not something I'm used to people apologizing for, this certainly looks worth it. Thanks! Going in the review queue - additionally - if my patch-package generation workflow is working correctly you should be able to start depending on the work relatively easily already via usage of the patch, which should apply cleanly to the current released version of |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ff083c5 to
04d563a
Compare
|
I've fixed the CI issues that were happening with iOS and rebased this PR on to them then force-pushed this PR back out with that new commit history built on the iOS e2e fix I resolved the conversation on the ignoreUndefinedProperties settings and peeled it off to a separate issue so we can move on with out it This is now just on me to do a real code review on it, then if it's good - merge and release. Will be a huge feature, there will be much rejoicing |
Description
Hello! I'm sorry for introducing such a large PR, but I hope it's gonna be worth it.
This PR adds the withCoverter functionality to both the namespace and modular APIs and updates types accordingly.
Both type and e2e tests are a 1:1 copy of the Firebase JS SDK to ensure feature parity.
Related issues
Closes #8611 and these 2 PRs #8698 #8672
Release Summary
Implements
withConverterfrom Firebase JS SDKChecklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__🔥