Skip to content

Commit dd8a3ca

Browse files
Aetherallmikehardy
Aetherall
authored and
mikehardy
committed
feat(oauth): added signIn and link for oauth
1 parent e52e24e commit dd8a3ca

File tree

8 files changed

+314
-35
lines changed

8 files changed

+314
-35
lines changed

‎packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java‎

Lines changed: 112 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@
3030
import com.facebook.react.bridge.WritableArray;
3131
import com.facebook.react.bridge.WritableMap;
3232
import com.google.android.gms.tasks.OnCompleteListener;
33+
import com.google.android.gms.tasks.OnFailureListener;
34+
import com.google.android.gms.tasks.OnSuccessListener;
35+
import com.google.android.gms.tasks.Task;
3336
import com.google.firebase.FirebaseApp;
3437
import com.google.firebase.FirebaseException;
3538
import com.google.firebase.FirebaseNetworkException;
@@ -56,6 +59,7 @@
5659
import com.google.firebase.auth.MultiFactorResolver;
5760
import com.google.firebase.auth.MultiFactorSession;
5861
import com.google.firebase.auth.OAuthProvider;
62+
import com.google.firebase.auth.OAuthCredential;
5963
import com.google.firebase.auth.PhoneAuthCredential;
6064
import com.google.firebase.auth.PhoneAuthOptions;
6165
import com.google.firebase.auth.PhoneAuthProvider;
@@ -203,7 +207,6 @@ public void addIdTokenListener(final String appName) {
203207

204208
FirebaseApp firebaseApp = FirebaseApp.getInstance(appName);
205209
FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
206-
207210
if (!mIdTokenListeners.containsKey(appName)) {
208211
FirebaseAuth.IdTokenListener newIdTokenListener =
209212
firebaseAuth1 -> {
@@ -862,6 +865,87 @@ private void signInWithCredential(
862865
}
863866
}
864867

868+
@ReactMethod
869+
public void signInWithProvider(String appName, String providerId, @Nullable String email, Promise promise){
870+
OAuthProvider.Builder provider = OAuthProvider.newBuilder(providerId);
871+
if(email != null){
872+
provider.addCustomParameter("login_hint", email);
873+
}
874+
Activity activity = getCurrentActivity();
875+
FirebaseApp firebaseApp = FirebaseApp.getInstance(appName);
876+
FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
877+
878+
OnSuccessListener onSuccess = new OnSuccessListener<AuthResult>(){
879+
@Override
880+
public void onSuccess(AuthResult authResult) {
881+
Log.d(TAG, "signInWithProvider:onComplete:success");
882+
promiseWithAuthResult(authResult, promise);
883+
}
884+
};
885+
886+
OnFailureListener onFailure = new OnFailureListener(){
887+
@Override
888+
public void onFailure(@NonNull Exception e) {
889+
Log.w(TAG, "signInWithProvider:onComplete:failure", e);
890+
promiseRejectAuthException(promise, e);
891+
}
892+
};
893+
894+
895+
Task<AuthResult> pendingResultTask = firebaseAuth.getPendingAuthResult();
896+
if(pendingResultTask != null){
897+
pendingResultTask
898+
.addOnSuccessListener(onSuccess)
899+
.addOnFailureListener(onFailure);
900+
} else {
901+
firebaseAuth
902+
.startActivityForSignInWithProvider(activity, provider.build())
903+
.addOnSuccessListener(onSuccess)
904+
.addOnFailureListener(onFailure);
905+
}
906+
}
907+
908+
@ReactMethod
909+
public void linkWithProvider(String appName, String providerId, @Nullable String email, Promise promise){
910+
OAuthProvider.Builder provider = OAuthProvider.newBuilder(providerId);
911+
if(email != null){
912+
provider.addCustomParameter("login_hint", email);
913+
}
914+
Activity activity = getCurrentActivity();
915+
FirebaseApp firebaseApp = FirebaseApp.getInstance(appName);
916+
FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
917+
FirebaseUser firebaseUser = firebaseAuth.getCurrentUser();
918+
919+
OnSuccessListener onSuccess = new OnSuccessListener<AuthResult>(){
920+
@Override
921+
public void onSuccess(AuthResult authResult) {
922+
Log.d(TAG, "linkWithProvider:onComplete:success");
923+
promiseWithAuthResult(authResult, promise);
924+
}
925+
};
926+
927+
OnFailureListener onFailure = new OnFailureListener(){
928+
@Override
929+
public void onFailure(@NonNull Exception e) {
930+
Log.w(TAG, "linkInWithProvider:onComplete:failure", e);
931+
promiseRejectAuthException(promise, e);
932+
}
933+
};
934+
935+
936+
Task<AuthResult> pendingResultTask = firebaseAuth.getPendingAuthResult();
937+
if(pendingResultTask != null){
938+
pendingResultTask
939+
.addOnSuccessListener(onSuccess)
940+
.addOnFailureListener(onFailure);
941+
} else {
942+
firebaseUser
943+
.startActivityForLinkWithProvider(activity, provider.build())
944+
.addOnSuccessListener(onSuccess)
945+
.addOnFailureListener(onFailure);
946+
}
947+
}
948+
865949
/**
866950
* signInWithPhoneNumber
867951
*
@@ -1889,6 +1973,30 @@ private void promiseWithAuthResult(AuthResult authResult, Promise promise) {
18891973
WritableMap authResultMap = Arguments.createMap();
18901974
WritableMap userMap = firebaseUserToMap(authResult.getUser());
18911975

1976+
if(authResult.getCredential() != null){
1977+
if(authResult.getCredential() instanceof OAuthCredential){
1978+
OAuthCredential creds = (OAuthCredential) authResult.getCredential();
1979+
WritableMap credentialMap = Arguments.createMap();
1980+
1981+
credentialMap.putString("providerId", creds.getProvider());
1982+
credentialMap.putString("signInMethod", creds.getSignInMethod());
1983+
1984+
if(creds.getIdToken() != null){
1985+
credentialMap.putString("idToken", creds.getIdToken());
1986+
}
1987+
1988+
if(creds.getAccessToken() != null){
1989+
credentialMap.putString("accessToken", creds.getAccessToken());
1990+
}
1991+
1992+
if(creds.getSecret() != null){
1993+
credentialMap.putString("secret", creds.getSecret());
1994+
}
1995+
1996+
authResultMap.putMap("credential", credentialMap);
1997+
}
1998+
}
1999+
18922000
if (authResult.getAdditionalUserInfo() != null) {
18932001
WritableMap additionalUserInfoMap = Arguments.createMap();
18942002

@@ -1929,6 +2037,7 @@ private void promiseWithAuthResult(AuthResult authResult, Promise promise) {
19292037
*/
19302038
private void promiseRejectAuthException(Promise promise, Exception exception) {
19312039
WritableMap error = getJSError(exception);
2040+
19322041
final String sessionId = error.getString("sessionId");
19332042
final MultiFactorResolver multiFactorResolver = mCachedResolvers.get(sessionId);
19342043
WritableMap resolverAsMap = Arguments.createMap();
@@ -1950,6 +2059,8 @@ private WritableMap getJSError(Exception exception) {
19502059
String message = exception.getMessage();
19512060
String invalidEmail = "The email address is badly formatted.";
19522061

2062+
System.out.print(exception);
2063+
19532064
try {
19542065
FirebaseAuthException authException = (FirebaseAuthException) exception;
19552066
code = authException.getErrorCode();

‎packages/auth/e2e/auth.e2e.js‎

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -912,12 +912,11 @@ describe('auth()', function () {
912912
});
913913

914914
describe('signInWithPopup', function () {
915-
it('should throw an unsupported error', function () {
916-
(() => {
917-
firebase.auth().signInWithPopup();
918-
}).should.throw(
919-
'firebase.auth().signInWithPopup() is unsupported by the native Firebase SDKs.',
920-
);
915+
it('should trigger the oauth flow', async function () {
916+
await (async () => {
917+
const provider = new firebase.auth.OAuthProvider('oidc.react.com');
918+
await firebase.auth().signInWithPopup(provider);
919+
}).should.not.throw();
921920
});
922921
});
923922

@@ -1025,12 +1024,11 @@ describe('auth()', function () {
10251024
});
10261025

10271026
describe('signInWithRedirect()', function () {
1028-
it('should throw an unsupported error', function () {
1029-
(() => {
1030-
firebase.auth().signInWithRedirect();
1031-
}).should.throw(
1032-
'firebase.auth().signInWithRedirect() is unsupported by the native Firebase SDKs.',
1033-
);
1027+
it('should trigger the oauth flow', async function () {
1028+
await (async () => {
1029+
const provider = new firebase.auth.OAuthProvider('oidc.react.com');
1030+
await firebase.auth().signInWithRedirect(provider);
1031+
}).should.not.throw();
10341032
});
10351033
});
10361034

‎packages/auth/e2e/provider.e2e.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,7 @@ describe('auth() -> Providers', function () {
149149
describe('OAuthProvider', function () {
150150
describe('constructor', function () {
151151
it('should throw an unsupported error', function () {
152-
(() => new firebase.auth.OAuthProvider()).should.throw(
153-
'`new OAuthProvider()` is not supported on the native Firebase SDKs.',
154-
);
152+
(() => new firebase.auth.OAuthProvider('oidc.react.com')).should.not.throw();
155153
});
156154
});
157155

‎packages/auth/ios/RNFBAuth/RNFBAuthModule.m‎

Lines changed: 115 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@
4545
static NSString *const keyHandleCodeInApp = @"handleCodeInApp";
4646
static NSString *const keyDynamicLinkDomain = @"dynamicLinkDomain";
4747
static NSString *const keyAdditionalUserInfo = @"additionalUserInfo";
48+
static NSString *const keyCredential = @"credential";
49+
static NSString *const keyIdToken = @"idToken";
50+
static NSString *const keyAccessToken = @"accessToken";
51+
static NSString *const keySecret = @"secret";
4852
static NSString *const AUTH_STATE_CHANGED_EVENT = @"auth_state_changed";
4953
static NSString *const AUTH_ID_TOKEN_CHANGED_EVENT = @"auth_id_token_changed";
5054
static NSString *const PHONE_AUTH_STATE_CHANGED_EVENT = @"phone_auth_state_changed";
@@ -56,6 +60,7 @@
5660
static __strong NSMutableDictionary<NSString *, FIRAuthCredential *> *credentials;
5761
static __strong NSMutableDictionary<NSString *, FIRMultiFactorResolver *> *cachedResolver;
5862
static __strong NSMutableDictionary<NSString *, FIRMultiFactorSession *> *cachedSessions;
63+
static __strong NSMutableDictionary<NSString *, FIROAuthProvider *> *oAuthProviders;
5964

6065
@implementation RNFBAuthModule
6166
#pragma mark -
@@ -77,6 +82,7 @@ - (id)init {
7782
credentials = [[NSMutableDictionary alloc] init];
7883
cachedResolver = [[NSMutableDictionary alloc] init];
7984
cachedSessions = [[NSMutableDictionary alloc] init];
85+
oAuthProviders = [[NSMutableDictionary alloc] init];
8086
});
8187
return self;
8288
}
@@ -104,6 +110,7 @@ - (void)invalidate {
104110
[credentials removeAllObjects];
105111
[cachedResolver removeAllObjects];
106112
[cachedSessions removeAllObjects];
113+
[oAuthProviders removeAllObjects];
107114
}
108115

109116
#pragma mark -
@@ -571,6 +578,73 @@ - (void)invalidate {
571578
}];
572579
}
573580

581+
582+
RCT_EXPORT_METHOD(signInWithProvider
583+
: (FIRApp *)firebaseApp
584+
: (NSString *)providerID
585+
: (NSString *_Nullable)email
586+
: (RCTPromiseResolveBlock)resolve
587+
: (RCTPromiseRejectBlock)reject) {
588+
FIROAuthProvider *provider = [FIROAuthProvider providerWithProviderID:providerID];
589+
[oAuthProviders setValue:provider forKey:providerID];
590+
591+
if (email) {
592+
[provider setCustomParameters:@{@"login_hint": email}];
593+
}
594+
595+
[provider getCredentialWithUIDelegate:nil
596+
completion:^(FIRAuthCredential *_Nullable credential, NSError *_Nullable error) {
597+
if (error) {
598+
[self promiseRejectAuthException:reject error:error];
599+
}
600+
601+
if (credential) {
602+
[[FIRAuth auth] signInWithCredential:credential
603+
completion:^(FIRAuthDataResult *_Nullable authResult, NSError *_Nullable error) {
604+
if (error) {
605+
[self promiseRejectAuthException:reject error:error];
606+
}
607+
else {
608+
[self promiseWithAuthResult:resolve rejecter:reject authResult:authResult credential:credential];
609+
}
610+
}];
611+
}
612+
}];
613+
}
614+
615+
RCT_EXPORT_METHOD(linkWithProvider
616+
: (FIRApp *)firebaseApp
617+
: (NSString *)providerID
618+
: (NSString *_Nullable)email
619+
: (RCTPromiseResolveBlock)resolve
620+
: (RCTPromiseRejectBlock)reject) {
621+
FIROAuthProvider *provider = [FIROAuthProvider providerWithProviderID:providerID];
622+
[oAuthProviders setValue:provider forKey:providerID];
623+
624+
if (email) {
625+
[provider setCustomParameters:@{@"login_hint": email}];
626+
}
627+
628+
[provider getCredentialWithUIDelegate:nil
629+
completion:^(FIRAuthCredential *_Nullable credential, NSError *_Nullable error) {
630+
if (error) {
631+
[self promiseRejectAuthException:reject error:error];
632+
}
633+
634+
if (credential) {
635+
[[FIRAuth auth].currentUser linkWithCredential:credential
636+
completion:^(FIRAuthDataResult *_Nullable authResult, NSError *_Nullable error) {
637+
if (error) {
638+
[self promiseRejectAuthException:reject error:error];
639+
}
640+
else {
641+
[self promiseWithAuthResult:resolve rejecter:reject authResult:authResult credential:credential];
642+
}
643+
}];
644+
}
645+
}];
646+
}
647+
574648
RCT_EXPORT_METHOD(confirmPasswordReset
575649
: (FIRApp *)firebaseApp
576650
: (NSString *)code
@@ -1315,7 +1389,14 @@ - (void)promiseWithUser:(RCTPromiseResolveBlock)resolve
13151389

13161390
- (void)promiseWithAuthResult:(RCTPromiseResolveBlock)resolve
13171391
rejecter:(RCTPromiseRejectBlock)reject
1318-
authResult:(FIRAuthDataResult *)authResult {
1392+
authResult:(FIRAuthDataResult *)authResult {
1393+
[self promiseWithAuthResult:resolve rejecter:reject authResult:authResult credential:nil];
1394+
}
1395+
1396+
- (void)promiseWithAuthResult:(RCTPromiseResolveBlock)resolve
1397+
rejecter:(RCTPromiseRejectBlock)reject
1398+
authResult:(FIRAuthDataResult *)authResult
1399+
credential:(FIRAuthCredential *_Nullable)credential {
13191400
if (authResult && authResult.user) {
13201401
NSMutableDictionary *authResultDict = [NSMutableDictionary dictionary];
13211402

@@ -1347,6 +1428,39 @@ - (void)promiseWithAuthResult:(RCTPromiseResolveBlock)resolve
13471428
[authResultDict setValue:[NSNull null] forKey:keyAdditionalUserInfo];
13481429
}
13491430

1431+
if (credential && ([credential isKindOfClass:[FIROAuthCredential class]])) {
1432+
NSMutableDictionary *credentialDict = [NSMutableDictionary dictionary];
1433+
FIROAuthCredential* oAuthCredential = (FIROAuthCredential *)credential;
1434+
1435+
[credentialDict setValue:oAuthCredential.provider forKey:keyProviderId];
1436+
1437+
if (oAuthCredential.IDToken) {
1438+
[credentialDict setValue:oAuthCredential.IDToken forKey:keyIdToken];
1439+
}
1440+
else {
1441+
[credentialDict setValue:[NSNull null] forKey:keyIdToken];
1442+
}
1443+
1444+
if (oAuthCredential.accessToken) {
1445+
[credentialDict setValue:oAuthCredential.accessToken forKey:keyAccessToken];
1446+
}
1447+
else {
1448+
[credentialDict setValue:[NSNull null] forKey:keyAccessToken];
1449+
}
1450+
1451+
if (oAuthCredential.accessToken) {
1452+
[credentialDict setValue:oAuthCredential.secret forKey:keySecret];
1453+
}
1454+
else {
1455+
[credentialDict setValue:[NSNull null] forKey:keySecret];
1456+
}
1457+
1458+
[authResultDict setValue:credentialDict forKey:keyCredential];
1459+
}
1460+
else {
1461+
[authResultDict setValue:[NSNull null] forKey:keyCredential];
1462+
}
1463+
13501464
[authResultDict setValue:[self firebaseUserToDict:authResult.user] forKey:keyUser];
13511465
resolve(authResultDict);
13521466
} else {

‎packages/auth/lib/User.js‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -310,16 +310,14 @@ export default class User {
310310
);
311311
}
312312

313-
linkWithPopup() {
314-
throw new Error(
315-
'firebase.auth.User.linkWithPopup() is unsupported by the native Firebase SDKs.',
316-
);
313+
linkWithPopup(provider) {
314+
return this._auth.native
315+
.linkWithProvider(provider.providerId, provider.customParameters?.login_hint)
316+
.then(userCredential => this._auth._setUserCredential(userCredential));
317317
}
318318

319-
linkWithRedirect() {
320-
throw new Error(
321-
'firebase.auth.User.linkWithRedirect() is unsupported by the native Firebase SDKs.',
322-
);
319+
async linkWithRedirect(provider) {
320+
return this.linkWithPopup(provider);
323321
}
324322

325323
reauthenticateWithPhoneNumber() {

0 commit comments

Comments
 (0)