test(auth): getRandomPhoneNumber is not async, do not await

Author: mikehardy

packages/auth/e2e/phone.e2e.js

@@ -23,7 +23,7 @@ describe('auth() => Phone', function () {
 
   describe('signInWithPhoneNumber', function () {
     it('signs in with a valid code', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       const confirmResult = await firebase.auth().signInWithPhoneNumber(testPhone);
       confirmResult.verificationId.should.be.a.String();
       should.ok(confirmResult.verificationId.length, 'verificationId string should not be empty');
@@ -37,7 +37,7 @@ describe('auth() => Phone', function () {
     });
 
     it('errors on invalid code', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       const confirmResult = await firebase.auth().signInWithPhoneNumber(testPhone);
       confirmResult.verificationId.should.be.a.String();
       should.ok(confirmResult.verificationId.length, 'verificationId string should not be empty');
@@ -56,23 +56,23 @@ describe('auth() => Phone', function () {
 
   describe('verifyPhoneNumber', function () {
     it('successfully verifies', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       const confirmResult = await firebase.auth().signInWithPhoneNumber(testPhone);
       const lastSmsCode = await getLastSmsCode(testPhone);
       await confirmResult.confirm(lastSmsCode);
       await firebase.auth().verifyPhoneNumber(testPhone, false, false);
     });
 
     it('uses the autoVerifyTimeout when a non boolean autoVerifyTimeoutOrForceResend is provided', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       const confirmResult = await firebase.auth().signInWithPhoneNumber(testPhone);
       const lastSmsCode = await getLastSmsCode(testPhone);
       await confirmResult.confirm(lastSmsCode);
       await firebase.auth().verifyPhoneNumber(testPhone, 0, false);
     });
 
     it('throws an error with an invalid on event', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       try {
         await firebase
           .auth()
@@ -89,7 +89,7 @@ describe('auth() => Phone', function () {
     });
 
     it('throws an error with an invalid observer event', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       try {
         await firebase
           .auth()
@@ -106,7 +106,7 @@ describe('auth() => Phone', function () {
     });
 
     it('successfully runs verification complete handler', async function () {
-      const testPhone = await getRandomPhoneNumber();
+      const testPhone = getRandomPhoneNumber();
       await firebase
         .auth()
         .verifyPhoneNumber(testPhone)