Missing types and fix web parity

Author: jamespb97

packages/auth/lib/TotpMultiFactorGenerator.js

@@ -25,15 +25,11 @@ export default class TotpMultiFactorGenerator {
   }
 
   static assertionForSignIn(uid, verificationCode) {
-    // There is no logic here, we mainly do this for API compatibility
-    // (following the Web API).
     return { uid, verificationCode };
   }
 
   static assertionForEnrollment(totpSecret, verificationCode) {
-    // There is no logic here, we mainly do this for API compatibility
-    // (following the Web API).
-    return { totpSecret, verificationCode };
+    return { totpSecret: totpSecret.secretKey, verificationCode };
   }
 
   static async generateSecret(session, auth) {

packages/auth/lib/index.d.ts

@@ -276,9 +276,16 @@ export namespace FirebaseAuthTypes {
   }
 
   export interface TotpMultiFactorGenerator {
-    FACTOR_ID: FactorId.TOTP;
+    static FACTOR_ID: FactorId.TOTP;
 
-    assertionForSignIn(uid: string, totpSecret: string): MultiFactorAssertion;
+    static assertionForSignIn(uid: string, totpSecret: string): MultiFactorAssertion;
+    
+    static assertionForEnrollment(secret: TotpSecret, code: string): MultiFactorAssertion;
+
+    /**
+     * @param auth - The Auth instance. Only used for native platforms, should be ignored on web.
+     */
+    static generateSecret(session: FirebaseAuthTypes.MultiFactorSession, auth: FirebaseAuthTypes.Auth): Promise<TotpSecret>;
   }
 
   export declare interface MultiFactorError extends AuthError {