Skip to content

Commit 7457ab0

Browse files
committed
fix(firestore): remove unknown from modular types
1 parent 289e6be commit 7457ab0

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

packages/firestore/lib/modular/index.d.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -827,12 +827,6 @@ export declare function doc<AppModelType, DbModelType extends DocumentData>(
827827
...pathSegments: string[]
828828
): DocumentReference<DocumentData, DocumentData>;
829829

830-
export function doc<T>(
831-
parent: Firestore | CollectionReference<T> | DocumentReference<unknown>,
832-
path?: string,
833-
...pathSegments: string[]
834-
): DocumentReference;
835-
836830
/**
837831
* Gets a `CollectionReference` instance that refers to the collection at
838832
* the specified absolute path.
@@ -905,12 +899,6 @@ export function collection(
905899
...pathSegments: string[]
906900
): CollectionReference<DocumentData>;
907901

908-
export function collection(
909-
parent: Firestore | DocumentReference<unknown> | CollectionReference<unknown>,
910-
path: string,
911-
...pathSegments: string[]
912-
): CollectionReference<DocumentData>;
913-
914902
/**
915903
*Returns true if the provided references are equal.
916904
*

packages/firestore/lib/modular/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export function getFirestore(app, databaseId) {
4545
}
4646

4747
/**
48-
* @param {Firestore | CollectionReference | DocumentReference<unknown>} parent
48+
* @param {Firestore | CollectionReference | DocumentReference} parent
4949
* @param {string?} path
5050
* @param {string?} pathSegments
5151
* @returns {DocumentReference}
@@ -59,7 +59,7 @@ export function doc(parent, path, ...pathSegments) {
5959
}
6060

6161
/**
62-
* @param {Firestore | DocumentReference<unknown> | CollectionReference<unknown>} parent
62+
* @param {Firestore | DocumentReference | CollectionReference} parent
6363
* @param {string} path
6464
* @param {string?} pathSegments
6565
* @returns {CollectionReference<DocumentData>}

packages/firestore/lib/modular/query.d.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ export function orderBy(
183183
* @param snapshot - The snapshot of the document to start at.
184184
* @returns A {@link QueryStartAtConstraint} to pass to `query()`.
185185
*/
186-
export function startAt(snapshot: DocumentSnapshot<unknown>): QueryStartAtConstraint;
186+
export function startAt(snapshot: DocumentSnapshot): QueryStartAtConstraint;
187187
/**
188188
*
189189
* Creates a {@link QueryStartAtConstraint} that modifies the result set to
@@ -196,9 +196,7 @@ export function startAt(snapshot: DocumentSnapshot<unknown>): QueryStartAtConstr
196196
*/
197197
export function startAt(...fieldValues: unknown[]): QueryStartAtConstraint;
198198

199-
export function startAt(
200-
...docOrFields: Array<unknown | DocumentSnapshot<unknown>>
201-
): QueryStartAtConstraint;
199+
export function startAt(...docOrFields: Array<unknown | DocumentSnapshot>): QueryStartAtConstraint;
202200

203201
/**
204202
* Creates a {@link QueryStartAtConstraint} that modifies the result set to

0 commit comments

Comments
 (0)