test(e2e): consolidate cloud helper function calling

there were two places this was defined, and I just added 429 /
quota-exceeded retries to one, both could use it though

so focus all cloud helper function usage through a single code path

Author: mikehardy

packages/remote-config/e2e/config.e2e.js

@@ -15,8 +15,6 @@
  *
  */
 
-const { updateTemplate } = require('./helpers');
-
 describe('remoteConfig()', function () {
   describe('firebase v8 compatibility', function () {
     beforeEach(async function beforeEachTest() {
@@ -782,7 +780,7 @@ describe('remoteConfig()', function () {
 
         // If there is orphaned data, delete it on the server and let that settle
         if (staleDeletes.length > 0) {
-          const response = await updateTemplate({
+          const response = await FirebaseHelpers.updateRemoteConfigTemplate({
             operations: {
               delete: staleDeletes,
             },
@@ -797,7 +795,7 @@ describe('remoteConfig()', function () {
 
       after(async function () {
         // clean up our own test data after the whole suite runs
-        const response = await updateTemplate({
+        const response = await FirebaseHelpers.updateRemoteConfigTemplate({
           operations: {
             delete: ['rttest1' + timestamp, 'rttest2' + timestamp, 'rttest3' + timestamp],
           },
@@ -823,7 +821,7 @@ describe('remoteConfig()', function () {
         const unsubscribe = onConfigUpdated(config, (event, error) => callback(event, error));
         unsubscribers.push(unsubscribe);
         // Update the template using our cloud function, so our listeners are called
-        let response = await updateTemplate({
+        let response = await FirebaseHelpers.updateRemoteConfigTemplate({
           operations: {
             add: [{ name: 'rttest1' + timestamp, value: timestamp }],
           },
@@ -858,7 +856,7 @@ describe('remoteConfig()', function () {
         unsubscribers.push(unsubscribe3);
 
         // Trigger an update that should call them all
-        let response = await updateTemplate({
+        let response = await FirebaseHelpers.updateRemoteConfigTemplate({
           operations: {
             add: [{ name: 'rttest1' + timestamp, value: Date.now() + '' }],
           },
@@ -887,7 +885,7 @@ describe('remoteConfig()', function () {
         const callback2Count = callback2.callCount;
 
         // Trigger update that should call listener 1 and 3 for these values
-        response = await updateTemplate({
+        response = await FirebaseHelpers.updateRemoteConfigTemplate({
           operations: {
             add: [{ name: 'rttest2' + timestamp, value: Date.now() + '' }],
           },
@@ -916,7 +914,7 @@ describe('remoteConfig()', function () {
         const callback3Count = callback3.callCount;
 
         // Trigger an update that should call no listeners
-        response = await updateTemplate({
+        response = await FirebaseHelpers.updateRemoteConfigTemplate({
           operations: {
             add: [{ name: 'rttest3' + timestamp, value: Date.now() + '' }],
           },

packages/remote-config/e2e/helpers.js

@@ -89,6 +89,7 @@ import * as mlModular from '@react-native-firebase/ml';
 import { Platform } from 'react-native';
 import NativeEventEmitter from '@react-native-firebase/app/lib/internal/RNFBNativeEventEmitter';
 import { getReactNativeModule } from '@react-native-firebase/app/lib/internal/nativeModule';
+import { getE2eTestProject } from '@react-native-firebase/app/e2e/helpers';
 
 global.should = shouldMatchers;
 global.sinon = require('sinon');
@@ -181,25 +182,47 @@ global.FirebaseHelpers = {
       };
     },
   },
-  async fetchAppCheckToken() {
-    const tokenRequest = await fetch(
-      'https://us-central1-react-native-firebase-testing.cloudfunctions.net/fetchAppCheckTokenV2',
-      {
-        method: 'POST',
-        headers: {
-          'Content-Type': 'application/json',
+  async callCloudHelperFunction(functioNName, postData) {
+    let doc = undefined;
+    let retries = 0;
+    let maxRetries = 5;
+    // We handle 429 errors in a retry loop
+    while ((doc === undefined || doc.status === 429) && retries < maxRetries) {
+      doc = await fetch(
+        `https://us-central1-${getE2eTestProject()}.cloudfunctions.net/${functioNName}`,
+        {
+          method: 'POST',
+          body: JSON.stringify({ data: postData }),
+          headers: { 'Content-Type': 'application/json' },
         },
-        body: JSON.stringify({
-          data: {
-            appId: global.FirebaseHelpers.app.config().appId,
-          },
-        }),
-        redirect: 'follow',
-      },
-    );
-    const { result } = await tokenRequest.json();
+      );
+      if (doc.status === 429) {
+        // We have been delayed by concurrency limits or rate limits
+        // We'll sleep for a little bit then try again.
+        const delayRequired = 10;
+        await new Promise(r => setTimeout(r, delayRequired * 1000));
+      }
+      retries++;
+    }
+
+    // did we eventually have success? If not, error.
+    if (retries === maxRetries && doc.status !== 200) {
+      throw new Error('Unable to execute cloud remote config helper function');
+    }
+    const result = await doc.json();
+    // console.error('received: ' + JSON.stringify(result));
+    return result;
+  },
+  async fetchAppCheckToken() {
+    const tokenRequset = await this.callCloudHelperFunction('fetchAppCheckTokenV2', {
+      appId: global.FirebaseHelpers.app.config().appId,
+    });
+    const { result } = tokenRequset;
     return result;
   },
+  async updateRemoteConfigTemplate(operations) {
+    return await this.callCloudHelperFunction('testFunctionRemoteConfigUpdateV2', operations);
+  },
 };
 
 global.android = {